simon qian wrote:
> > If you wouldn't mind, try creating a patch next time:
> > git add
> > git commit
> > git format-patch origin/master
> > => generate patches for all commits since origin/master
> OK.
> I used to generate the patch using git diff command.
> I'll use new command next time.
Perf
> If you wouldn't mind, try creating a patch next time:
> git add
> git commit
> git format-patch origin/master
> => generate patches for all commits since origin/master
OK.
I used to generate the patch using git diff command.
I'll use new command next time.
--
Best Regards, SimonQian
http://www
Merged.
Thanks!
If you wouldn't mind, try creating a patch next time:
git add
git commit
git format-patch origin/master
=> generate patches for all commits since origin/master
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 8
Øyvind Harboe wrote:
> Any objections to applying these two fixes?
>
> I'd break it apart in two commits.
Acked-by: Peter Stuge
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-
Any objections to applying these two fixes?
I'd break it apart in two commits.
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash progra
I mention 2 bugs, one is the vector++ in LOG_DEBUG, the other is
the wrong index of argv.
argv[0] is the command itself, argv[1] the the transport to select.
2011/1/12 Øyvind Harboe
> Hi Simon,
>
> Peter Stuge pointed out that there are two changes in this
> patch. The first is the bugfix you've
Hi Simon,
Peter Stuge pointed out that there are two changes in this
patch. The first is the bugfix you've spoken about, but what
is the second change?
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com
Øyvind Harboe wrote:
> It's only the first change in this diff that is a bugfix, right?
I think there are two bugfixes.
> There were two extra whitespace changes that I'll drop
> for this commit.
Note the argv[] index change. Maybe two commits though..
//Peter
It's only the first change in this diff that is a bugfix, right?
There were two extra whitespace changes that I'll drop
for this commit.
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
AR
Here is the patch. See attachment.
2011/1/12 Øyvind Harboe
> Nice catch!
>
> The same problem applies to all LOG_ statements
> really.
>
> Patch?
>
> --
> Øyvind Harboe
>
> Can Zylin Consulting help on your project?
>
> US toll free 1-866-980-3434 / International +47 51 87 40 27
>
> http://www.zy
Nice catch!
The same problem applies to all LOG_ statements
really.
Patch?
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
All LOG_DEBUG should be checked for such operation.
It may not perform as people expect.
2011/1/12 simon qian
> In transport.c:
>
> 1. I use "transport select jtag", in jim_transport_select, argv[0]->bytes
> is "select", so argv[1]->bytes should be used.
> 2. In allow_transports function:
> [cod
In transport.c:
1. I use "transport select jtag", in jim_transport_select, argv[0]->bytes is
"select", so argv[1]->bytes should be used.
2. In allow_transports function:
[code]
while (*vector)
LOG_DEBUG("allow transport '%s'", *vector++);
[/code]
LOG_DEBUG is:
[code]
#define LOG_DEBUG(expr .
13 matches
Mail list logo
