Re: OpenPKG-current Apache RPM: PHP PEAR include directories broken ***SOLVED***

2003-12-17 Thread Stuart Bingë
As far as I can tell I've solved the problem, so I thought I'd post the 
solution here for discussion...

This one-line patch modifies apache.spec from the OpenPKG-current apache 
source rpm (apache-1.3.29-20031128.src.rpm). The problem arises when 
'make install'ing the php package, where currently the 'prefix' variable 
is overwritten to point to the temporary RPM install directory. The 
'prefix' variable is however also set when ./configure'ing, which is 
where it is supposed to be set. The correct variable to change when 
'make install'ing is INSTALL_ROOT - this can be set to the temporary RPM 
install directory and does not end up modifying the relevant PHP scripts 
which continue to use the previously defined 'prefix' variable.

There may be other places where this fix could be applied (e.g. the PHP3 
package), however as I only needed the PHP4 package it is the only one I 
fixed in the spec file.

Regards,
Stuart Bingë
--- apache.spec.old	2003-12-17 12:02:26.536340576 +0200
+++ apache.spec	2003-12-17 12:02:48.292033208 +0200
@@ -688,7 +688,7 @@
   -e s;^\\(PEAR_INSTALLDIR = \\)\\(%{l_prefix}\\);\\1$RPM_BUILD_ROOT\\2; \
   config_vars.mk
   %{l_make} %{l_mflags} install \
-  prefix=$RPM_BUILD_ROOT%{l_prefix}
+  INSTALL_ROOT=$RPM_BUILD_ROOT
 ) || exit $?
 %endif
 


Re: OpenPKG-current Apache RPM: PHP PEAR include directories broken ***SOLVED***

2003-12-17 Thread Ralf S. Engelschall
On Wed, Dec 17, 2003, Stuart Bingë wrote:

 As far as I can tell I've solved the problem, so I thought I'd post the
 solution here for discussion...

 This one-line patch modifies apache.spec from the OpenPKG-current apache
 source rpm (apache-1.3.29-20031128.src.rpm). The problem arises when
 'make install'ing the php package, where currently the 'prefix' variable
 is overwritten to point to the temporary RPM install directory. The
 'prefix' variable is however also set when ./configure'ing, which is
 where it is supposed to be set. The correct variable to change when
 'make install'ing is INSTALL_ROOT - this can be set to the temporary RPM
 install directory and does not end up modifying the relevant PHP scripts
 which continue to use the previously defined 'prefix' variable.

 There may be other places where this fix could be applied (e.g. the PHP3
 package), however as I only needed the PHP4 package it is the only one I
 fixed in the spec file.

Thanks for your feedback. I've comitted your fix to CVS.
See http://cvs.openpkg.org/chngview?cn=13827 for details.

   Ralf S. Engelschall
   [EMAIL PROTECTED]
   www.engelschall.com

__
The OpenPKG Projectwww.openpkg.org
User Communication List  [EMAIL PROTECTED]