Hi Hans,
Nice work!
I do have some comment that I think needs to be fixed.
amfd:
- main.cc, function rda_cb, memory is allocated with malloc, this is
later returned with delete in avsv_d2d_msg_free() called from
avd_role_change_evh(). I think this malloc should be changed to new
- csiattr.cc,
Hi Hans, thanks, see comments below/BR HansN
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: den 23 oktober 2013 08:46
To: Hans Nordebäck
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of
Hi Neel,
First, obviously we did not review your fix for #560 properly.
I also now see that the changesets for the fix for #560 are actually tagged
with #563.
Ticket #560 says that the problem is related to #563, but I dont see how.
Or perhaps you just mean that you discovered problem #560 while
Hi,
Some more comments from looking at libs/common
- I guess the tmp_common files should be removed?
- d2nedu.c, memory is allocated with malloc in a couple of places. It
is later freed from many locations by calling avsv_dnd_msg_free_TMP
which then uses delete in a couple of places. There
osaf/services/saf/amf/amfd/include/proc.h |1 +
osaf/services/saf/amf/amfd/ndfsm.cc |4 +
osaf/services/saf/amf/amfd/ndproc.cc | 102 ++
3 files changed, 107 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/proc.h
Hi, I guess libs/common are used from the agents as well and cannot be
changed to new/delete, thats why I created a tmp common to be used from c++.
If some c++ parts (not all) allocates memory via d2nedu.c they have to
use the related free method. I must have missed those calls, I'll check
-Original Message-
From: Hans Nordebäck
Sent: den 23 oktober 2013 12:50
To: Hans Feldt
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net; Hans Nordebäck
Subject: Re: [devel] [PATCH 0 of 1] Review Request for amf #94
Hi, I guess
On 23-Oct-13 12:24 PM, Hans Feldt wrote:
Hi,
The problem is the race mentioned in the ticket. By design we want to be sure
such race does not exist. My proposed change guarantees that we can _always_
trust ava down as being a fault in the component.
In race condition there can be two
Summary:CLM: corrected memory leaks in clma (#604)
Review request for Trac Ticket(s): 604
Peer Reviewer(s): Mathi, Ramesh
Pull request to:
Affected branch(es):4.2.x,4.3.x,default
Development branch:
Impacted area Impact y/n
osaf/libs/agents/saf/clma/clma_util.c | 4
1 files changed, 4 insertions(+), 0 deletions(-)
freed the memory when the clma callback is called with older version.
diff --git a/osaf/libs/agents/saf/clma/clma_util.c
b/osaf/libs/agents/saf/clma/clma_util.c
---
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: den 23 oktober 2013 14:05
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amf: change saAmfResponse to be
synchronous in TerminateCallback context [#570]
But if memory is malloc'ed by the EDU's in libs/common, the same
libs/common free utils should be called and there will be no need for
tmp_common.cc ?
Now it just creates an imbalance between malloc and delete
Ideally I would like to get rid of the EDU use and do it like for
example IMM with
Yes, but some memory are allocated using new (before with malloc) and
not via libs/common, and free'd via e.g. avsv_dnd_msg_free. So
the short term solution is to use tmp common for these constructs and
should be reworked and removed in later patches.
/BR HansN
On 10/23/13 14:21, Hans Feldt
Summary: base: change ncs_os_lock to use osaf_mutex_ utils
Review request for Trac Ticket(s): 605
Peer Reviewer(s): Ramesh
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): all
Development branch: 4.3
Impacted area Impact y/n
NACK from me.
cl_node and NCS_UNLOCK are not related at all, and freeing cl_node before
NCS_UNLOCK does not have any effect on NCS_UNLOCK.
There is a bug in locking/unlocking of the control block lock in #560 that I
missed in the review, and which may cause this assert if a client uses
Moving the deadline for this forward one week from Oct 28 to Nov 4, since we
have been full up with other tickets.
At this point in time I think the most important tests/checks/analysis is to
ensure that
The 2PBE patches do not interfere with regular 1PBE/0PBE.
2PBE will only be activated if
Summary: mds: change Unix sock file osaf_dtm_intra_server path [#606]
Review request for Trac Ticket(s): #606
Peer Reviewer(s): Ramesh
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): default
Development branch: default
Impacted area
osaf/services/infrastructure/nid/scripts/opensafd.in | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/services/infrastructure/nid/scripts/opensafd.in
b/osaf/services/infrastructure/nid/scripts/opensafd.in
--- a/osaf/services/infrastructure/nid/scripts/opensafd.in
18 matches
Mail list logo
