Hi Hans,
Let us have ticket ,for now I will convert assert to return an error.
-AVM
On 10/29/2013 5:40 PM, Hans Feldt wrote:
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>> Sent: den 29 oktober 2013 12:25
>> To: Hans Feldt
>> Cc: opensaf-devel@lists.sourcef
Hi Anders,
I am not sure on the motivation behind adding more utilities to
core/leap area.
Also to what extent all these utility functions are used by OpenSAF
services?. Because on behalf of ticket# 537, I am cleaning up the unused
code from leap area and adding more utilities with out actuall
Hi,
The approach seems fine. Just some minor comments:
* You recently introduced report_ccb_validation_error(), I think this new
function should be named similar. I suggest
report_admin_op_error
* In avd_saImmOiAdminOperationResult() there is a call to saflog() which needs
to be kept in the n
Hi!
Thanks for the comments. Se my replies inline below.
regards,
Anders Widell
2013-10-30 10:00, Ramesh Betham skrev:
> Hi Anders,
>
> I am not sure on the motivation behind adding more utilities to
> core/leap area.
>
> Also to what extent all these utility functions are used by OpenSAF
> se
Hi Hans,
Thanks for your review.
>>* In avd_saImmOiAdminOperationResult() there is a call to saflog() which
>>needs to be kept in the new function. Also the TRACE in
>>avd_saImmOiAdminOperationResult() should be kept in order to associate
>>request with response.
I can keep saflog() in
On 10/30/2013 10:59 AM, Nagendra Kumar wrote:
> Hi Hans, Thanks for your review.
>>> * In avd_saImmOiAdminOperationResult() there is a call to saflog() which
>>> needs to be kept in the new function.
>>> Also the TRACE in avd_saImmOiAdminOperationResult() should be kept in order
>>> to associat
Summary: amfd: Donot send instantiate message from Amfd to Amfnd for
instantiated SUs [#608]
Review request for Trac Ticket(s): #608
Peer Reviewer(s): Hans F, Praveen, Hans N
Pull request to:
Affected branch(es): All
Development branch: Default
Impacted area
osaf/services/saf/amf/amfd/clm.cc | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/clm.cc
b/osaf/services/saf/amf/amfd/clm.cc
--- a/osaf/services/saf/amf/amfd/clm.cc
+++ b/osaf/services/saf/amf/amfd/clm.cc
@@ -51,7 +51,8 @@ static void clm_node_
I am refloating the patch again.
I am leaving your below comment as it looks ok for me as of now:
> * avd_saImmOiAdminOperationResult() was calling
> immutil_saImmOiAdminOperationResult() thus handling TRYAGAIN. I think it is
> OK to skip that.
Thanks
-Nagu
-Original Message-
From: Han
Summary: amfd: Prototype for ticket [#85]
Review request for Trac Ticket(s): #85
Peer Reviewer(s): Hans F, Praveen
Pull request to:
Affected branch(es): Default
Development branch: Default
Impacted area Impact y/n
Docs
osaf/services/saf/amf/amfd/imm.cc| 41 +++
osaf/services/saf/amf/amfd/include/imm.h | 3 +
osaf/services/saf/amf/amfd/su.cc | 86 +++
3 files changed, 86 insertions(+), 44 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b/o
Ack.
Thanks,
Praveen
On 30-Oct-13 4:37 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfd/clm.cc | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfd/clm.cc
> b/osaf/services/saf/amf/amfd/clm.cc
> --- a/osaf/services/saf/amf/amfd
Hi Anders,
>> [Ramesh]: Above function should take care of comparing i_end and
i_start tmr values and should take appropriate action.
> [AndersW]: Do you mean that the function...
For the above comment I'll make a direct statement., what if user gives
"i_end" timer values lesser-than "i_
Some questions about the amfd CLM design which is not very clear.
Standby amfd at failover starts CLM tracking (deep down in
avd_sg_2n_susi_sucss_sg_reln). It starts tracking with
SA_TRACK_CURRENT. The reason for this seems to be to add the AMF node in a tree
based on nodeid coming from the CLM
Not sure, so I did add check for presence state.
Thanks
-Nagu
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: 30 October 2013 17:46
To: Nagendra Kumar; hans.nordeb...@ericsson.com; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of
On 10/30/2013 02:08 PM, Nagendra Kumar wrote:
> Not sure, so I did add check for presence state.
I can understand why we do SA_TRACK_CURRENT at cluster start (to collect
current node IDs) but the same does not make
sense later on.
So ack but I think you should fix your changelog. The one liner
2013-10-30 12:49, Ramesh Betham skrev:
> Hi Anders,
>
> >> [Ramesh]: Above function should take care of comparing i_end and
> i_start tmr values and should take appropriate action.
> > [AndersW]: Do you mean that the function...
>
> For the above comment I'll make a direct statement., what i
Hi,
I have installed openSAF3.0 with N-way Active 2 controller and payload node.
I am inquisitive how do I find out which version of openSAF is intalled
through a command or any directory which shows what openSAF is installed
Regards,
Neha
-
Looks fine with me.
Thanks,
Hans
On 10/30/2013 12:40 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfd/imm.cc| 41 +++
> osaf/services/saf/amf/amfd/include/imm.h | 3 +
> osaf/services/saf/amf/amfd/su.cc | 86
> +++
> 3
Hi,
With old AMFND and new agent, application crashes:
Program terminated with signal 11, Segmentation fault.
#0 0x7f1398d9d132 in saAmfResponse (hdl=4289724417, inv=4286578694,
error=)
at ava_api.c:1890
warning: Source file is more recent than executable.
1890if (m
Following fix avoid crash :
diff --git a/osaf/libs/agents/saf/amfa/ava_api.c
b/osaf/libs/agents/saf/amfa/ava_api.c
--- a/osaf/libs/agents/saf/amfa/ava_api.c
+++ b/osaf/libs/agents/saf/amfa/ava_api.c
@@ -1887,17 +1887,21 @@ SaAisErrorT saAmfResponse(SaAmfHandleT h
rc = SA_AIS_ERR
21 matches
Mail list logo
