Re: [devel] [PATCH 1 of 1] mds: correct osaf-transport-monitor script to avoid looping when sh is not bash [#232]

2013-11-21 Thread Hans Feldt
Please push this patch asap. My other comments should be addressed asap. Better commit message: "dtm: fix bashism in monitor script [232]" Thanks, Hans > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: den 21 november 2013 06:25 > To: Hans Feldt > Subject:

Re: [devel] [PATCH 00 of 15] Review Request for osaf: Replace select() with osaf_poll() to avoid 1024 fd limit [#452]

2013-11-21 Thread Ramesh Betham
Hi Anders, Here are my review comments. Not tested. 1. In osaf_ppoll(), until ppoll() is in real use.. can we keep the logics simple to poll() for now don't use osaf_ppoll() and let the osaf_poll() take care calling poll() etc. 2. In osaf_ppoll(), for result = poll(), need to handle th