Re: [devel] [PATCH 3 of 3] IMMTOOLS: Add support of NO_DANGLING flag to IMM tools [#49]

2013-12-09 Thread Sirisha Alla
Hi Zoran, make rpm fails after applying this patch series. Entry needs to be added for saImmOm_A_2_13.h in opensaf.spec file. Regards, Sirisha On 12/05/2013 08:34 PM, Zoran Milinkovic wrote: > osaf/tools/safimm/immcfg/imm_import.cc | 2 ++ > osaf/tools/safimm/immdump/imm_xmlw_dump.cc |

Re: [devel] [PATCH 0 of 3] Review Request for IMM: Implementation of NO_DANGLING flag [#49]

2013-12-09 Thread Anders Bjornerstedt
Additional comments (third reply mail). 11) In ImmModel::addNoDanglingReferences(ObjectInfo *object) Comment should explain that this function extracts all NO_DANGLING references that exist in "object" and insert them into sReverseRefObjectMap. Thats with 'object' as source and the object matchin

Re: [devel] [PATCH 1 of 1] Additional patch for PLM compilation error, for patch-11 (#537)

2013-12-09 Thread Hans Feldt
If PLM is now the only user of this please change PLM instead. /Hans On 12/09/2013 08:31 AM, ramesh.bet...@oracle.com wrote: > osaf/libs/core/include/ncs_osprm.h | 8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > > diff --git a/osaf/libs/core/include/ncs_osprm.h > b/osaf/lib

Re: [devel] [PATCH 1 of 1] amfd: use saflog for CCB validation errors [#86]

2013-12-09 Thread Hans Feldt
Can I have some feedback? Right now we have no logging for CCB related validation errors. Thanks, Hans On 11/28/2013 10:24 AM, Hans Feldt wrote: > osaf/services/saf/amf/amfd/cluster.cc | 2 +- > osaf/services/saf/amf/amfd/imm.cc | 14 ++ > 2 files changed, 11 insertions(+),

[devel] [PATCH 1 of 1] build: Add extra GCC hardening compilation flags [#650]

2013-12-09 Thread Anders Widell
00-README.conf | 2 +- Makefile.common | 4 ++-- README | 16 configure.ac | 18 ++ tools/cluster_sim_uml/README | 2 +- 5 files changed, 34 insertions(+), 8 deletions(-) By default, build w

[devel] [PATCH 0 of 1] Review Request for build: Add extra GCC hardening compilation flags [#650]

2013-12-09 Thread Anders Widell
Summary: build: Add extra GCC hardening compilation flags [#650] Review request for Trac Ticket(s): 650 Peer Reviewer(s): Mathi Pull request to: Affected branch(es): default(4.4) Development branch: default Impacted area Impact y/n --

Re: [devel] [PATCH 1 of 1] CORE: use _exit instead of exit in daemon_exit #651

2013-12-09 Thread Hans Feldt
Ack but please use ticket 581 instead. And please put in a reason for the change in the commit message body /HansF On 12/09/2013 09:23 AM, Hans Nordeback wrote: > osaf/libs/core/common/daemon.c | 8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > > use _exit instead of exit i

Re: [devel] [PATCH 1 of 1] CORE: use _exit instead of exit in daemon_exit #651

2013-12-09 Thread Anders Widell
Ack with comments. 1) In the commit message: * The component name should be base:, not CORE: * The ticket number should be surrounded with square brackets so that SourceForge recognizes it as a ticket reference. * The commit message should have a longer description explaining why this change

Re: [devel] [PATCH 0 of 3] Review Request for IMM: Implementation of NO_DANGLING flag [#49]

2013-12-09 Thread Anders Bjornerstedt
Additional comments. 9) In checkNoDanglingReferencesModify (to be renamed validateNoDanglingRefsModify): +LOG_NO("ERR_FAILED_OPERATION: NO_DANGLING reference (%s) does not exist", +av->getValueC_str()); Says the reference does not

[devel] [PATCH 0 of 1] Review Request for #651

2013-12-09 Thread Hans Nordeback
Summary: CORE: use _exit instead of exit daemon_exit Review request for Trac Ticket(s): #651 Peer Reviewer(s): hans.fe...@ericsson.com;anders.wid...@ericsson.com;ramesh.bet...@oracle.com Pull request to: Affected branch(es): default Development branch: Impacted

[devel] [PATCH 1 of 1] CORE: use _exit instead of exit in daemon_exit #651

2013-12-09 Thread Hans Nordeback
osaf/libs/core/common/daemon.c | 8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) use _exit instead of exit in daemon_exit diff --git a/osaf/libs/core/common/daemon.c b/osaf/libs/core/common/daemon.c --- a/osaf/libs/core/common/daemon.c +++ b/osaf/libs/core/common/daemon.c @@ -43,6