Mahesh,
I have not done a line by line review of the code but have run some
tests. Below are my comments:
1) If saCkptInitialize_2 is invoked with wrong version, version
parameter is not being filled up according to the standard initialize
API definitions.
2) If TrackCallback is provided as
Sirisha,
Thank you for the review
Comments 1,2 3 are the this enhancement related , so I will address
while pushing the patch, but
comment 4 5 are existing problems , so can you please raise new
ticket for those.
-AVM
On 12/12/2013 2:52 PM, Sirisha Alla wrote:
Mahesh,
I have not done
Need to correct myself in one of my own review comments.
So far I have sent three mails. This is in the first one.'
See below.
Anders Bjornerstedt wrote:
Hi Zoran.
Server side patch looks much better :-)
I still have some detail comments though.
Not all of them in this mail, but just to let
Ack, review comments inline [Ramesh].
Thanks,
Ramesh.
On 12/4/2013 6:30 PM, mathi.naic...@oracle.com wrote:
opensaf.spec.in | 1 +
osaf/services/saf/clmsv/config/Makefile.am | 3 +-
osaf/services/saf/clmsv/config/clmna.conf
Ack.
On 12/4/2013 6:30 PM, mathi.naic...@oracle.com wrote:
osaf/services/saf/clmsv/clms/clms_evt.c | 3 +++
osaf/services/saf/clmsv/clms/clms_evt.h | 1 +
osaf/services/saf/clmsv/clms/clms_mds.c | 18 ++
3 files changed, 14 insertions(+), 8 deletions(-)
diff --git
Ack with the following comments.
+ $(top_builddir)/osaf/libs/saf/libSaAmf/libSaAmf.la \
+ $(top_builddir)/osaf/libs/saf/libSaImm/libSaImmOi.la
[Ramesh]: Not required to add libSaImmOi.la
+ /* Detach from IPC */
+ m_NCS_IPC_DETACH(clmna_cb-mbx, NULL, clmna_cb);
[Ramesh]:
Hi Neelakanta,
1. I will fix this.
2. That is correct behavior. If both objects are deleted in the same CCB, then
it's possible to delete both of them. Number of same no dangling references in
multivalue attribute does not matter on deletion objects. Having one reference
is the same as having
Additional comments (fourth review mail for #49).
18) ImmModel::ccbObjectCreate
Log message:
AttrFlagIncludes(SA_IMM_ATTR_PERSISTENT)) ==
omi-second-mClassInfo-mAttrMap.end()) {
LOG_NO(ERR_INVALID_PARAM:
osaf/libs/core/mds/include/mds_dt.h | 3 -
osaf/libs/core/mds/include/mds_dt2c.h | 9 -
osaf/libs/core/mds/mds_c_sndrcv.c | 9 +++--
osaf/libs/core/mds/mds_dt_tipc.c | 55 --
4 files changed, 51 insertions(+), 25 deletions(-)
MDS has its own
Summary: java: Fix compiler warnings and treat warnings as errors [#649]
Review request for Trac Ticket(s): 649
Peer Reviewer(s): Mathi
Pull request to:
Affected branch(es): opensaf-4.2.x, opensaf-4.3.x, default(4.4)
Development branch: default
Impacted area
Need to correct my own review comments again.
Just goes to show that this code is really hard to review.
See below.
Anders Bjornerstedt wrote:
Additional comments (fourth review mail for #49).
18) ImmModel::ccbObjectCreate
Log message:
Additional comments (fifth review mail for #49).
This is the final mail for this RR, i.e. this set of patches.
21) ImmModel::ccbObjectModify
+s1.clear();
+s2.clear();
+// Exclude objects for adding from the original object
Better:
//Create the set s1 of
Summary: logsv: Remove dependency to shared file system
Review request for Trac Ticket(s): [#152]
Peer Reviewer(s): Mathi N, Hans F, Bertil E
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): 4.4
Development branch: IF ANY GIVE THE REPO URL
13 matches
Mail list logo
