[devel] [PATCH 1 of 1] amfnd: Correct the check for su [#717]

osaf/services/saf/avsv/avnd/avnd_susm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/osaf/services/saf/avsv/avnd/avnd_susm.c b/osaf/services/saf/avsv/avnd/avnd_susm.c --- a/osaf/services/saf/avsv/avnd/avnd_susm.c +++ b/osaf/services/saf/avsv/avnd/avnd_susm.c @@

Re: [devel] [PATCH 1 of 1] imported patch amfd.patch

Ack, (only code review)/BR HansN On 01/13/14 08:30, Gary Lee wrote: osaf/services/saf/amf/amfd/csi.cc | 25 - osaf/services/saf/amf/amfd/include/sg.h | 1 - osaf/services/saf/amf/amfd/sgtype.cc| 3 ++- osaf/services/saf/amf/amfd/si.cc| 27

Re: [devel] [PATCH 1 of 1] imported patch amfd.patch

Please provide a proper commit message /Hans Skickat från min Sony Xperia™-smartphone Gary Lee skrev osaf/services/saf/amf/amfd/csi.cc | 25 - osaf/services/saf/amf/amfd/include/sg.h | 1 - osaf/services/saf/amf/amfd/sgtype.cc| 3 ++-

[devel] [PATCH 0 of 1] Review Request for AMFD: errors reported in valgrind [#715]

Summary: AMFD: errors reported in valgrind [#715] Review request for Trac Ticket(s): 715 Peer Reviewer(s): Hans F, Hans N Pull request to: Affected branch(es): default, opensaf-4.4.x Development branch: Impacted area Impact y/n

[devel] [PATCH 1 of 1] * remove saAmfStgValidSuTypes from 'struct avd_amf_sg_type_tag' as it appears to

osaf/services/saf/amf/amfd/csi.cc | 25 - osaf/services/saf/amf/amfd/include/sg.h | 1 - osaf/services/saf/amf/amfd/sgtype.cc| 3 ++- osaf/services/saf/amf/amfd/si.cc| 27 +-- osaf/services/saf/amf/amfd/svctype.cc | 20

Re: [devel] [PATCH 1 of 1] * remove saAmfStgValidSuTypes from 'struct avd_amf_sg_type_tag' as it appears to

Hmm, something went wrong when the email was done. The commit message should read: * remove saAmfStgValidSuTypes from 'struct avd_amf_sg_type_tag' as it appears to be a typo of saAmfSGtValidSuTypes * ensure saAmfCSIDependencies is deleted in csi.cc * ensure

Re: [devel] [PATCH 1 of 2] amfnd: remove unneeded lock [#713]

But why are not avnd_stop_tmr not updated as avnd_start_tmr?/BR HansN -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 13 januari 2014 13:09 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 2] amfnd: remove

Re: [devel] Possible Time delay between AMFD exit and DTM exit during opensaf stop

One another issue that can occur is that because of a slowed exit of AMFD on the node going down, i.e. During the 'opensafd stop' flow, I think the local AMFD should mark the local node as ABSENT upon receiving down event of local AMFND as below: diff --git a/osaf/services/saf/amf/amfd/ndfsm.cc

Re: [devel] [PATCH 1 of 2] amfnd: remove unneeded lock [#713]

-Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 13 januari 2014 13:33 To: Hans Nordebäck; Hans Feldt Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 2] amfnd: remove unneeded lock [#713] But why are not avnd_stop_tmr

[devel] [PATCH 0 of 1] Review Request for AMFND: errors reported by valgrind [#716]

Summary: AMFND: errors reported by valgrind [#716] Review request for Trac Ticket(s): 716 Peer Reviewer(s): Hans N, Hans F, Nagendra Pull request to: Affected branch(es): default, opensaf-4.4.x Development branch: Impacted area Impact y/n

[devel] [PATCH 1 of 1] AMFND: errors reported by valgrind [#716]

osaf/services/saf/amf/amfnd/amfnd.cc|4 +- osaf/services/saf/amf/amfnd/cbq.cc |4 +- osaf/services/saf/amf/amfnd/ckpt_updt.cc|4 +- osaf/services/saf/amf/amfnd/comp.cc | 14 +- osaf/services/saf/amf/amfnd/compdb.cc |6 +-

Re: [devel] [PATCH 3 of 4] amfd: use std::vector to replace realloc [#713]

Ack with minor comment: su_iter and sg_iter are not great names, perhaps su_node_name sg_node_name is better? Any plans for the TODOs? Thanks, HansF On 10 January 2014 16:49, Hans Nordeback hans.nordeb...@ericsson.com wrote: osaf/services/saf/amf/amfd/include/node.h | 5 ++-