osaf/services/saf/amf/amfd/app.cc| 95 ++-
osaf/services/saf/amf/amfd/ckpt_enc.cc | 11 +--
osaf/services/saf/amf/amfd/ckpt_updt.cc | 7 +-
osaf/services/saf/amf/amfd/include/app.h | 21 +--
osaf/services/saf/amf/amfd/sg.cc | 2 +-
osaf/ser
Summary: amf refactor app v2
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Hans N, Praveen
Pull request to: <>
Affected branch(es): default
Development branch: <>
Impacted area Impact y/n
Docsn
Well,
That should be the way to go then! AMFD cannot(should not!) do anything after
the local AMFND down!
- Mathi.
> -Original Message-
> From: Hans Feldt [mailto:hans.fe...@ericsson.com]
> Sent: Tuesday, January 14, 2014 2:04 PM
> To: Mathivanan Naickan Palanivelu; Venkata Mahesh Alla;
ack with one comment, why use a pointer ,static AmfAppMap *db instead of
static AmfAppMap db, then new (delete) is not needed?/BR HansN
On 01/15/14 09:11, Hans Feldt wrote:
> osaf/services/saf/amf/amfd/app.cc| 95
> ++-
> osaf/services/saf/amf/amfd/ckpt_enc
Summary: amfd: Add switch case 0 to support older releases [#628]
Review request for Trac Ticket(s): #628
Peer Reviewer(s): Hans N, Hans F, Praveen
Pull request to: <>
Affected branch(es): Default
Development branch: Default
Impacted area Impact y/n
---
osaf/services/saf/amf/amfd/sgproc.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/sgproc.cc
b/osaf/services/saf/amf/amfd/sgproc.cc
--- a/osaf/services/saf/amf/amfd/sgproc.cc
+++ b/osaf/services/saf/amf/amfd/sgproc.cc
@@ -564,6 +564,7 @@ void a
> -Original Message-
> From: Hans Nordebäck
> Sent: den 15 januari 2014 12:27
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1 of 1] amfd: use stl::map in app [#713]
>
> ack with one comment, why use a pointer ,static AmfAppMap *db instead of
> static Amf
But isn't it better to implement the db class as a singleton then?
class AmfAppDb {
public:
static AmfAppDb* get_instance();
or
static AmfAppDb& get_instance();
void insert(AVD_APP *app);
void erase(AVD_APP *app);
AVD_APP *find(const SaNameT *name);
private:
A
Yes we could use that design pattern if you prefer
If you have time you could send an updated patch :-)
/HansF
> -Original Message-
> From: Hans Nordebäck
> Sent: den 15 januari 2014 16:19
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1 of 1] amfd: use st
Summary: amf refactor app v3
Review request for Trac Ticket(s): #713
Peer Reviewer(s): hansF, nagu, praveen
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Docs
osaf/services/saf/amf/amfd/app.cc| 40 +++
osaf/services/saf/amf/amfd/ckpt_enc.cc | 2 +-
osaf/services/saf/amf/amfd/ckpt_updt.cc | 2 +-
osaf/services/saf/amf/amfd/include/app.h | 23 +++---
osaf/services/saf/amf/amfd/sg.cc | 2 +-
Hi Nagu, this patch is the same change I provided temporarily internally
a couple of weeks ago. It was verified to work. Do you think we need
additional testing? /BR HansN
On 01/15/14 13:02, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfd/sgproc.cc | 1 +
> 1 files changed, 1 insert
Hi Hans N,
Then I will push this change into staging.
Thanks
-Nagu
> -Original Message-
> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
> Sent: 15 January 2014 22:31
> To: Nagendra Kumar
> Cc: hans.fe...@ericsson.com; Praveen Malviya; opensaf-
> de...@lists.sou
Summary: amfd: Invalid read when deleting a node from a node group [#719]
Review request for Trac Ticket(s): 719
Peer Reviewer(s): Hans F, Hans N
Pull request to:
Affected branch(es): default, opensaf-4.4.x
Development branch:
Impacted area Impact y/n
---
osaf/services/saf/amf/amfd/nodegroup.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
don't read beyond the end of saAmfNGNodeList, if the node to be removed from
node group
is at the end of the array.
diff --git a/osaf/services/saf/amf/amfd/nodegroup.cc
b/osaf/services/saf/amf/am
Summary: amfd: Invalid read when deleting a node from a node group [#719]
Review request for Trac Ticket(s): 719
Peer Reviewer(s): Hans F, Hans N
Pull request to:
Affected branch(es): opensaf-4.2.x, opensaf-4.3.x
Development branch:
Impacted area Impact y/
osaf/services/saf/avsv/avd/avd_nodegroup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
don't read beyond the end of saAmfNGNodeList, if the node to be removed from
node group
is at the end of the array.
diff --git a/osaf/services/saf/avsv/avd/avd_nodegroup.c
b/osaf/services/saf/
Hi,
Although the change is trivial I have some comments:
- the commit message, it should start off with a verb and describe what the
patch is doing e.g. in this case:
"amfd: fix out-of-bounds read from nodelist array [#719]"
- It seems like the logic in ng_ccb_apply_modify_hdlr can only handle
18 matches
Mail list logo
