See comments inline
Can you please send a new patch?
Thanks,
Hans
On 17 January 2014 09:00, Gary Lee wrote:
> osaf/services/saf/amf/amfd/nodegroup.cc | 35
> -
> 1 files changed, 34 insertions(+), 1 deletions(-)
>
>
> * fix out-of-bounds read in ng_ccb_apply_mod
* The short commit message should describe what the patch is doing
* Wherever free is used instead of delete a comment should added explaining why
* Do not add error handling for out of memory errors, in case of
malloc just do osafassert(p != NULL);
Hans N: any comments?
Thanks,
HansF
On 13 Janu
Looks OK but move the allocation of the event in mds_quiesced_ack to the branch
where it's needed
and remove the else branch where the event is destroyed.
/Bertil
-Original Message-
From: Ingvar Bergström
Sent: den 21 januari 2014 13:10
To: Bertil Engelholm
Cc: opensaf-devel@lists.sourc
With this approach we will miss the gcov flush added in the
daemon_exit function. Please revise the patch.
Thanks,
Hans
On 17 January 2014 09:54, wrote:
> osaf/services/saf/amf/amfd/ndfsm.cc | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>
> Today amfd exits when the /etc/init.
I shall change the log message in daemon_exit().
How about "exiting for opensaf stop"
Thanks,
Mathi.
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: Wednesday, January 22, 2014 5:14 PM
To: Mathivanan Naickan Palanivelu
Cc: Nagendra Kumar; Hans Feldt; opensaf-dev
Hi,
My fix is generic in the sense all the conditions whether pres state is
instantiated or restarting. I would pick the comments on commit message and
push it.
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:osafde...@gmail.com]
> Sent: 22 January 2014 12:39
> To:
Ack with comment: user visible symptom is not in commit message.
Please a paragraph describing the actual user discovered problem.
Thanks,
Hans
On 6 January 2014 10:47, wrote:
> osaf/services/saf/amf/amfd/sgproc.cc | 8
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
>
> AMF incr
Ok let's go for the proposed approach. Ack.
Thanks,
Hans
On 19 December 2013 09:49, Nagendra Kumar wrote:
> But, Keeping old is not through these logs as they are just printing UNKNOW
> instead of old state.
> Can you please change the description in that case.
>
> Thanks
> -Nagu
>
> -Origin
Fine
/Hans
> -Original Message-
> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 22 januari 2014 12:53
> To: Hans Feldt
> Cc: Hans Feldt; Hans Nordebäck; Praveen Malviya;
> opensaf-devel@lists.sourceforge.net
> Subject: RE: [devel] [PATCH 1 of 1] amfnd: ignore health chec
ack, I have only done code review and I think it looks ok, the comment
"malloc'ed in avsv_edp_susi_asgn() " in sidb.cc is correct I guess but I
couldn't directly find the related malloc.
/BR HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 13 januari 2
>>> Why not instead check the node's operational state for ENABLED?
I guess your comment is about the below lines:
> > + if ((comp->su->su_on_node->node_state ==> AVD_AVND_STATE_PRESENT) ||
> > + (comp->su->su_on_node->node_state ==>
> > AVD_AVND_STATE_NO_CONFIG) ||
> > +
osaf/services/saf/amf/amfd/comp.cc | 37 ---
osaf/services/saf/amf/amfd/ndproc.cc| 10 +++-
osaf/services/saf/amf/amfnd/clc.cc | 10 +
osaf/services/saf/amf/amfnd/compdb.cc | 47 +---
osaf/services/saf/amf/
Summary: amf: support for automatic comp instantiation and deletion [#597]
Review request for Trac Ticket(s): #597
Peer Reviewer(s): Hans F, Hans N, Praveen, Hrishikesh Chenna, Mathi
Pull request to: <>
Affected branch(es): Default
Development branch: Default
Im
Attached is the corresponding 4.2/4.3 patch.
This patch lack the log change that was part of the 4.4 patch. That problem do exist in older branches as well but not
for this use case. I think I should raise a minor defect for that one and handle it separately. Meaning you should
disregard that p
14 matches
Mail list logo
