In the floated patch for #601 below mentioned log message is removed.
After this patch do we require the removal of log message in #601 patch.
Thanks,
Praveen
On 24-Jan-14 12:23 PM, Hans Feldt wrote:
> osaf/services/saf/amf/amfnd/su.cc | 6 --
> 1 files changed, 4 insertions(+), 2 deletion
On 01/24/2014 05:06 AM, Nagendra Kumar wrote:
>>> + (su_ptr->saAmfSUPresenceState ==
>>> +SA_AMF_PRESENCE_INSTANTIATED) &&
>>
>> keep above expression on same line
>
> But the line is exceeding 80 lines when the line break is kept in the same
> line.
That s
On 01/24/2014 09:56 AM, praveen malviya wrote:
> In the floated patch for #601 below mentioned log message is removed.
> After this patch do we require the removal of log message in #601 patch.
Yes that part of 601 will be removed and replaced with this one.
/Hans
>
> Thanks,
> Praveen
> On 24-J
Ack.
Thanks,
Praveen
On 24-Jan-14 2:27 PM, Hans Feldt wrote:
>
> On 01/24/2014 09:56 AM, praveen malviya wrote:
>> In the floated patch for #601 below mentioned log message is removed.
>> After this patch do we require the removal of log message in #601 patch.
>
> Yes that part of 601 will be remo
Ack.
I think this change needs documentation.
Reported #739 while testing this.
Thanks
Praveen
On 10-Jan-14 2:44 PM, Hans Feldt wrote:
> osaf/services/saf/amf/amfnd/comp.cc | 23
> +--
> osaf/services/saf/amf/amfnd/err.cc | 15 +++
>
So, you want to do revert this change and this knid of change from other places
except the comments ?
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:hans.fe...@ericsson.com]
> Sent: 24 January 2014 14:27
> To: Nagendra Kumar; hans.nordeb...@ericsson.com; Praveen Malviya;
> Mathiva
Do what you think is best. This was minor comment on white space.
But personally I don't think that we should break lines like in:
> +(su_ptr->saAmfSUPresenceState ==
> + SA_AMF_PRESENCE_INSTANTIATED) &&
that makes the logic less understa
Hi Zoran,
Reviewed and tested the patch.
Ack.
/Neel.
On Tuesday 21 January 2014 05:43 PM, Zoran Milinkovic wrote:
> Summary: IMMTEST: fix IMM tests if 2PBE is enabled [#624]
> Review request for Trac Ticket(s): 624
> Peer Reviewer(s): Neelakanta
> Pull request to: Zoran
> Affected branch(es): ope
osaf/services/saf/amf/amfd/si.cc | 8
1 files changed, 8 insertions(+), 0 deletions(-)
When an Application/SI is removed from the AMF model SI unassigned alarms will
be generated. This patch clears those alarms since the SI is anyway being
removed by an administrator.
diff --git a/osa
Summary: Clear alarms when SI is removed
Review request for Trac Ticket(s): 601
Peer Reviewer(s): Praveen
Pull request to: <>
Affected branch(es): <>
Development branch: <>
Impacted area Impact y/n
Docsn
osaf/libs/saf/include/saImmOm_A_2_12.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/libs/saf/include/saImmOm_A_2_12.h
b/osaf/libs/saf/include/saImmOm_A_2_12.h
--- a/osaf/libs/saf/include/saImmOm_A_2_12.h
+++ b/osaf/libs/saf/include/saImmOm_A_2_12.h
@@ -54,9 +54,
Summary: Correct misleading comments in saImmOm_A_2_12.h and saImmOm_A_2_13.h
(#747)
Review request for Trac Ticket(s): 747
Peer Reviewer(s): Neel
Pull request to:
Affected branch(es): 4.3, 4.4, default(4.5)
Development branch:
Impacted area Impact y/n
---
osaf/libs/saf/include/saImmOm_A_2_13.h | 7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/osaf/libs/saf/include/saImmOm_A_2_13.h
b/osaf/libs/saf/include/saImmOm_A_2_13.h
--- a/osaf/libs/saf/include/saImmOm_A_2_13.h
+++ b/osaf/libs/saf/include/saImmOm_A_2_13.h
@@ -46,11
Summary: IMM: Clarify that completed-callback isa meaningsless for appliers
(#748)
Review request for Trac Ticket(s): 748
Peer Reviewer(s): Neel
Pull request to:
Affected branch(es): 4.2;4.3;4.4;default(4.5)
Development branch:
Impacted area Impact y/n
---
osaf/services/saf/immsv/README | 27 +++
1 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++ b/osaf/services/saf/immsv/README
@@ -318,7 +318,7 @@ is genera
15 matches
Mail list logo
