Ack for the change in clc.cc
The other change is unrelated to the problem described in the ticket and needs
to be handled separately.
Thanks,
Hans
On 02/05/2014 03:23 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/clc.cc | 3 ++-
> osaf/services/saf/amf/amfnd/susm.cc | 21
I found yet another problem, if a component just crash/exit during shutdown
when another component is in the CSI remove
phase, the shut down will hang. Removing the "ignore" code in
avnd_evt_mds_ava_dn_evh() fixes the problem.
I will write a new defect.
/Hans
On 02/06/2014 01:37 PM, Nagendra
osaf/services/saf/amf/amfd/apptype.cc| 6 +-
osaf/services/saf/amf/amfd/clm.cc| 8 ++--
osaf/services/saf/amf/amfd/cluster.cc| 2 +-
osaf/services/saf/amf/amfd/comp.cc | 6 +-
osaf/services/saf/amf/amfd/comptype.cc | 6 +-
osaf/services/saf/amf
Summary: Refactoring AMF
Review request for Trac Ticket(s): #713
Peer Reviewer(s): HansF, Nagu, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Docs
> If there is another problem behind that find let's take it later. If you
> bring in
> TERM-FAILED we are close to #538 which should not be mixed with this one.
I found during testing and I fixed it. So, I will raise a separate ticket for
this.
> I will test if the change in clc.cc alone fixes
Considering that the check for reboot should look like:
saAmfSGAutoRepair==True AND saAmfNodeAutoRepair==True AND
saAmfNodeFailfastOnTerminationFailure==True
so yes maybe this check and reboot order belongs in AMFD. Since currently AMFND
has no clue of saAmfSGAutoRepair and I
guess introducing
Nothing of this is stated in the commit message so it was not understood. We
are in a tough situation right now with
many AMF defects in the same area (opensaf shutdown). So let's do many small
logical changes where each change can be
tested with its own test case and described by its own ticke
Tested.
Ack,
Mathi.
- lennart.l...@ericsson.com wrote:
> osaf/services/saf/logsv/lgs/lgs_evt.c| 5 +-
> osaf/services/saf/logsv/lgs/lgs_mbcsv.c | 5 +-
> osaf/services/saf/logsv/lgs/lgs_stream.c | 66
> ++-
> osaf/services/saf/logsv/lgs/lgs_stream.h |
Ack
Thanks
-Nagu
> -Original Message-
> From: Praveen Malviya
> Sent: 04 February 2014 15:14
> To: hans.fe...@ericsson.com; Nagendra Kumar; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] amfnd : handle successful cleanup of assigned comp
>
Any comments ??
> -Original Message-
> From: Nagendra Kumar
> Sent: 04 February 2014 14:02
> To: Hans Feldt; Hans Nordebäck; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during
> decoding [#761]
>
> Hum, wo
The changes in clc.cc works fine when term fails and cleanup succeeds, but
opensafd doesn't exits and it hangs when cleanup also fails, this is addressed
by changes in susm.cc.
Thanks
-Nagu
> -Original Message-
> From: praveen malviya
> Sent: 06 February 2014 16:33
> To: Hans Feldt
> Cc
- Some changes related to cb->swap_switch are not present in this patch.
They were present in first version.
Since cb->swap_switch is changed to bool in cb.h related changes are not
modified in following files:
osaf/services/saf/amf/amfd/dmsg.cc
osaf/services/saf/amf/amfd/main.cc
osaf/services/s
I think in avnd_su_pres_terming_comptermfail_hdler() SU transitions to
TERMINATING to TERM_FAILED state.
This state change leads SU FSM there.
Thanks
Praveen
On 06-Feb-14 4:20 PM, Hans Feldt wrote:
> test case: NPI SU, term command fails but cleanup succeeds.
>
> So why do we end up in susm.cc l
test case: NPI SU, term command fails but cleanup succeeds.
So why do we end up in susm.cc line 1668 where SU is in TERMINATION-FAILED?
/Hans
On 02/05/2014 03:23 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/clc.cc | 3 ++-
> osaf/services/saf/amf/amfnd/susm.cc | 21 +
Sorry I answered the wrong email...
Need to check this patch a bit more. Will get back.
/Hans
On 02/06/2014 11:41 AM, Nagendra Kumar wrote:
> Hi Hans,
>
> What is the comment ? I can't see in this email.
>
> Thanks
> -Nagu
>
>> -Original Message-
>> From: Hans Feldt [mailto:hans.fe.
Hi Hans,
What is the comment ? I can't see in this email.
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:hans.fe...@ericsson.com]
> Sent: 06 February 2014 15:56
> To: praveen malviya; Nagendra Kumar
> Cc: hans.nordeb...@ericsson.com; opensaf-devel@lists.sourceforge.
osaf/services/saf/amf/amfd/comptype.cc | 100 -
1 files changed, 99 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/comptype.cc
b/osaf/services/saf/amf/amfd/comptype.cc
--- a/osaf/services/saf/amf/amfd/comptype.cc
+++ b/osaf/services/saf/am
Summary: comptype and hctype change support
Review request for Trac Ticket(s): 539
Peer Reviewer(s): Nags
Pull request to: <>
Affected branch(es): 4.4
Development branch: 4.4
Impacted area Impact y/n
Docsn
osaf/services/saf/amf/amfd/hlttype.cc | 51 --
1 files changed, 48 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/hlttype.cc
b/osaf/services/saf/amf/amfd/hlttype.cc
--- a/osaf/services/saf/amf/amfd/hlttype.cc
+++ b/osaf/services/saf/amf/am
Ack with minor comments on commit message
/Hans
On 02/06/2014 11:16 AM, praveen malviya wrote:
> Ack.
>
> Thanks,
> Praveen
> On 05-Feb-14 7:53 PM, nagendr...@oracle.com wrote:
>> osaf/services/saf/amf/amfnd/clc.cc | 3 ++-
>> osaf/services/saf/amf/amfnd/susm.cc | 21 +
>
Ack.
Thanks,
Praveen
On 05-Feb-14 7:53 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/clc.cc | 3 ++-
> osaf/services/saf/amf/amfnd/susm.cc | 21 +
> 2 files changed, 23 insertions(+), 1 deletions(-)
>
>
> amfnd asserts in avnd_comp_csi_remove_done if su
Ack.
Thanks,
Praveen
On 03-Feb-14 3:44 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfd/ckpt_dec.cc| 5 +
> osaf/services/saf/amf/amfd/comp.cc| 21 +
> osaf/services/saf/amf/amfd/include/comp.h | 1 +
> 3 files changed, 23 insertions(+), 4
osaf/services/saf/logsv/lgs/lgs_evt.c| 5 +-
osaf/services/saf/logsv/lgs/lgs_mbcsv.c | 5 +-
osaf/services/saf/logsv/lgs/lgs_stream.c | 66 ++-
osaf/services/saf/logsv/lgs/lgs_stream.h | 2 +-
4 files changed, 50 insertions(+), 28 deletions(-)
Note: Fix on
Summary: logsv: Fix assert when switch over after last close of app stream
Review request for Trac Ticket(s): [#714]
Peer Reviewer(s): mathi.naic...@oracle.com
Pull request to:
Affected branch(es): 4.2.x, 4.3.x, 4.4.x, default
Development branch:
Impacted area
24 matches
Mail list logo
