Re: [devel] [PATCH 2 of 2] amfd: allow changes to hctype [#539]

2014-02-07 Thread Nagendra Kumar
Ack(not tested) with below comments: There are no other attribute to modify so the below check is not required, + } else { + // catch all for non supported changes + report_ccb_validation_error(opdata, +

Re: [devel] [PATCH 1 of 2] amfd: allow changes to comptype [#539]

2014-02-07 Thread Hans Feldt
-Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 7 februari 2014 12:05 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1 of 2] amfd: allow changes to comptype [#539] Ack with following comment, but not tested: 1.

Re: [devel] [PATCH 1 of 2] amfd: allow changes to comptype [#539]

2014-02-07 Thread Nagendra Kumar
[Hans] Because it is so easy to miss out on the nanosecond resolution, have seen that many times. I don't think anyone wants to go below one second. We need a value here. Do you have a better suggestion? I checked the code, may places I found : 100 * SA_TIME_ONE_MILLISECOND. This would be

Re: [devel] [PATCH 1 of 2] amfd: allow changes to comptype [#539]

2014-02-07 Thread Hans Feldt
-Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 7 februari 2014 12:19 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1 of 2] amfd: allow changes to comptype [#539] [Hans] Because it is so easy to miss out on the

Re: [devel] [PATCH 1 of 1] amfnd: prepend prefix to clc-cli cmd if exist [#773]

2014-02-07 Thread Mathivanan Naickan Palanivelu
Ack, Mathi. - osafde...@gmail.com wrote: osaf/services/saf/amf/amfnd/compdb.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Component fails to instantiate, typical syslog: Feb 7 16:31:25 Vostro osafamfnd[19923]: ncs_os_process_execute_timed: execvp

[devel] [PATCH 1 of 1] amfnd: prepend prefix to clc-cli cmd if exist [#773]

2014-02-07 Thread Hans Feldt
osaf/services/saf/amf/amfnd/compdb.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Component fails to instantiate, typical syslog: Feb 7 16:31:25 Vostro osafamfnd[19923]: ncs_os_process_execute_timed: execvp '/amf_demo_script' failed - No such file or directory If the

[devel] [PATCH 0 of 1] Review Request for amf #773

2014-02-07 Thread Hans Feldt
Summary: amf 773 Review request for Trac Ticket(s): 773 Peer Reviewer(s): Nags or Mathi Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): 4.4 Development branch: 4.4 Impacted area Impact y/n Docs

[devel] 4.4.x branch is under change control (was 4.4.RC1 Enhancements Release Candidate available)

2014-02-07 Thread Mathivanan Naickan Palanivelu
Hi, Since the RC1 tag has been applied on 4.4.x branch, this branch is under change control during this testing period. The current sets of tickets targeted are in this report https://sourceforge.net/p/opensaf/tickets/milestone/4.4.RC2/, Apart from these, please consider pushing only critical

Re: [devel] [PATCH 1 of 1] osaf: fix compiling problem for 32-bit environment [#758]

2014-02-07 Thread Mathivanan Naickan Palanivelu
Ack, Mathi. -Original Message- From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] Sent: Monday, February 03, 2014 5:46 PM To: Sirisha Alla Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1 of 1] osaf: fix compiling problem for 32-bit environment [#758]

[devel] 4.4.RC1 Enhancements Release Candidate available

2014-02-07 Thread Mathivanan Naickan Palanivelu
Hello, The 4.4.RC1 tag has been applied to the 4.4 enhancements branch. We encourage you to download and test the archive from http://sourceforge.net/projects/opensaf/files/releases/opensaf-4.4.RC1.tar.gz/download . This pre-release shall be under testing till February 21st 2014. Please