Re: [devel] [PATCH 1 of 1] amfd: return AIS_OK instead of BAD_OP for si-swap admin op [#823]

2014-04-01 Thread Nagendra Kumar
If the recovery of failed Su doesn't happen i.e. goes into instantiatin failed state/termination failed state, then are you going to rerun failed operation ? Thanks -Nagu > -Original Message- > From: Hans Feldt [mailto:hans.fe...@ericsson.com] > Sent: 02 April 2014 12:14 > To: praveen mal

Re: [devel] [PATCH 1 of 1] amfd: return AIS_OK instead of BAD_OP for si-swap admin op [#823]

2014-04-01 Thread Hans Feldt
Well my view point still stands. By separating the su_switch from invocation_id we introduce even more sub-states and we already have enough of those! Basically the same patch as you have with a small addition causes the admin response to be sent after recovery of the failed SU. Will send a pat

Re: [devel] [PATCH 1 of 1] amfd: return AIS_OK instead of BAD_OP for si-swap admin op [#823]

2014-04-01 Thread praveen malviya
Any update/comment on this. Thanks, Praveen On 01-Apr-14 2:27 PM, praveen malviya wrote: > On 01-Apr-14 1:27 PM, Hans Feldt wrote: >> >> On 03/28/2014 02:14 PM, praveen.malv...@oracle.com wrote: >>>osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 23 +-- >>>1 files changed, 13

[devel] [PATCH 0 of 3] Review Request for AMF remove cast #713

2014-04-01 Thread Hans Feldt
Summary: remove casts Review request for Trac Ticket(s): 713 Peer Reviewer(s): Hans Pull request to: <> Affected branch(es): <> Development branch: <> Impacted area Impact y/n Docsn Build system

[devel] [PATCH 1 of 3] amfd: remove cast from avd_class_impl_set [#713]

2014-04-01 Thread Hans Feldt
osaf/services/saf/amf/amfd/app.cc| 2 +- osaf/services/saf/amf/amfd/apptype.cc| 6 +- osaf/services/saf/amf/amfd/cluster.cc| 2 +- osaf/services/saf/amf/amfd/comp.cc | 2 +- osaf/services/saf/amf/amfd/compcstype.cc | 2 +- osaf/services/saf/amf/a

[devel] [PATCH 3 of 3] amfd: remove cast from avd_saImmOiRtObjectCreate [#713]

2014-04-01 Thread Hans Feldt
osaf/services/saf/amf/amfd/csi.cc| 3 +-- osaf/services/saf/amf/amfd/imm.cc| 2 +- osaf/services/saf/amf/amfd/include/imm.h | 2 +- osaf/services/saf/amf/amfd/siass.cc | 3 +-- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/osaf/services/saf/amf/amfd/csi.c

[devel] [PATCH 2 of 3] amfd: remove cast from avd_saImmOiRtObjectUpdate [#713]

2014-04-01 Thread Hans Feldt
osaf/services/saf/amf/amfd/comp.cc | 23 osaf/services/saf/amf/amfd/imm.cc| 44 +++ osaf/services/saf/amf/amfd/include/imm.h | 2 +- osaf/services/saf/amf/amfd/node.cc | 12 osaf/services/saf/amf/amfd/si.cc |

[devel] [PATCH 0 of 1] Review Request for IMM: 2PBE - PBE-A tolerates BAD_OPERATION reply on ccb-prepare from PBE-B [#830]

2014-04-01 Thread Anders Bjornerstedt
Summary: IMM: 2PBE - PBE-A tolerates BAD_OPERATION reply on ccb-prepare from PBE-B [#830] Review request for Trac Ticket(s): 830 Peer Reviewer(s): Neel Pull request to: Affected branch(es): 4.4; default(4.5) Development branch: Impacted area Impact y/n

[devel] [PATCH 1 of 1] IMM: 2PBE - PBE-A tolerates BAD_OPERATION reply on ccb-prepare from PBE-B [#830]

2014-04-01 Thread Anders Bjornerstedt
osaf/libs/common/immsv/immpbe_dump.cc| 9 + osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 12 2 files changed, 13 insertions(+), 8 deletions(-) An SMF campaign enables the PBE (with 2PBE) and immediately attempts to update a PRTA. This fails because the s

Re: [devel] [PATCH 1 of 1] osaf: Add definition of the new type SaConstStringT [#625]

2014-04-01 Thread Anders Björnerstedt
Hey I just also discovered saCkpt_B_02_03.h also! /AndersBj -Original Message- From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com] Sent: den 1 april 2014 16:08 To: Anders Widell Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 1] osaf: Add defin

Re: [devel] [PATCH 1 of 1] osaf: Add definition of the new type SaConstStringT [#625]

2014-04-01 Thread Anders Bjornerstedt
It would be possible but I am not sure it is desirable. I dont see any problem with the current names and I do see the current labeling as clear, related 1:1 to the SaVersionT setting you need to set to get access to that API version. For SaAis.h the difference is that it is not in itself any se

Re: [devel] [PATCH 1 of 1] osaf: Add definition of the new type SaConstStringT [#625]

2014-04-01 Thread Anders Widell
I think it would be possible to rename (and consolidate) the header files for the IMM extensions, since the file names are not exposed to the end users. The names are thus not so important - it is more of an implementation detail. In a way, it could actually be good if the names are a bit ugly

Re: [devel] [PATCH 1 of 1] osaf: Add definition of the new type SaConstStringT [#625]

2014-04-01 Thread Anders Björnerstedt
Ok. The num2 corresponds to the number actually used when initializing a corresponding service handle. For IMM, the first OpenSAF extension to IMM A.2.1 was labeled IMM A.2.11, this to give some space to SAF in case that organisation should decide to release their own update to IMM A.2 at some

Re: [devel] [PATCH 1 of 1] osaf: Add definition of the new type SaConstStringT [#625]

2014-04-01 Thread Mathivanan Naickan Palanivelu
One could say the header file convention for the IMM extensions is already existential. The handle to the saAisExt.h or saAisOsafExt.h is saAis.h(when included), so it is not truly anonymous. At the same time, a convention like B_5_11 does needs some documentation of the convention, because i

Re: [devel] [PATCH 1 of 1] osaf: Add definition of the new type SaConstStringT [#625]

2014-04-01 Thread Anders Björnerstedt
One more point is that saAisExt.h (or whatever we end up calling it) should be included from saAis.h (in OpensaF 4.5). We dont want all users having to figure out which new include files to explicitly include to get access to extensions. It just becomes too confusing and/or requires too much do

Re: [devel] [PATCH 1 of 1] osaf: Add definition of the new type SaConstStringT [#625]

2014-04-01 Thread Anders Björnerstedt
Well the only issue here is the already existing pattern used for the imm API extensions. The significance of the B_5 suffix would be to point at the exact version of that part of the SAF standard that is being extended. Compare for example with saImmOm_A_2_11.h, saImmOm_A_2_12.h, saImmOm_A_2_13.

Re: [devel] [PATCH 1 of 1] osaf: Add definition of the new type SaConstStringT [#625]

2014-04-01 Thread Mathivanan Naickan Palanivelu
Ack with the following comments: 1) we could name this file as saAisExt.h. Please note, there is no significance for the suffix "B_5***" nor is it a standard SAF convention. 2) The description for this file >+ * This file provides the suggested additions to the C language binding for >+ * th

Re: [devel] [PATCH 1 of 1] amfd: return AIS_OK instead of BAD_OP for si-swap admin op [#823]

2014-04-01 Thread praveen malviya
On 01-Apr-14 1:27 PM, Hans Feldt wrote: > > > On 03/28/2014 02:14 PM, praveen.malv...@oracle.com wrote: >> osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 23 +-- >> 1 files changed, 13 insertions(+), 10 deletions(-) >> >> >> Problem: During si-swap if quiesced assignment faults,

[devel] [PATCH 0 of 1] Review Request for IMM: release inactive search handles [#47]

2014-04-01 Thread Zoran Milinkovic
Summary: IMM: release inactive search handles [#47] Review request for Trac Ticket(s): 47 Peer Reviewer(s): Anders, Neelakanta Pull request to: Zoran Affected branch(es): default(4.5) Development branch: default(4.5) Impacted area Impact y/n -

[devel] [PATCH 1 of 1] IMM: release inactive search handles [#47]

2014-04-01 Thread Zoran Milinkovic
osaf/services/saf/immsv/immnd/ImmModel.cc| 59 +++- osaf/services/saf/immsv/immnd/ImmSearchOp.cc | 1 + osaf/services/saf/immsv/immnd/ImmSearchOp.hh | 4 + osaf/services/saf/immsv/immnd/immnd_cb.h | 4 + 4 files changed, 67 insertions(+), 1 deletions(-) dif

Re: [devel] [PATCH 1 of 1] amfd: return AIS_OK instead of BAD_OP for si-swap admin op [#823]

2014-04-01 Thread Hans Feldt
On 03/28/2014 02:14 PM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 23 +-- > 1 files changed, 13 insertions(+), 10 deletions(-) > > > Problem: During si-swap if quiesced assignment faults, AMF returns > BAD_OPERATION even though si-swap c

Re: [devel] [PATCH 1 of 1] amfd: use db_template for the app db V2 [#713]

2014-04-01 Thread Hans Feldt
Ack /Hans On 03/27/2014 12:50 PM, Hans Nordeback wrote: > osaf/services/saf/amf/amfd/app.cc| 77 > +-- > osaf/services/saf/amf/amfd/ckpt_enc.cc | 13 ++--- > osaf/services/saf/amf/amfd/ckpt_updt.cc | 7 +- > osaf/services/saf/amf/amfd/include/app.h

Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace patricia tree db V2 [#713]

2014-04-01 Thread Hans Feldt
Ack I guess later we need to make this file common between director and node director. Thanks, Hans On 03/26/2014 12:27 PM, Hans Nordeback wrote: > osaf/services/saf/amf/amfd/include/db_template.h | 63 > > 1 files changed, 63 insertions(+), 0 deletions(-) > > > di