Ack, reviewed only
Thanks,
Hans
On 04/04/2014 10:45 AM, nagendr...@oracle.com wrote:
> osaf/services/saf/avsv/avd/avd_node.c | 9 +
> osaf/services/saf/avsv/avd/avd_su.c | 8
> osaf/services/saf/avsv/avnd/avnd_comp.c | 2 +-
> 3 files changed, 18 insertions(+), 1 del
Ack, reviewed only
Thanks,
Hans
On 04/03/2014 08:25 AM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>
> Problem: Due to fault in stable state in NoRed model, if sponsor goes
> unassigned then AMF i
Summary: OSAF: fix errors compiled with 32-bit compiler [#838]
Review request for Trac Ticket(s): 838
Peer Reviewer(s): Lennart
Pull request to: Zoran
Affected branch(es): opensaf-4.3.x
Development branch: opensaf-4.3.x
Impacted area Impact y/n
--
osaf/libs/saf/include/saNtf.h| 2 +-
osaf/services/saf/logsv/lgs/lgs_stream.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/libs/saf/include/saNtf.h b/osaf/libs/saf/include/saNtf.h
--- a/osaf/libs/saf/include/saNtf.h
+++ b/osaf/libs/saf/include/saNtf.h
Summary: IMMTOOLS: fix errors compiled with 32-bit compiler [#838]
Review request for Trac Ticket(s): 838
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.4.x, default(4.5)
Development branch: default(4.5)
Impacted area Impac
osaf/tools/safimm/immcfg/imm_import.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/tools/safimm/immcfg/imm_import.cc
b/osaf/tools/safimm/immcfg/imm_import.cc
--- a/osaf/tools/safimm/immcfg/imm_import.cc
+++ b/osaf/tools/safimm/immcfg/imm_import.cc
@@ -1930,7 +1
Hi, use ULL, e.g 0x123ULL for the constant. Or use UINT64_C(0x123) from
stdint.h/BR HansN
-Original Message-
From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
Sent: den 8 april 2014 10:46
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel]
I'll change to ULL when I push the code.
Thanks,
Zoran
-Original Message-
From: Hans Nordebäck
Sent: den 8 april 2014 11:00
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] IMMTOOLS: fix errors compiled with 32-
Hi AndersBj,
Reviewed and tested the patch.
Ack.
while testing in one of the scenario(when a delay is introduced in slave
saImmOiRtObjectCreate_2 and saImmOmAdminOwnerSet) ERR_NOT_EXIST is returned.
syslog:
-
Apr 8 14:41:35 Slot-3 osafimmpbed: IN saImmRepositoryInit:
SA_IMM_KEEP_REPOS
I Tested your patch and it works because of the bug in the existing code
where the AVD subpart version is incremented but not the Max version(in
previous release).
Any way,
Ideal way of implementing a change in messaging part between x and y is
1. Increment the subpart version of both the servic
Hi zoran,
Reviewed and tested the patch.
Ack.
while pushing follow the suggestion of HansN.
/Neel.
On Tuesday 08 April 2014 02:15 PM, Zoran Milinkovic wrote:
> Summary: IMMTOOLS: fix errors compiled with 32-bit compiler [#838]
> Review request for Trac Ticket(s): 838
> Peer Reviewer(s): Neelakan
Hi Neel
Thanks for the comment on ERR_NOT_EXIST.
I will ad that error code also to the ones checked as reply from the
immsv (rc2B) before pushing.
Seen in retrospect, it would have been nice to have had #799 (admin-op
directly targeting implementer)
implemented before 2PBE, since the 2PBE impl
Hi zoran,
Reviewed the patch.
Ack.
/Neel.
On Thursday 03 April 2014 03:03 PM, Zoran Milinkovic wrote:
> Summary: IMM: fix memory leak in IMM [#834]
> Review request for Trac Ticket(s): 834
> Peer Reviewer(s): Neelakanta
> Pull request to: Zoran
> Affected branch(es): opensaf-4.3.x, opensaf-4.4.x,
Ack for all the three patches in this series.
Tested by bringing up two controllers one with version 4.3 (latest
change set) and another with 4.4 (latest change set).
Thanks,
Praveen
On 07-Apr-14 11:05 AM, Hans Feldt wrote:
> osaf/libs/common/avsv/avsv_d2nedu.c| 35 ++-
Ack from me.
Reviewed and tested.
Find minor comments below in the code started with [Zoran]
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 4 april 2014 14:53
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [
When IMM handle is initialized with lower version than A.2.14, after ccbApply,
ccbAbort should return ERR_VERSION, but SA_AIS_OK is returned.
When CCB is not applied, ccbAbort works fine and returns ERR_VERSION.
The rest of the code is reviewed and tested, and it's ok.
NACK until the version is f
Thanks Zoran,
Will fix this before pushing.
Waiting also for comments and/or ack from Neelakanta.
/AndersBj
-Original Message-
From: Zoran Milinkovic
Sent: den 8 april 2014 16:56
To: Anders Björnerstedt; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE:
17 matches
Mail list logo
