Re: [devel] [PATCH 3 of 4] mds: use TIPC segmentation/reassembly [#654]

On Thursday 01 May 2014 09:56 AM, A V Mahesh wrote: > Hi Surya, > > On 5/1/2014 7:28 AM, Suryanarayana Garlapati wrote: >> Nack. >> MDS ARCHWORD is used for deciding the factor whether the message >> which is being sent to the destination should be encoded >> full/flat/copied. This >> bits were

Re: [devel] [PATCH 3 of 4] mds: use TIPC segmentation/reassembly [#654]

Hi Surya, On 5/1/2014 7:28 AM, Suryanarayana Garlapati wrote: > Nack. > MDS ARCHWORD is used for deciding the factor whether the message which is > being sent to the destination should be encoded full/flat/copied. This > bits were introduced to do a optimization in the way the callbacks encode >

Re: [devel] [PATCH 1 of 4] mds: use TIPC defined max msg size for rec buffer [#654]

On Tuesday 29 April 2014 10:58 AM, Hans Feldt wrote: > osaf/libs/core/mds/include/mds_dt.h | 3 --- > osaf/libs/core/mds/mds_dt_tipc.c| 2 +- > 2 files changed, 1 insertions(+), 4 deletions(-) > > > Using connection-less TIPC messaging the largest message that can be sent and > received

Re: [devel] [PATCH 3 of 4] mds: use TIPC segmentation/reassembly [#654]

Nack. MDS ARCHWORD is used for deciding the factor whether the message which is being sent to the destination should be encoded full/flat/copied. This bits were introduced to do a optimization in the way the callbacks encode full/flat are called. For example, if there are two processes(can be pre

Re: [devel] [PATCH 1 of 1] amfd: fix infinite loop when processing CLM node tracking [#877]

Guys, Gentle reminder to ack... Alex On 04/29/2014 10:21 AM, Alex Jones wrote: > Actually, it is a PLM Deactivation request, which CLM translates into > NODE_LEFT. > > Alex > > On 04/29/2014 10:15 AM, Hans Feldt wrote: >> What is the test case, CLM node lock? >> /Hans >> >>> -Original

Re: [devel] [PATCH 1 of 7] amfd: add and use SU assignment count methods [#713]

ack, code review only, but remove void from members with empty parameters./Regards HansN On 04/30/14 07:01, Hans Feldt wrote: > osaf/services/saf/amf/amfd/include/su.h | 8 +++--- > osaf/services/saf/amf/amfd/siass.cc | 29 - > osaf/services/saf/amf/amfd/su.cc

Re: [devel] [PATCH 3 of 7] amfd: add and use SU method set_term_state [#713]

ack, code review only/Regards HansN On 04/30/14 07:01, Hans Feldt wrote: > osaf/services/saf/amf/amfd/clm.cc | 2 +- > osaf/services/saf/amf/amfd/include/su.h | 6 +- > osaf/services/saf/amf/amfd/node.cc | 2 +- > osaf/services/saf/amf/amfd/sg.cc| 5 ++--- > osa

Re: [devel] [PATCH 4 of 7] amfd: add SU constr/destr [#713]

ack, only code review, one comment shouldn't copy and assignment operators be disabled? I.e. declare them private, or use google style DISALLOW_COPY_AND_ASSIGN(AVD_SU); /Regards HansN On 04/30/14 07:01, Hans Feldt wrote: > osaf/services/saf/amf/amfd/include/su.h | 17 +-- > osaf/service

Re: [devel] [PATCH 5 of 7] amfd: add and use set_su_switch [#713]

ack, code review only/Regards HansN On 04/30/14 07:01, Hans Feldt wrote: > osaf/services/saf/amf/amfd/include/su.h | 6 +- > osaf/services/saf/amf/amfd/role.cc | 2 +- > osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 30 -- > osaf/services/saf/amf/amfd/su.c

Re: [devel] [PATCH 6 of 7] amfd: add and use SU get_node_ptr [#713]

ack, code review only, one comment: in su.h the struct keyword is redundant and can be removed: avd_avnd_tag *get_node_ptr(void); /Regards HansN On 04/30/14 07:01, Hans Feldt wrote: > osaf/services/saf/amf/amfd/comp.cc | 4 ++-- > osaf/services/saf/amf/amfd/include/su.h |

Re: [devel] [PATCH 7 of 7] amfd: add and use SU is_in_service [#713]

ack, code review only. One coment/question e.g. bool AVD_SU::is_in_service(void) or bool AVD_SU::is_in_service() , I would prefer to remove void for empty parameters when using c++. /Regards HansN -Original Message- From: Hans Feldt [mailto:osafde...@gmail.com] Sent: den 30 april 201