On 14-May-14 11:27 AM, minhchau wrote:
Hi Praveen,
I have added the check to your patch, it works fine now
/diff --git a/osaf/services/saf/amf/amfnd/susm.cc
b/osaf/services/saf/amf/amfnd/susm.cc//
//--- a/osaf/services/saf/amf/amfnd/susm.cc//
//+++ b/osaf/services/saf/amf/amfnd/susm.cc//
See inline, minor comments on naming and code layout.
Ack with these comments fixed.
/Hans
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 7 maj 2014 08:39
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc:
osaf/services/saf/amf/amfnd/susm.cc | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
During shutdown phase, AMFND performs multiple cleanup of components
in a SU if one of the components moves in TERM_FAILED state.
AMFND launches clean up of all the components during shutdown phase.
Summary: amfnd : avoid multiple clean up of comps during shutdown phase [#890].
Review request for Trac Ticket(s): #890
Peer Reviewer(s): Hans F., Nagendra
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): All
Development branch: IF ANY GIVE THE REPO URL
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: 14 May 2014 11:31
To: Nagendra Kumar; Hans Feldt; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 3 of 5] amfd: move supreinst logic from comp to su
[#713]
Yes, can do that.
Even though it is very unlikely.. good to check the return ptr-value of
`encode_reserve_space`. If `NULL` log the error and return FAILURE.
Regards,
Ramesh.
On 5/14/2014 2:01 PM, Hans Feldt wrote:
Hi,
While looking at removing(reducing) use of EDU from AMF I found that
-Original Message-
From: Ramesh Betham [mailto:ramesh.bet...@oracle.com]
Sent: den 14 maj 2014 12:05
To: Hans Feldt
Cc: Anders Widell; opensaf-devel@lists.sourceforge.net
Subject: Re: libcore additions?
Yes, can do that.
Even though it is very unlikely.. good to check the
Ok. Ack
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: 14 May 2014 16:00
To: Nagendra Kumar; Hans Feldt; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 3 of 5] amfd: move supreinst logic from comp to su
[#713]
Summary: v2 amfnd: Not all npi-components are restarted during SuRestart
escalation [#885]
Review request for Trac Ticket(s): 885
Peer Reviewer(s): Hans F, Hans N, Nagendra, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
osaf/services/saf/amf/amfnd/susm.cc | 7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
Problem: In case of npi su restart recovery, the condition to change su presence
state is not sufficient. If the component of the last csi in csi_list has been
restarted first due to
Ack
Thanks
-Nagu
-Original Message-
From: Praveen Malviya
Sent: 12 May 2014 20:43
To: hans.fe...@ericsson.com; Nagendra Kumar
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfnd : avoid multiple clean up of comps during
shutdown phase [#890]
11 matches
Mail list logo