Re: [devel] [PATCH 1 of 2] amfd: use simple decode in App ckpt [#713]

Please find comment inline. Thanks Praveen On 04-Jun-14 12:25 PM, Hans Nordeback wrote: osaf/services/saf/amf/amfd/ckpt_dec.cc | 51 ++ 1 files changed, 15 insertions(+), 36 deletions(-) diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc

[devel] [PATCH 0 of 1] Review Request for amfd: create an su in dec_su_oper_state if not found [#935]

Summary: amfd: create an su in dec_su_oper_state if not found Review request for Trac Ticket(s): [#935] Peer Reviewer(s): HansF, Nagu, Praveen Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfd: create an su in dec_su_oper_state if not found [#935]

osaf/services/saf/amf/amfd/ckpt_dec.cc | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc b/osaf/services/saf/amf/amfd/ckpt_dec.cc --- a/osaf/services/saf/amf/amfd/ckpt_dec.cc +++ b/osaf/services/saf/amf/amfd/ckpt_dec.cc @@ -1334,8

Re: [devel] [PATCH 1 of 4] amfd: remove mds copy support [#713]

ack, minor comment, lots of whitespace changes/Regards HansN On 06/03/14 07:24, Hans Feldt wrote: osaf/libs/common/amf/d2nmsg.c | 184 -- osaf/libs/common/amf/include/amf_d2nmsg.h |1 - osaf/services/saf/amf/amfd/include/mds.h |1 -

[devel] [PATCH 0 of 3] Review Request for imm: add support for configurable OI callback timeout [#16]

Summary: imm: add support for configurable OI callback timeout [#16] Review request for Trac Ticket(s): 16 Peer Reviewer(s): Neelakanta, Anders Pull request to: Zoran Affected branch(es): default(4.5) Development branch: default(4.5) Impacted area Impact y/n

[devel] [PATCH 1 of 3] imm: add support for configurable OI callback timeout [#16]

osaf/libs/common/immsv/immsv_evt.c | 56 +- osaf/libs/common/immsv/include/immsv_evt.h | 4 + osaf/libs/common/immsv/include/immsv_evt_model.h | 1 + osaf/services/saf/immsv/immd/immd_evt.c | 9 ++- osaf/services/saf/immsv/immnd/ImmModel.cc|

[devel] [PATCH 3 of 3] immtests: add test cases for OI callbacki timeout [#16]

tests/immsv/implementer/test_cleanup.c |1 + tests/immsv/implementer/test_saImmOiImplementerSet.c | 336 +++ 2 files changed, 337 insertions(+), 0 deletions(-) Test cases cover OI callback timeout and timeout on searching for an object with RTA diff --git

Re: [devel] [PATCH 1 of 1] amfd: create an su in dec_su_oper_state if not found [#935]

Ack but please ticket 713 since it is not closed. Again we should not have new tickets when the original ticket is still open. /Hans -Original Message- From: Hans Nordebäck Sent: den 5 juni 2014 13:40 To: Hans Feldt; praveen.malv...@oracle.com; nagendr...@oracle.com Cc:

Re: [devel] [PATCH 1 of 1] amfd: create an su in dec_su_oper_state if not found [#935]

Ack, only code review. Thanks, Praveen On 05-Jun-14 5:10 PM, Hans Nordeback wrote: osaf/services/saf/amf/amfd/ckpt_dec.cc | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc b/osaf/services/saf/amf/amfd/ckpt_dec.cc ---