Ack.
Thanks,
Praveen
On 13-Jun-14 10:10 AM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/include/susi.h|7 +-
osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 49 ++---
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 30 +++---
osaf/services/saf/amf/amfd/siass.cc
osaf/services/saf/amf/amfd/ckpt_dec.cc | 8 +++-
osaf/services/saf/amf/amfd/include/db_template.h | 4 +++-
osaf/services/saf/amf/amfd/include/su.h | 2 --
osaf/services/saf/amf/amfd/su.cc | 21 -
4 files changed, 10 insertions(+),
osaf/services/saf/amf/amfd/imm.cc| 47
osaf/services/saf/amf/amfd/include/imm.h | 1 -
2 files changed, 0 insertions(+), 48 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b/osaf/services/saf/amf/amfd/imm.cc
---
Summary: FILL ME
Review request for Trac Ticket(s): IF ANY LIST THE #
Peer Reviewer(s): LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): LIST ALL AFFECTED BRANCH(ES)
Development branch: IF ANY GIVE THE REPO URL
Hi all!
Summer holidays are approaching, and so is the OpenSAF 4.5 release. We
are now aiming to tag OpenSAF 4.5.FC on August 15. This means that there
is around two months left for implementing enhancements that are to be
included in OpenSAF 4.5. When 4.5.FC has been tagged, we will only
Alternatively, I think the below change is both backward and forward compatible!
Atleast i tried on automake-1.11 for the backward compatibility.
Or May be you already tried this(only the below change) on Ubuntu 14.04 and
probably faced more problems?
diff --git a/configure.ac b/configure.ac
HI Nagu
I don't think I modified any functionality or tracing. I just removed
si- from the TRACE call.
+ TRACE_ENTER2(%s AdmState %s = %s, name.value,
+ avd_adm_state_name[saAmfSIAdminState],
avd_adm_state_name[state]);
Thanks
Gary
On 13/06/14 19:46, Nagendra Kumar
Ack
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 12 June 2014 12:23
To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Nagendra
Kumar; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 4 of 4] amfd: Convert
Ack
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 12 June 2014 12:23
To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Nagendra
Kumar; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 3 of 4] amfd: Convert
My bad, overlooked. Ack.
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 13 June 2014 15:15
To: Nagendra Kumar; hans.fe...@ericsson.com;
hans.nordeb...@ericsson.com; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 4]
Ack
Thanks
-Nagu
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: 13 June 2014 11:38
To: Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 2] amfd: remove unused applier related code
[#713]
Ack
Thanks
-Nagu
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: 13 June 2014 11:38
To: Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 2 of 2] amfd: remove avd_su_get_or_create [#713]
osaf/services/saf/amf/amfd/ckpt_dec.cc
I have tried it and ran into problems with dependencies, especially when
doing a parallel build. But also I think it is a cleaner solution build
common code into libraries.
/ Anders Widell
On 06/13/2014 11:23 AM, Mathivanan Naickan Palanivelu wrote:
Alternatively, I think the below change is
If possible, please send or upload to the ticket, the warning or error that you
get
after making this change.
- Mathi.
- anders.wid...@ericsson.com wrote:
I have tried it and ran into problems with dependencies, especially
when
doing a parallel build. But also I think it is a cleaner
First great work with this series I will try find some time to review and test.
One comment inline
Thanks,
Hans
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 13 juni 2014 07:49
To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com;
Well, if I do exactly the change you suggested below, then I still get
this warning:
configure.ac:25: warning: AM_INIT_AUTOMAKE: two- and three-arguments
forms are deprecated. For more info, see:
configure.ac:25:
Ack with minor comments:
* Have you considered to use two values (e.g. -1 and -2) to avoid
spamming syslog as I suggested in the ticket, instead of using a global
flag for this purpose? A global flag is, well, global, so it doesn't
work so good when there is more than one NCS_SEL_OBJ.
ack, code review, built and run amf demo pgm/Regards HansN
On 06/13/14 06:40, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/include/susi.h|7 +-
osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 49 ++---
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 30 +++---
18 matches
Mail list logo
