[devel] [PATCH 5 of 5] plm: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/services/saf/plmsv/plms/plms_dbg_utils.c | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git a/osaf/services/saf/plmsv/plms/plms_dbg_utils.c

[devel] [PATCH 0 of 5] Review Request for replace localtime with thread safe localtime_r [#958]

2014-07-16 Thread mathi . naickan
Summary: replace localtime with thread safe localtime_r [#958] Review request for Trac Ticket(s): #958 Peer Reviewer(s): ramesh, mahesh, hans, praveen, nagendra, alex Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): 4.3.x, 4.4.x Development branch: IF ANY GIVE THE REPO

[devel] [PATCH 4 of 5] ntf: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/services/saf/ntfsv/ntfs/ntfs_evt.c | 6 +- osaf/tools/safntf/src/ntfclient.c | 6 +- 2 files changed, 10 insertions(+), 2 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git

[devel] [PATCH 1 of 5] osaf: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/libs/core/common/include/logtrace.h | 2 +- osaf/libs/core/common/logtrace.c | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git

[devel] [PATCH 2 of 5] mds: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/libs/core/mds/mds_log.c | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git a/osaf/libs/core/mds/mds_log.c b/osaf/libs/core/mds/mds_log.c --- a/osaf/libs/core/mds/mds_log.c

[devel] [PATCH 3 of 5] amf: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/services/saf/amf/amfwdog/amf_wdog.c | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git a/osaf/services/saf/amf/amfwdog/amf_wdog.c

Re: [devel] [PATCH 2 of 7] NTF: Adapt NTF common library to support long DNs [#873] v3

2014-07-16 Thread Mathivanan Naickan Palanivelu
Hi, Could you point out the endianness problem that is mentioned in the review request Thanks, Mathi. - minh.c...@dektech.com.au wrote: osaf/libs/common/ntfsv/Makefile.am |1 + osaf/libs/common/ntfsv/include/ntfsv_mem.h |7 + osaf/libs/common/ntfsv/ntfsv_enc_dec.c |

Re: [devel] [PATCH 0 of 1] Review Request for amfd: instantiate su as per saAmfSGNumPrefInserviceSUs [#445]

2014-07-16 Thread Nagendra Kumar
Additional testing done on top of this: Configured 5 SUs(SU1,SU2,SU3 on SC-1 and SU4, SU5 on SC-2) in amf demo with saAmfSGNumPrefInserviceSUs as 2. Unlock all. SU1 as Act and SU2 as Std. Only SU1 and SU2 are instantiated. 8. Lock SU3, no impact. 9. Lock SU2. SU2 csi is removed and terminated.

Re: [devel] [PATCH 0 of 1] Review Request for IMM: RDN limit of 64 characters made conditional on longDnsAllowed [#23]

2014-07-16 Thread Neelakanta Reddy
Hi AndersBj, Reviewed and tested the patch. Ack. /Neel. On Thursday 10 July 2014 06:09 PM, Anders Bjornerstedt wrote: Summary: IMM: RDN limit of 64 characters made conditional on 'longDnsAllowed' [#23] Review request for Trac Ticket(s): #23 Peer Reviewer(s): Neel; (Zoran) Pull request to:

[devel] FW: Regarding #895.

2014-07-16 Thread Anders Björnerstedt
-Original Message- From: Anders Björnerstedt Sent: den 16 juli 2014 15:04 To: 'Neelakanta Reddy' Cc: 'de...@list.opensaf.org' Subject: RE: Regarding #895. Hi Neel, Good observation! On the one hand I do think that performing a schema upgrade/change *during* any rolling upgrade

Re: [devel] [PATCH 0 of 5] Review Request for replace localtime with thread safe localtime_r [#958]

2014-07-16 Thread Alex Jones
One comment. From the man page of localtime_r: According to POSIX.1-2004, localtime() is required to behave as though tzset(3) was called, while localtime_r() does not have this require- ment. For portable code tzset(3) should be called before local-

Re: [devel] [PATCH 0 of 5] Review Request for replace localtime with thread safe localtime_r [#958]

2014-07-16 Thread Anders Widell
Yes, it seems like a good idea to call tzset(), e.g. in some library function that is always called early at start-up. / Anders Widell On 07/16/2014 03:57 PM, Alex Jones wrote: One comment. From the man page of localtime_r: According to POSIX.1-2004, localtime() is required to behave as

[devel] [PATCH 1 of 1] MM: Allow class schema change to add attribute default [#895]

2014-07-16 Thread Anders Bjornerstedt
osaf/services/saf/immsv/README| 24 +--- osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +- 2 files changed, 22 insertions(+), 4 deletions(-) This enhancement removes the restriction of not allowing a class schema change to add a default to an attribute