Summary: PLM: clear HE operational state when HE is removed
Review request for Trac Ticket(s): 1011
Peer Reviewer(s): Mathi
Pull request to: Mathi
Affected branch(es): default, 4.5
Development branch:
Impacted area Impact y/n
osaf/services/saf/plmsv/plms/hpi_intf/plms_hsm.c | 24 +++-
osaf/services/saf/plmsv/plms/plms_utils.c| 11 ++-
2 files changed, 25 insertions(+), 10 deletions(-)
Aug 22 21:14:18 linux osafplmd[10076]: ER Entity safHE=XXX,safDomain=xxxDomain
can not be moved
Ack on this one with comments in-line.
We need to write a defect ticket to do a bit of validation for the
attribute value.
Hans Feldt wrote:
> osaf/services/saf/immsv/immnd/immnd_evt.c | 26 +++---
> 1 files changed, 23 insertions(+), 3 deletions(-)
>
>
> diff --git a/osaf/s
Thank you! I will incorporate your comments and push.
/Hans
> -Original Message-
> From: Anders Björnerstedt
> Sent: den 22 augusti 2014 15:08
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1 of 2] immsv: add configurability of access control
> [#938]
>
Ack from me on PATCH 1 of 2 (first of two patches) with the following
adjustments
Hans Feldt wrote:
> osaf/libs/common/immsv/include/immsv_api.h | 8 +++
> osaf/services/saf/immsv/immloadd/imm_loader.cc | 23 +++-
> osaf/services/saf/immsv/immnd/ImmModel.cc | 69
>
osaf/services/saf/amf/amfd/svctypecstypes.cc | 20 ++--
1 files changed, 18 insertions(+), 2 deletions(-)
AMF allows to create a SaAmfSvcTypeCSTypes object although the SaAmfCSType
object referred to does not exist.
Fix by looking up the SaAmfCSType DN in the SaAmfCSType databa
Summary: Fix validation of association objects
Review request for Trac Ticket(s): 986
Peer Reviewer(s): AMF devels
Pull request to: <>
Affected branch(es): all
Development branch: <>
Impacted area Impact y/n
Docs
osaf/services/saf/amf/amfd/ctcstype.cc| 14 +
osaf/services/saf/amf/amfd/imm.cc | 7 ++--
osaf/services/saf/amf/amfd/include/util.h | 1 +
osaf/services/saf/amf/amfd/util.cc| 45 +++
4 files changed, 64 insertions(+), 3 deletions(-)
A
Ack, code review only.
/HansF
> -Original Message-
> From: Hans Nordebäck
> Sent: den 21 augusti 2014 12:21
> To: Hans Feldt; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] AMF: support immediate effect when changing comp-type
> attribute saAmfCt
osaf/libs/common/immsv/include/immsv_api.h | 8 +++
osaf/services/saf/immsv/immloadd/imm_loader.cc | 23 +++-
osaf/services/saf/immsv/immnd/ImmModel.cc | 69 ++
osaf/services/saf/immsv/immnd/ImmModel.hh | 3 +
osaf/services/saf/immsv/immnd/immnd_cb.h
osaf/services/saf/immsv/immnd/immnd_evt.c | 26 +++---
1 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c
b/osaf/services/saf/immsv/immnd/immnd_evt.c
--- a/osaf/services/saf/immsv/immnd/immnd_evt.c
+++ b/osaf/services/sa
Summary: Configurability of IMM Access control V2
Review request for Trac Ticket(s): 938
Peer Reviewer(s): Anders B & TLC?
Pull request to: <>
Affected branch(es): 4.5 & default
Development branch: <>
Impacted area Impact y/n
Ack from me for the patch series with two minor comments:
-m_AVD_SET_SG_FSM macro can be replaced with the function set_fsm_state().
-I think there is no need to pass avd_control block pointer as argument
in the following functions:
unassign_dependent(AVD_CL_CB *cb);
stop_tol_t
I think it should be > 2 as length part has 2 bytes and there will be
some value also.
Thanks
Praveen
On 22-Aug-14 4:01 PM, Anders Widell wrote:
> Ack.
>
> Question: Should the comparison in the assertion be > 2 or >= 2?
>
> / Anders Widell
>
> On 08/22/2014 07:06 AM, Minh Hon Chau wrote:
>> o
Ack.
Question: Should the comparison in the assertion be > 2 or >= 2?
/ Anders Widell
On 08/22/2014 07:06 AM, Minh Hon Chau wrote:
> osaf/libs/agents/saf/ntfa/ntfa_api.c | 1 +
> osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>
>
15 matches
Mail list logo
