So can I push this now since Neel had no objections?
Thanks,
Hans
-Original Message-
From: ramesh betham [mailto:ramesh.bet...@oracle.com]
Sent: den 2 september 2014 10:42
To: opensaf-devel@lists.sourceforge.net; Hans Feldt
Subject: Re: [devel] [PATCH 1 of 1] mds: make
For now we can push these changes.
In future there is a need to consider for option-2 as mentioned below
i.e., having svc-id + adest as part of process_info_db key.
Thanks,
Ramesh.
On 9/3/2014 1:12 PM, Hans Feldt wrote:
So can I push this now since Neel had no objections?
Thanks,
Hans
Hi zoran,
Reviewed and tested the patch.
Ack .
/Neel.
On Friday 29 August 2014 02:58 PM, Zoran Milinkovic wrote:
Summary: imm: fix loading long DNs from imm.xml and PBE [#974]
Review request for Trac Ticket(s): 974
Peer Reviewer(s): Neelakanta, Anders
Pull request to: Zoran
Affected
osaf/libs/common/amf/include/amf_defs.h |7 +-
osaf/services/saf/amf/amfd/comptype.cc | 40 ++
osaf/services/saf/amf/amfnd/compdb.cc | 375 ++-
osaf/services/saf/amf/amfnd/include/avnd_cb.h |1 +
Hi zoran,
Reviewed and tested the patch.
Ack .
/Neel.
On Friday 29 August 2014 02:58 PM, Zoran Milinkovic wrote:
Summary: imm: fix loading long DNs from imm.xml and PBE [#974]
Review request for Trac Ticket(s): 974
Peer Reviewer(s): Neelakanta, Anders
Pull request to: Zoran
Affected
Hi, any updates on this review?/Thankss HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
Sent: den 26 augusti 2014 14:41
To: nagendr...@oracle.com; Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] AMF: support immediate
Ack with minor comment inline.
/HansF
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 2 september 2014 08:36
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: send
osaf/services/saf/amf/amfd/si.cc | 4
1 files changed, 4 insertions(+), 0 deletions(-)
If shutdown op is undergoing, lock can be issued.
If lock is isued, Amf is not responding to shutdown op.
Amf should ideally respond to shutdown op immediately after
it receives lock op. And after lock
Do we think OK is an appropriate error code here?
Maybe TIMEOUT?
/Hans
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 3 september 2014 13:45
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Or from 9.4.6:
SA_AIS_ERR_BAD_OPERATION - The operation was not successful because the target
entity is locked or locked for instantiation.
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: den 3 september 2014 14:15
To: nagendr...@oracle.com; Hans Nordebäck;
Summary: immtools: support long DN in imm tools [#1038]
Review request for Trac Ticket(s): 1038
Peer Reviewer(s): Neelakanta
Pull request to: Zoran
Affected branch(es): opensaf-4.5.x, default(4.6)
Development branch: default(4.6)
Impacted area Impact y/n
osaf/tools/safimm/immadm/imm_admin.c| 7 +++
osaf/tools/safimm/immcfg/imm_cfg.c | 6 ++
osaf/tools/safimm/immdump/imm_dumper.cc | 8
osaf/tools/safimm/immfind/imm_find.c| 6 ++
osaf/tools/safimm/immlist/imm_list.c| 7 +++
5 files changed, 34
Summary: plm: don't reset self during plms_ee_instantiate
Review request for Trac Ticket(s): 1031
Peer Reviewer(s): Mathi
Pull request to: Mathi
Affected branch(es): default, 4.5
Development branch:
Impacted area Impact y/n
# HG changeset patch
# User Alex Jones ajo...@genband.com
# Date 1409678402 14400
# Tue Sep 02 13:20:02 2014 -0400
# Node ID 98bb99f081bbdc340a151425e94a418071390d59
# Parent 12251687a7e6ade049c5de9b3e4536b98e5b2091
plm: don't reset self during plms_ee_instantiate [#1031]
Active
Summary: build: fixed compilation problems for 32-bit[#997]
Review request for Trac Ticket(s): 997
Peer Reviewer(s): zoran,mahesh,ramesh
Affected branch(es):4.5.x, default
Development branch: default
Impacted area Impact y/n
osaf/libs/core/mds/mds_c_db.c | 4 ++--
osaf/libs/core/mds/mds_main.c | 4 ++--
osaf/services/saf/immsv/immnd/ImmModel.cc | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/osaf/libs/core/mds/mds_c_db.c b/osaf/libs/core/mds/mds_c_db.c
---
Summary: build: fixed compilation problems for ppc[#1007]
Review request for Trac Ticket(s): 1007
Peer Reviewer(s): Zoran, AndersBj
Affected branch(es):4.5.x, default
Development branch:4.5.x
Impacted area Impact y/n
Docs
osaf/services/saf/immsv/immloadd/imm_loader.cc | 6 +++---
osaf/tools/safimm/immcfg/imm_import.cc | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/osaf/services/saf/immsv/immloadd/imm_loader.cc
b/osaf/services/saf/immsv/immloadd/imm_loader.cc
---
Reviewed, but didn't test.
Ack from me.
Regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 3 september 2014 16:35
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1]
Ack from me.
Compiled.
Not tested.
/AndersBj
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 3 september 2014 16:25
To: Zoran Milinkovic; mahesh.va...@oracle.com; ramesh.bet...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
osaf/libs/core/mds/mds_c_api.c| 6 +++---
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/osaf/libs/core/mds/mds_c_api.c b/osaf/libs/core/mds/mds_c_api.c
--- a/osaf/libs/core/mds/mds_c_api.c
+++
Summary: build: fixed compilation problems for 32-bit[#1041]
Review request for Trac Ticket(s): 1041
Peer Reviewer(s): Zoran, mahesh, mathi
Affected branch(es): 4.5.x, default
Development branch: 4.5.x
Impacted area Impact y/n
Please use PRIx64 instead of PRIu64 for printing the address.
Ack,
Mathi.
- reddy.neelaka...@oracle.com wrote:
osaf/libs/core/mds/mds_c_api.c| 6 +++---
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
Ack from me.
Agree with Mathi that you should keep the printout of mds-dest in hex.
/AndersBj
reddy.neelaka...@oracle.com wrote:
osaf/libs/core/mds/mds_c_api.c| 6 +++---
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff
Hi,
I have the same comment as Mathi. Addresses should be printed in hexadecimal
format.
I compiled default branch with gcc 4.4.7 on 32-bit Ubuntu 12.04 and have next
compilation error:
make[6]: Entering directory
`/media/dev/emilzor/development/opensaf-default-test32bit/osaf/libs/core/mds'
With patch #1041, OpenSAF is compiled on 32-bit linux.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Zoran Milinkovic
Sent: den 3 september 2014 17:02
To: 'reddy.neelaka...@oracle.com'; mahesh.va...@oracle.com;
ramesh.bet...@oracle.com
Cc:
Reviewed and compiled.
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 3 september 2014 16:41
To: Zoran Milinkovic; mahesh.va...@oracle.com; mathi.naic...@oracle.com
Cc:
while pushing the patch i will replace PRIu64 with PRIx64.
Thanks,
Neel.
On Wednesday 03 September 2014 08:06 PM, Mathivanan Naickan Palanivelu
wrote:
Please use PRIx64 instead of PRIu64 for printing the address.
Ack,
Mathi.
- reddy.neelaka...@oracle.com wrote:
Hi Manu ,
Bt shows MDS apis context but it looks like lib old/new related issue,
Can you please check/provide
build and setup info.
===
(gdb) bt
#0 0x7f7e7a9f2472 in memcpy () from /lib64/libc.so.6
#1
29 matches
Mail list logo
