Hi Hans,
I think it is better to return OK because of following reasons:
1. It avoids Smf upgrade failures. If Amf returns TIME_OUT, Smf tries again(not
sure about the implementation, but as per Spec, it should try again) and Smf
may get TRY_AGAIN or BAD_OP error return code. If Smf get BAD_OP,
Hi Neel and Hans,
A return of ERR_TIMEOUT *always* means the invoker does *not* know if the
operation was executed or not.
It should in general never be *explicitly* returned by an OI, unless the cause
was that the OI was
itself getting ERR_TIMEOUT on a sub operation...
Invoking the same op
So far as I have seen SMF never works on SI level. The problem here is also
more manually triggered, some operator gets tired of waiting for SHUTDOWN and
goes for LOCK. SMF would not do that.
I vote for BAD_OPERATION.
/Hans
-Original Message-
From: Nagendra Kumar
So far as I have seen SMF never works on SI level.
We did the same thing with SU as part of ticket #582.
I vote for BAD_OPERATION.
As per Specs, this error is reported when target entity is locked already. Here
it is not locked.
But bigger question is : If Specs defines this path/flow as
Summary: IMM: PBE exits on errors where sqlite-handle has been closed [#996]
Review request for Trac Ticket(s): 996
Peer Reviewer(s): Neel; Zoran
Pull request to:
Affected branch(es): 4.3; 4.4; 4.5: default(4.6)
Development branch:
Impacted area Impact y/n
osaf/services/saf/immsv/immpbed/immpbe.cc| 15 +++
osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 8 ++--
2 files changed, 13 insertions(+), 10 deletions(-)
Errors returned from calls in the library:
osaf/libs/common/immsv/immpbe_dump.cc
where the sqlite
Hi Hans N,
There are some white spaces in the patch, please check below(Search with Nagu).
Tested following scenarios:
1. Configuring saAmfCompNumMaxInstantiateWithoutDelay and then changing
saAmfNumMaxInstantiateWithoutDelay. Of course, it didn't result in changing the
value.
But when I
Summary:imm:Return TRY_AGAIN if implemeter is not yet discarded [#946]
Review request for Trac Ticket(s):946
Peer Reviewer(s):AndersBj, Zoran
Affected branch(es):4.3.x, 4.4, 4.5, default
Development branch:default
Impacted area Impact y/n
osaf/services/saf/immsv/immnd/ImmModel.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
At the time of OIfinalizing of the OI handle, An FEVS message is sent to clear
the implementer. A FEVs message is sent from local IMMND to active IMMD and
active IMMD broadcast the message to
Hi Nagu, I'll check this and the other patches. I guess I have missed
these use cases. /Thanks HansN
On 09/04/14 12:41, Nagendra Kumar wrote:
Hi Hans N,
There are some white spaces in the patch, please check below(Search with
Nagu).
Tested following scenarios:
1. Configuring
Ack from me with the nano-optimization suggested below
reddy.neelaka...@oracle.com wrote:
osaf/services/saf/immsv/immnd/ImmModel.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
At the time of OIfinalizing of the OI handle, An FEVS message is sent to
clear the implementer. A
Hi Anders,
Just realized, there is a problem in below patch.
The problem with the floated patch is in ImmModel::discardImplementer,
the value passed for reallyDiscard is false for
immnd_proc_imma_discard_connection which is used at the time of
Oifinalize . Because of this info-mDying is
Hi Neel,
Ok.
The nano-optimization was actually a correction to make the patch
effective :-)
/AndersBj
Neelakanta Reddy wrote:
Hi Anders,
Just realized, there is a problem in below patch.
The problem with the floated patch is in
ImmModel::discardImplementer, the value passed for
Actually no it was not.
Now I see the problem: the negation of impl-mDying.
/AndersBj
Anders Bjornerstedt wrote:
Hi Neel,
Ok.
The nano-optimization was actually a correction to make the patch
effective :-)
/AndersBj
Neelakanta Reddy wrote:
Hi Anders,
Just realized, there is a
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 4 september 2014 10:24
To: Hans Feldt; Hans Nordebäck; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amfd: respond to shutdown op if lock has
been issued
osaf/libs/agents/saf/imma/imma_proc.c | 6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
callbk_mbx can fail only when handle is finalized.If a NULL is returned by
m_NCS_IPC_RECEIVE then handle is considered as finalized and is a valid
case.so, SA_AIS_OK will be returned*/
diff
Summary:imm:Return AIS_OK when m_NCS_IPC_RECEIVE receives NULL in dispatch
block[#937]
Review request for Trac Ticket(s): 937
Peer Reviewer(s): Zoran, Surendar, AndersBj
Affected branch(es):4.3.x, 4.4.x, 4.5.x, default
Development branch: default
Impacted area
Reviewed, but didn't test.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 4 september 2014 12:02
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] IMM: PBE exits on errors where
Summary: amf : disable oper state of faulty comp if SU is disabled [#1035]
Review request for Trac Ticket(s): #1035
Peer Reviewer(s): AMF contributors
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): ALL
Development branch: IF ANY GIVE THE REPO URL
osaf/services/saf/amf/amfd/ndproc.cc | 10 ++
osaf/services/saf/amf/amfnd/clc.cc | 12
osaf/services/saf/amf/amfnd/susm.cc | 14 ++
3 files changed, 32 insertions(+), 4 deletions(-)
Operational state of faulty component is not disabled when SU gets
20 matches
Mail list logo
