[devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050]

2014-09-10 Thread Hans Feldt
osaf/libs/agents/saf/imma/imma.h | 1 + osaf/libs/agents/saf/imma/imma_init.c | 6 ++ osaf/libs/agents/saf/imma/imma_mds.c | 7 --- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/osaf/libs/agents/saf/imma/imma.h b/osaf/libs/agents/saf/imma/imma.h ---

[devel] [PATCH 0 of 2] Review Request for MDS/IMMA #1050

2014-09-10 Thread Hans Feldt
Summary: Harden/change MDS cleanup of proces_info Review request for Trac Ticket(s): 1050 Peer Reviewer(s): Mahesh Anders B (imma part) Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): 4.5 default Development branch: IF ANY GIVE THE REPO URL

[devel] [PATCH 1 of 2] mds: use timeout to delete proc info entries [#1050]

2014-09-10 Thread Hans Feldt
osaf/libs/core/mds/include/mds_core.h |1 - osaf/libs/core/mds/include/mds_dl_api.h |1 + osaf/libs/core/mds/include/mds_dt2c.h |7 +- osaf/libs/core/mds/mds_c_api.c | 43 +++-- osaf/libs/core/mds/mds_dt_common.c | 11 ++- osaf/libs/core/mds/mds_main.c

Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050]

2014-09-10 Thread Anders Bjornerstedt
A few questions below, see inline. Hans Feldt wrote: osaf/libs/agents/saf/imma/imma.h | 1 + osaf/libs/agents/saf/imma/imma_init.c | 6 ++ osaf/libs/agents/saf/imma/imma_mds.c | 7 --- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git

Re: [devel] [PATCH 1 of 1] mds: send full encode message for Mcast message type [#1043]

2014-09-10 Thread ramesh betham
Ack. Thanks, Ramesh. On 9/10/2014 9:48 AM, mahesh.va...@oracle.com wrote: Suppose if the entry retrieved form subscription table is of |0 osaf/libs/core/mds/mds_c_sndrcv.c|8 +++- 2 files changed, 7 insertions(+), 1 deletions(-) While sending

Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050]

2014-09-10 Thread Hans Feldt
-Original Message- From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com] Sent: den 10 september 2014 11:37 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050] A few questions

Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050]

2014-09-10 Thread Anders Bjornerstedt
Hans Feldt wrote: -Original Message- From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com] Sent: den 10 september 2014 11:37 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050] A few

Re: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway [#949]

2014-09-10 Thread Nagendra Kumar
Hi Hans, Can you please apply the below patch and run on latest and confirm if it works. 1. If it doesn't, I will investigate further. 2. If it works, can you please rerun your test on 5392 and confirm it works. Thanks -Nagu diff --git a/osaf/services/saf/amf/amfd/sg_nway_fsm.cc

Re: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway [#949]

2014-09-10 Thread Nagendra Kumar
Let me rephrase it: Can you please apply the below patch on latest and rerun test case and confirm if it works. If it doesn't, please ignore the patch and rerun the test on 5392 and check if it works. If it doesn't, I will investigate it further. Thanks -Nagu -Original Message-

Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050]

2014-09-10 Thread Hans Feldt
-Original Message- From: Anders Björnerstedt Sent: den 10 september 2014 12:06 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050] Hans Feldt wrote: -Original Message- From: Anders

Re: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway [#949]

2014-09-10 Thread Hans Feldt
-Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 10 september 2014 12:24 To: Hans Feldt; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway [#949] Hi Hans, Can you

Re: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway [#949]

2014-09-10 Thread Nagendra Kumar
Well, I thought changeset 5394 has created the problem. Why don't you test on default itself, ahead of changeset 5327 and see which changeset makes it fail? Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 10 September 2014 16:50 To: Nagendra

Re: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway [#949]

2014-09-10 Thread Nagendra Kumar
Default means opensaf-4.5.x (was default before) Thanks -Nagu -Original Message- From: Nagendra Kumar Sent: 10 September 2014 17:10 To: Hans Feldt; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway

Re: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway [#949]

2014-09-10 Thread Hans Feldt
4.4.0 works -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 10 september 2014 13:40 To: Hans Feldt; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway [#949] Well, I

Re: [devel] [PATCH 1 of 1] AMF: support immediate effect when changing SaAmfCompGlobalAttributes [#819]

2014-09-10 Thread Nagendra Kumar
is not changed, do you mean not changed in IMM? No, I mean in the code. Let me explain a bit more on both the points. 1. Configuring saAmfCompNumMaxInstantiateWithoutDelay(say 10) and then changing saAmfNumMaxInstantiateWithoutDelay(change from 20 to 30). Of course, it didn't result in

Re: [devel] [PATCH 1 of 1] amfd: fix SI assign algorithm in Nway [#949]

2014-09-10 Thread Nagendra Kumar
Nice. I would like to see which 4.5.x changeset broke it. Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 10 September 2014 17:09 To: Nagendra Kumar; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 1 of 1]

Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050]

2014-09-10 Thread Hans Feldt
So this patch can/could have been split into two. The is_immnd_up setting moved is a separate change done on speculation and not verified to improve anything. Do you want me to split the patch? Plus there might an additional issue to look as Anders and I discussed. Adding logic to cater for

Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect [#1050]

2014-09-10 Thread Anders Bjornerstedt
Usually, when I find myself in a situation where there is an error case that in theory could happen but I cant figure out if/when it will happen, which also should mean that it is rare, then instead of writing any elaborate code to deal with it, I either osafassert (which will log an error and