Re: [devel] [PATCH 1 of 1] base: add check for user's primary group [#1070]

2014-09-23 Thread ramesh betham
Ack. Regards, Ramesh. On 9/23/2014 10:19 AM, Hans Feldt wrote: > osaf/libs/core/common/osaf_secutil.c | 13 +++-- > 1 files changed, 7 insertions(+), 6 deletions(-) > > > In function osaf_user_is_member_of_group user's primary group is not checked. > Current checking only checks the s

Re: [devel] [PATCH 1 of 1] tools/safntf : validate ntfsend options V3 [#1069]

2014-09-23 Thread Lennart Lund
Ack /Lennart > -Original Message- > From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] > Sent: den 22 september 2014 13:36 > To: Lennart Lund; mathi.naic...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] tools/safntf : validate ntfsend opt

[devel] [PATCH 1 of 1] immtools: allocate enough memory for long log format in immcfg [#1089]

2014-09-23 Thread Zoran Milinkovic
osaf/tools/safimm/immcfg/imm_import.cc | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) With long DN, log format can go over 1024 bytes. The patch handles long log format, and allocate enough memory for the log format. diff --git a/osaf/tools/safimm/immcfg/imm_import.cc

[devel] [PATCH 0 of 1] Review Request for immtools: allocate enough memory for long log format in immcfg [#1089]

2014-09-23 Thread Zoran Milinkovic
Summary: immtools: allocate enough memory for long log format in immcfg [#1089] Review request for Trac Ticket(s): 1089 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.3.x, opensaf-4.4.x, opensaf-4.5.x, default(4.6) Development branch: default(4.6) --

Re: [devel] [PATCH 1 of 1] imm: In immnd_evt_proc_ccb_compl_rsp skip to end if PBE-OI is detached [#1096]

2014-09-23 Thread Neelakanta Reddy
Hi AndersBj, Reviewed the patch. Ack. /Neel. On Monday 22 September 2014 08:22 PM, Anders Bjornerstedt wrote: > osaf/services/saf/immsv/immnd/immnd_evt.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > > The case is where a CCB has passed validation by all involved OIs. Normal

Re: [devel] [PATCH 1 of 1] imm: In immnd_evt_proc_ccb_compl_rsp skip to end if PBE-OI is detached [#1096]

2014-09-23 Thread Anders Björnerstedt
Thanks Neel for pointing out #1127. This ticket #1096 is due to a coverity report. Potential dereference of a NULL client node. /AndersBj -Original Message- From: Anders Björnerstedt [mailto:anders.bjornerst...@ericsson.com] Sent: den 23 september 2014 09:48 To: Neelakanta Reddy Cc:

Re: [devel] [PATCH 1 of 1] imm: In immnd_evt_proc_ccb_compl_rsp skip to end if PBE-OI is detached [#1096]

2014-09-23 Thread Zoran Milinkovic
Ack from me. Best regards, Zoran -Original Message- From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com] Sent: den 22 september 2014 16:53 To: reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1 of 1] imm: In immnd_evt_proc_ccb_com

Re: [devel] [PATCH 1 of 1] imm: In immnd_evt_proc_ccb_compl_rsp skip to end if PBE-OI is detached [#1096]

2014-09-23 Thread Anders Björnerstedt
That is a bug. I will write a ticket on it. /AndersBj -Original Message- From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] Sent: den 23 september 2014 09:30 To: Anders Björnerstedt Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1 of 1] imm: In immnd_evt_proc_ccb_c

Re: [devel] [PATCH 1 of 1] imm: describe how to configure accessControlMode at build time [#1121]

2014-09-23 Thread Anders Björnerstedt
Ack from me. /AndersBj -Original Message- From: Hans Feldt Sent: den 23 september 2014 09:09 To: Anders Björnerstedt Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] imm: describe how to configure accessControlMode at build time [#1121] osaf/services/saf/immsv/README.A

[devel] [PATCH 1 of 1] imm: describe how to configure accessControlMode at build time [#1121]

2014-09-23 Thread Hans Feldt
osaf/services/saf/immsv/README.ACCESS_CONTROL | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/osaf/services/saf/immsv/README.ACCESS_CONTROL b/osaf/services/saf/immsv/README.ACCESS_CONTROL --- a/osaf/services/saf/immsv/README.ACCESS_CONTROL +++ b/osaf/services/saf/imms

[devel] [PATCH 0 of 1] Review Request for imm #1121

2014-09-23 Thread Hans Feldt
Summary: <> Review request for Trac Ticket(s): 1121 Peer Reviewer(s): Anders B Pull request to: <> Affected branch(es): <> Development branch: <> Impacted area Impact y/n Docsn Build systemn

Re: [devel] [PATCH 1 of 1] clm: avoid stale node down processing and unexpected track callback [#1120]

2014-09-23 Thread Hans Nordebäck
Hi Mathi, I added the patch below and I can still reproduce the fault./Regards HansN -Original Message- From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] Sent: den 23 september 2014 09:13 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net; Hans Nordebäck Subject:

Re: [devel] [PATCH 1 of 1] clm: avoid stale node down processing and unexpected track callback [#1120]

2014-09-23 Thread Mathivanan Naickan Palanivelu
Please hold on, that clms_process_clma_down_list() is not adequate, some modifications to that function is necessary. Will send a v2 of the patch. Thanks, Mathi. - mathi.naic...@oracle.com wrote: > If the node restarted so quickly, then the fix for this is as below: > > diff --git a/osaf/s

Re: [devel] [PATCH 1 of 1] imm: In immnd_evt_proc_ccb_compl_rsp skip to end if PBE-OI is detached [#1096]

2014-09-23 Thread Neelakanta Reddy
Hi AndersBj, for the same case in immnd_evt_proc_ccb_apply IMMND is aborted. if (oi_cl_node == NULL || oi_cl_node->mIsStale) { LOG_WA("PBE went down"); /* TODO need to ABORT ccb in CRITICAL. or se

Re: [devel] [PATCH 1 of 1] clm: avoid stale node down processing and unexpected track callback [#1120]

2014-09-23 Thread Mathivanan Naickan Palanivelu
If the node restarted so quickly, then the fix for this is as below: diff --git a/osaf/services/saf/clmsv/clms/clms_evt.c b/osaf/services/saf/clmsv/clms/clms_evt.c --- a/osaf/services/saf/clmsv/clms/clms_evt.c +++ b/osaf/services/saf/clmsv/clms/clms_evt.c @@ -539,6 +539,12 @@ static uint32_t proc

Re: [devel] [PATCH 1 of 1] clm: avoid stale node down processing and unexpected track callback [#1120]

2014-09-23 Thread Hans Feldt
Isn't that a race because restart in UML goes so unreasonable quick that we cannot handle it? When CLM is handling the node down of PL4 it is already up again or something /HansF > -Original Message- > From: Hans Nordebäck > Sent: den 23 september 2014 08:59 > To: Mathivanan Naickan Palan

Re: [devel] [PATCH 1 of 1] clm: avoid stale node down processing and unexpected track callback [#1120]

2014-09-23 Thread Hans Nordebäck
yes, it was sent after the node come up, in this case payload 4. It is easily reproduced using the power-off code and stopping and starting a couple of payloads. /Regards HansN -Original Message- From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] Sent: den 23 sept