Re: [devel] [PATCH 1 of 1] imm: add missing check in seach init [#1135]

Ack from me. /AndersBj Zoran Milinkovic wrote: > osaf/libs/agents/saf/imma/imma_om_api.c | 22 +++--- > 1 files changed, 15 insertions(+), 7 deletions(-) > > > Add missing check for the case that root name length is great than 0, and > root name value length is 0. > > diff --gi

Re: [devel] [PATCH 1 of 1] imm: add missing check and fix validation in seach init [#1135]

Tentative ACK with same comment as Neel. Plus a question on a small part of the code below, see inline. Zoran Milinkovic wrote: > osaf/libs/agents/saf/imma/imma_om_api.c | 24 ++-- > 1 files changed, 18 insertions(+), 6 deletions(-) > > > Add missing check for the case that r

Re: [devel] [PATCH 0 of 1] Review Request for imm: add missing check and fix validation in seach init [#1135]

Just a clarification. I think this RR is for 4.5.x and default(4.6) right ? /AndersBj -Original Message- From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] Sent: den 29 september 2014 15:45 To: reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [devel

[devel] [PATCH 0 of 1] Review Request for imm: add missing check and fix validation in seach init [#1135]

Summary: imm: add missing check and fix validation in seach init [#1135] Review request for Trac Ticket(s): 1135 Peer Reviewer(s): Neelakanta, Anders Pull request to: Zoran Affected branch(es): opernsaf-4.4.x, default(4.6) Development branch: default(4.6) Impacted

[devel] [PATCH 1 of 1] imm: add missing check and fix validation in seach init [#1135]

osaf/libs/agents/saf/imma/imma_om_api.c | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) Add missing check for the case that root name length is great than 0, and root name value length is 0. Fix validation of root name. diff --git a/osaf/libs/agents/saf/imma/i

[devel] [PATCH 1 of 1] imm: add missing check in seach init [#1135]

osaf/libs/agents/saf/imma/imma_om_api.c | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) Add missing check for the case that root name length is great than 0, and root name value length is 0. diff --git a/osaf/libs/agents/saf/imma/imma_om_api.c b/osaf/libs/agent

[devel] [PATCH 0 of 1] Review Request for imm: add missing check in seach init [#1135]

Summary: imm: add missing check in seach init [#1135] Review request for Trac Ticket(s): 1135 Peer Reviewer(s): Neelakanta, Anders Pull request to: Zoran Affected branch(es): opensaf-4.3.x, opensaf-4.4.x Development branch: opensaf-4.4.x Impacted area Impact

Re: [devel] [PATCH 2 of 2] NTF: Add protection against longDn notification for unadapted producer/consumer [#1114]

Hi Minh, I have two initial comments : 1) When an unadapted subscriber is calling saNtfDispatch(), this API returns ERR_NAME_TOO_LONG without invoking callback. Here I think SA_AIS_OK can be returned without invoking callback because any legacy application will not have handling for ERR_NA