Summary: fix pyosaf saImmOmAdminOperationInvoke
Review request for Trac Ticket(s): 1176
Peer Reviewer(s): Hans N
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): all
Development branch: IF ANY GIVE THE REPO URL
Impacted area Impact
python/pyosaf/saAis.py | 4 ++--
python/pyosaf/saImmOm.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
exception when using saImmOmAdminOperationInvoke_2:
ctypes.ArgumentError: argument 5: type 'exceptions.TypeError'=: expected
LP_LP_SaImmAdminOperationParamsT instance instead
Tested as :
1. With TCP with enable and disable MDS_TIPC_MCAST_ENABLED with two
controllers. I didn't get the following logs, which I assume that this variable
is not used for TCP(by enabling MDS log level):
MDTM: Break while(1)
2. With TIPC with enable and disable
On 10/20/2014 10:40 AM, Hans Feldt wrote:
python/pyosaf/saAis.py | 4 ++--
python/pyosaf/saImmOm.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
exception when using saImmOmAdminOperationInvoke_2:
ctypes.ArgumentError: argument 5: type 'exceptions.TypeError'=:
Reviewed and tested the patch.
Ack from me.
Regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 16 oktober 2014 13:35
To: Zoran Milinkovic; Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1]
Ack, code review only, yes it should be
SaImmAdminOperationParamsT_2./Regards HansN
On 10/20/2014 01:25 PM, Hans Feldt wrote:
On 10/20/2014 10:40 AM, Hans Feldt wrote:
python/pyosaf/saAis.py | 4 ++--
python/pyosaf/saImmOm.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
python/pyosaf/saEnumConst.py | 53 ---
1 files changed, 29 insertions(+), 24 deletions(-)
Change wildcard imports
Some other minor changes but not mixed whitespace
diff --git a/python/pyosaf/saEnumConst.py b/python/pyosaf/saEnumConst.py
---
Summary: fix pylint rating focused on immom
Review request for Trac Ticket(s): 751
Peer Reviewer(s): Hans N
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): LIST ALL AFFECTED BRANCH(ES)
Development branch: IF ANY GIVE THE REPO URL
python/pyosaf/saImmOm.py | 71 +++
1 files changed, 59 insertions(+), 12 deletions(-)
Change wildcard imports
Some other minor changes but not mixed whitespace
diff --git a/python/pyosaf/saImmOm.py b/python/pyosaf/saImmOm.py
---
Hi AndersBj,
Reviewed and tested the patch.
Ack.
minor comment(not related to the patch):
when the NO_RESOURCE is returned the logging information is there only
for completed_rsp. The logging should be added to create_rsp and
modified_rsp.
Eg:
case SA_AIS_ERR_NO_RESOURCES:
python/pyosaf/saAis.py | 48 +---
1 files changed, 33 insertions(+), 15 deletions(-)
Change wildcard imports
Some other minor changes but not mixed whitespace
diff --git a/python/pyosaf/saAis.py b/python/pyosaf/saAis.py
--- a/python/pyosaf/saAis.py
python/pyosaf/saImm.py | 28 +++-
1 files changed, 23 insertions(+), 5 deletions(-)
Change wildcard imports
Some other minor changes but not mixed whitespace
diff --git a/python/pyosaf/saImm.py b/python/pyosaf/saImm.py
--- a/python/pyosaf/saImm.py
+++
Ok, will add such logging before pushing.
Thanks,
/AndersBj
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 20 oktober 2014 16:03
To: Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for IMM
Ack from me.
/AndersBj
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 16 oktober 2014 13:35
To: Zoran Milinkovic; Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:loading of 2PBE will fail when
The addition of the extra logging for ceate/delete/modify was not as trivial
as I had thought.
You only asked for additions to create and modify, but then why not also delete
..
Well deletes can be cascading and so could create a lot of spam to the syslog.
So will postpone this log'ing for
Summary: AMF: Update SI dependencies after Su Failover for NpM SG V2
Review request for Trac Ticket(s): 1101
Peer Reviewer(s): Hans F, Hans N, Nagu, Praveen
Pull request to:
Affected branch(es): 4.4
Development branch:
Impacted area Impact y/n
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
As the NpM SU needs to be failed-over, the current code is seeking the standby
SUs that can take
over the Active assignments. But if no such standby SU is found, the SI
As the issue is not reproducible, verified with patch 2.
Also executed some failovers and switchovers with IMCN up on patch 1.
Ack with minor comments inline with [Praveen].
Thanks
Praveen
On 16-Oct-14 9:09 PM, Lennart Lund wrote:
osaf/services/saf/ntfsv/ntfimcnd/ntfimcn_main.c |2 +-
18 matches
Mail list logo
