[devel] [PATCH 0 of 1] Review Request for ntf/safntf: print lengthAdditionalText with ntfsubscribe -v [#1215]

2014-12-04 Thread praveen . malviya
Summary: ntf/safntf: print lengthAdditionalText with ntfsubscribe -v [#1215] Review request for Trac Ticket(s): #1215 Peer Reviewer(s): Minh Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): All Development branch: IF ANY GIVE THE REPO URL

Re: [devel] [PATCH 1 of 1] amfd : fix default value of saAmfSIPrefActiveAssignments during upgrades [1190]

2014-12-04 Thread praveen malviya
On 04-Dec-14 2:16 PM, Hans Nordebäck wrote: Hi Praveen, thanks, but my question was related to the if statement in the patch below, see inline/Thanks HansN On 12/04/2014 09:34 AM, praveen malviya wrote: On 03-Dec-14 5:48 PM, Hans Nordebäck wrote: ack, code review only. One question, why

[devel] [PATCH 1 of 1] smf: reading of longDnsAllowed attribute does not block [#1230]

2014-12-04 Thread Robert Apanowicz
osaf/services/saf/smfsv/smfd/SmfCampaignInit.cc | 13 +++-- osaf/services/saf/smfsv/smfd/SmfUtils.cc | 12 ++-- osaf/services/saf/smfsv/smfd/SmfUtils.hh | 3 +-- osaf/services/saf/smfsv/smfd/smfd_campaign_oi.cc | 5 + 4 files changed, 11 insertions(+),

Re: [devel] [PATCH 1 of 1] amfd: fix mem leak in su_to_terminate function [#1226]

2014-12-04 Thread Hans Nordebäck
ack, code review only/Thanks HansN On 12/04/2014 11:52 AM, nagendr...@oracle.com wrote: osaf/services/saf/amf/amfd/sgproc.cc | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfd/sgproc.cc b/osaf/services/saf/amf/amfd/sgproc.cc ---

Re: [devel] [PATCH 1 of 1] smf: reading of longDnsAllowed attribute does not block [#1230]

2014-12-04 Thread Ingvar Bergström
Hi, yes but getObject read the whole object, this shall always be possible. The problem was that the read object did not contain the new attribute. Failing to read the OpensafImm object shall still generate a fail. Failing to read the new attribute longDnsAllowed can happen in an update