Summary: amfd: reset ng op params after performing sufailover [#1279]
Review request for Trac Ticket(s): IF ANY LIST THE #
Peer Reviewer(s): Hans N., Nagendra.
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): Default and 4.6
Development branch: IF ANY GIVE THE REPO
osaf/services/saf/amf/amfd/sgproc.cc | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
If lock/shutdown operation on a nodegroup is in progress and component faults
with
sufailover recovery while handling quiesced/quiescing callback, then two
problems
are obserbed in case of
ack, code review only/Thanks HansN
On 03/25/2015 05:44 AM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/node.cc | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/node.cc
b/osaf/services/saf/amf/amfd/node.cc
---
ack, code review only/Thanks HansN
On 03/19/2015 10:24 AM, nagendr...@oracle.com wrote:
+ m_AVSV_SEND_CKPT_UPDT_ASYNC_UPDT(avd_cb,
su-su_on_node, AVSV_CKPT_AVND_ADMIN_STATE);
--
Dive into
Summary: imm: fix missing attributes with SA_IMM_SEARCH_GET_ALL_ATTR flag
[#1282]
Review request for Trac Ticket(s): 1282
Peer Reviewer(s): Neelakanta, Anders
Pull request to: Zoran
Affected branch(es): opensaf-4.6.x, default(4.7)
Development branch: default(4.7)
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
The patch fix the bug introduced in #643. With the path, when
SA_IMM_SEARCH_GET_ALL_ATTR flag is set, the result contains attributes.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
Ack from me.
That was a pretty obvious and clean bug.
I wish more defects where like that.
/AndersBj
On 03/25/2015 10:40 AM, Zoran Milinkovic wrote:
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
The patch fix the bug introduced in
Hi zoran,
Review the patch.
Ack.
/Neel.
On Wednesday 25 March 2015 03:10 PM, Zoran Milinkovic wrote:
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
The patch fix the bug introduced in #643. With the path, when
Hi,
Find my comments inline.
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: Wednesday, March 25, 2015 6:17 AM
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] IMM: Add
Summary: base: base: Dump stack trace to file on fatal signals, V2 #1281
Review request for Trac Ticket(s): #1281
Peer Reviewer(s): AndersW, Ramesh, Mathi
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
osaf/libs/core/common/daemon.c | 91 ++
1 files changed, 91 insertions(+), 0 deletions(-)
diff --git a/osaf/libs/core/common/daemon.c b/osaf/libs/core/common/daemon.c
--- a/osaf/libs/core/common/daemon.c
+++ b/osaf/libs/core/common/daemon.c
@@ -43,6
Hi Hung,
I am sorry but I have to NACK this patch version also :-(
I can understand if that is enough to make you give up on this
enhancement, but please read the review comments belwo.
The patch is probably functionally correct, but it adds too much
unnecessary memory
Will fix the typos before pushing.
/AndersBj
On 03/25/2015 02:43 PM, Zoran Milinkovic wrote:
Hi,
Find my comments inline.
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: Wednesday, March 25, 2015 6:17 AM
To: reddy.neelaka...@oracle.com
13 matches
Mail list logo
