Hi Gary,
two questions, in avnd_msg_content_free it seems that the cbk_info is
not freed if msg->info.ava == 0,
it is set to 0 when avnd_mds_send succeeds, so it will not be freed as
that code now has been removed?
The cbk_info is a local variable so it shouldn't be necessary to set it
to 0.
/
osaf/libs/agents/saf/amfa/ava_api.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
While invalid handle is passed to saAmfProtectionGroupTrack_4, code jumps to
done and calls avsv_nda_ava_msg_content_free(&msg). But msg is not meset
to zero, so it has garbage values. Inside avsv_n
Summary: amfa: avoid illigal memory access [#1307]
Review request for Trac Ticket(s): #1307
Peer Reviewer(s): Hans N, Praveen
Pull request to: <>
Affected branch(es): All
Development branch: Default
Impacted area Impact y/n
D
ack, code review only/Thanks HansN
On 04/21/2015 01:31 PM, nagendr...@oracle.com wrote:
> osaf/libs/agents/saf/amfa/ava_api.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>
> While invalid handle is passed to saAmfProtectionGroupTrack_4, code jumps to
> done and calls avsv_
osaf/services/saf/amf/amfd/imm.cc | 79 +++---
1 files changed, 55 insertions(+), 24 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b/osaf/services/saf/amf/amfd/imm.cc
--- a/osaf/services/saf/amf/amfd/imm.cc
+++ b/osaf/services/saf/amf/amfd/imm.cc
@
Summary: amfd: node rebooted when immnd is killed twice in succession
Review request for Trac Ticket(s): #1290
Peer Reviewer(s): Nagu, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Ack from me.
/AndersBj
On 04/17/2015 03:25 PM, reddy.neelaka...@oracle.com wrote:
> osaf/services/saf/immsv/immnd/ImmModel.cc | 9 ++---
> osaf/services/saf/immsv/immnd/immnd_evt.c | 18 ++
> 2 files changed, 8 insertions(+), 19 deletions(-)
>
>
> If an CCB is aborted,
Ack with a comment.
Thanks,
Praveen
On 17-Apr-15 7:33 AM, Minh Hon Chau wrote:
> osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 43
> +++-
> 1 files changed, 36 insertions(+), 7 deletions(-)
>
>
> During si-swap, node-failover happens on the node which's su just fini
Hi Hans
I think the success case should be OK. cbk_info is freed when
avnd_msg_content_free() is called elsewhere (avnd_mds_flat_enc?) for the
successful case. The bit of code I removed was only getting called when
'NCSCC_RC_SUCCESS != rc'.
I agree with your second comment. Setting it to 0 is
ack, (code review only) /Thanks HansN
On 04/22/2015 07:04 AM, Gary Lee wrote:
> Hi Hans
>
> I think the success case should be OK. cbk_info is freed when
> avnd_msg_content_free() is called elsewhere (avnd_mds_flat_enc?) for
> the successful case. The bit of code I removed was only getting calle
10 matches
Mail list logo