ack code review only, one question below, (I may have missed see the
check). /Thanks HansN
On 07/29/2015 08:36 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 99
> +++-
> 1 files changed, 47 insertions(+), 52 deletions(-)
>
>
> diff --git a/osaf/s
ack (code review only). I like this version better than the original, as
it's less error prone. One very minor comment below.
On 07/08/15 16:57, Hans Nordeback wrote:
> osaf/services/saf/amf/amfd/apptype.cc| 16 ++--
> osaf/services/saf/amf/amfd/include/apptype.h | 6 +++
ack for the whole series, code review only. Minor comment, all patches
must be applied to compile,
and a question in patch 04. Perhaps we can use c++11 nullptr instead of
NULL for pointers? /Thanks HansN
On 07/29/2015 08:36 AM, Gary Lee wrote:
> Summary: amfd: convert AVD_SG_OPER to std::list [#
ack (code review only)
On 07/08/15 16:57, Hans Nordeback wrote:
> osaf/services/saf/amf/amfd/compcstype.cc | 23 ++-
> osaf/services/saf/amf/amfd/include/comp.h | 15 +++
> 2 files changed, 9 insertions(+), 29 deletions(-)
>
>
> Use C++11 in-class initializer
Hi,
This is an addendum to the previous(see below) announcement for cleaning up and
updating
the backlog tickets.
The ticket handling guidelines have been updated in the wiki, particularly the
'milestone' field.
The main update is that the milestone for defects should not be set to 'future'.
O
osaf/services/saf/amf/amfd/compcstype.cc | 23 ++-
osaf/services/saf/amf/amfd/include/comp.h | 15 +++
2 files changed, 9 insertions(+), 29 deletions(-)
Use C++11 in-class initializers.
diff --git a/osaf/services/saf/amf/amfd/compcstype.cc
b/osaf/services/saf
Summary:amfd: make AVD_APP_TYPE and AVD_COMPCS_TYPE a class, alternative V2
Review request for Trac Ticket(s): #1142
Peer Reviewer(s): Nagu, Praveen, Gary
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
---
osaf/services/saf/amf/amfd/apptype.cc| 16 ++--
osaf/services/saf/amf/amfd/include/apptype.h | 6 +++---
2 files changed, 9 insertions(+), 13 deletions(-)
Use C++11 in-class initializers.
diff --git a/osaf/services/saf/amf/amfd/apptype.cc
b/osaf/services/saf/amf/amfd/app
Guys,
I'm seeing a huge leak in cpnd. There is something very strange
with the released software, though. Here is the leak from the released
tar file (official 4.5.1.tar.gz and 4.6.0.tar.gz both have this):
cpnd_proc.c:272
send_evt.info.cpa.info.arr_msg.ckpt_data = NULL;
This overw
