Hi Hans
Using nullptr sounds like a good idea. Can we do this in a separate
patch series?
Gary
On 07/08/15 21:58, Hans Nordebäck wrote:
> ack for the whole series, code review only. Minor comment, all patches
> must be applied to compile,
> and a question in patch 04. Perhaps we can use c++11
Summary: log: saflogger should use built-in default log file format in log
server [#1433]
Review request for Trac Ticket(s): #1433
Peer Reviewer(s): mathi.naic...@oracle.com; lennart.l...@ericsson.com
Pull request to: lennart.l...@ericsson.com
Affected branch(es): default
Development branch: <>
-
osaf/tools/saflog/saflogger/saf_logger.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Currently, saflogger tool uses its own defined log file format
for application stream, instead of built-in one in log server.
diff --git a/osaf/tools/saflog/saflogger/saf_logger.c
b/osaf/tools/s
Hi Johan,
Tested the patch.
Ack from me.
Best Regards,
Hùng Nguyễn
DEK Technologies
*From:* Johan Mårtensson O
*Sent:* Wednesday, August 05, 2015 7:24PM
*To:* Hans Nordeback, Mathivanan Naickan, Hung Nguyen, Srikanth R
Ack
Thanks
Lennart
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 11 augusti 2015 10:55
To: mathi.naic...@oracle.com; Lennart Lund
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] log: saflogger should use built-in default log file
f
Ack. Compiled and started a single controller.
At some places, pointers are getting dereferenced, which looks not important to
me. It looks like legacy stuff.
Thanks
-Nagu
> -Original Message-
> From: Venkata Mahesh Alla
> Sent: 10 August 2015 16:52
> To: Nagendra Kumar
> Cc: opensaf-dev
Hi Minh,
Thanks for the patch.
I tested the following scenarios and it worked fine (Configurations: 3 Comps
and 3 CSIs with CSI dep configured) :
1. Unlock SU and report error from comp1 in Act assignment.
2. Unlock SI and report error from comp1 in Act assignment.
I also tested
Hi Neel.
Ack from me.
Not tested.
/AndersBj
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 30 juli 2015 15:47
To: Anders Björnerstedt; Zoran Milinkovic; mahesh.va...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1
Ack from me.
Not tested.
I think the solution for this ticket also relates to ticket #1313.
That ticket is about opensaf not starting in some cases when long DNs have been
enabled in the database.
This because the LOGD gets into some problem.
That problem could be some lookup done by LOGD into t
Summary: Create runtime call graph from OpenSAF trace files
Review request for Trac Ticket(s): #1142
Peer Reviewer(s): AndersW, Gary, Mathi
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
---
tools/devel/trace2dot | 169 ++
1 files changed, 169 insertions(+), 0 deletions(-)
Python script to create a runtime callgraph from OpenSAF trace files.
A dot file is created and can be viewed using e.g. dotty
diff --git a/tools/devel/trace2dot b
Hi Neelakanta,
Shouldn't sqliteTransLock be also decremented few lines above in "
if(sqliteTransLock != 1) {" statement ?
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Thursday, July 30, 2015 3:47 PM
To: Anders Björnersted
osaf/services/saf/amf/amfd/app.cc| 1 +
osaf/services/saf/amf/amfd/apptype.cc| 2 ++
osaf/services/saf/amf/amfd/chkop.cc | 2 ++
osaf/services/saf/amf/amfd/ckpt_enc.cc | 3 +++
osaf/services/saf/amf/amfd/comp.cc | 5 -
osaf/services/saf/am
Summary: amfd: Add missing TRACE_LEAVE
Review request for Trac Ticket(s): #1142
Peer Reviewer(s): Nagu, Praveen, Gary
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Docs
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Friday, July 31, 2015 5:25 PM
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: search for child o
Hi, please ignore this patch, I´ll send out a version 2. /Thanks HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
Sent: den 11 augusti 2015 15:11
To: praveen.malv...@oracle.com; nagendr...@oracle.com; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subje
osaf/services/saf/amf/amfd/app.cc| 1 +
osaf/services/saf/amf/amfd/apptype.cc| 2 ++
osaf/services/saf/amf/amfd/chkop.cc | 2 ++
osaf/services/saf/amf/amfd/ckpt_enc.cc | 3 +++
osaf/services/saf/amf/amfd/comp.cc | 5 -
osaf/services/saf/am
Summary: amfd: Add missing TRACE_LEAVE V2
Review request for Trac Ticket(s): #1142
Peer Reviewer(s): Nagu, Praveen, Gary
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Docs
Hi Nagu,
Thanks for the review.
I would like to incorporate following comment as well , which i have
received .
"In opensaf/osaf/libs/core/mds/mds_dt_common.c Line: 694
reassem_queue->tmr_hdl is not created until line 695 (m_MDS_LOG_DBG("
Reassembly tmr=0x%08x", reassem_queue->tmr_hdl);)"
Hi zoran,
In the few line above there is check to verify sqliteTransLock in "
while(sqliteTransLock) {" .
Multiple threads are present only for 2PBE case. In the 2PBE case if a
thread1 is waiting for lock and got the lock released,
then sqliteTransLock will be incremented. If in this time a
c
20 matches
Mail list logo
