[devel] [PATCH 0 of 1] Review Request for SMF #1578

2015-10-29 Thread Ingvar Bergstrom
Summary: smfd: comp AU filtering when merge to One Step corrected Review request for Trac Ticket(s): 1578 Peer Reviewer(s): Rafael Pull request to: Affected branch(es): 4.7 Development branch: 4.7 Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] imm: add a precedence of validation abort error string over resource abort error string [#1554]

2015-10-29 Thread Neelakanta Reddy
Hi zoran, Ideally, the errorstrings should capture all errors, that are the result of ccb apply. i.e : if the validation error is coming from more than one implementer then these errors needs to be captured and sent to OM. In the present patch, only one validation abort is added. README:

Re: [devel] [PATCH 1 of 1] smfd: comp AU filtering when merge to One Step corrected [#1578]

2015-10-29 Thread Rafael Odzakow
Reviewed it. Ack /Rafael On 10/29/2015 01:15 PM, Ingvar Bergstrom wrote: > osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 22 > +--- > 1 files changed, 10 insertions(+), 12 deletions(-) > > > When procedure merge to One Step is activated, smfd shall detect if > an AU

Re: [devel] [PATCH 1 of 1] imm: add a precedence of validation abort error string over resource abort error string [#1554]

2015-10-29 Thread Neelakanta Reddy
Hi zoran, I overlooked the "if" condition. Thanks, for explaining. Reviewed the patch. Ack. /Neel. On Thursday 29 October 2015 05:48 PM, Neelakanta Reddy wrote: > Hi zoran, > > Ideally, the errorstrings should capture all errors, that are the result > of ccb apply. > i.e : if the validation

[devel] [PATCH 1 of 1] smfd: comp AU filtering when merge to One Step corrected [#1578]

2015-10-29 Thread Ingvar Bergstrom
osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 22 +--- 1 files changed, 10 insertions(+), 12 deletions(-) When procedure merge to One Step is activated, smfd shall detect if an AU is in scpe of an already existing AU. e.g. if a component is in scope of a Node. This

Re: [devel] [PATCH 1 of 1] amfd: validate NG admin state at the time of creation [#1560]

2015-10-29 Thread Hans Nordebäck
ack, code review only/Thanks Hans On 10/29/2015 06:24 AM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/nodegroup.cc | 10 -- > osaf/services/saf/amf/amfd/util.cc | 2 +- > 2 files changed, 9 insertions(+), 3 deletions(-) > > > AMF allows creation of NG with

Re: [devel] [PATCH 1 of 1] amfd: reject si-swap if SI will remain with only active state (NWAY)[#1516]

2015-10-29 Thread Hans Nordebäck
Hi Praveen, I agreee, ack from me, code review only/Thanks HansN On 10/29/2015 05:17 AM, praveen malviya wrote: > > > On 29-Oct-15 4:22 AM, Hans Nordebäck wrote: >> Hi Praveen, >> >> trying to understand the problem below, if N-way and >> saAmfSGMaxStandbySIsperSU = 1, >> and say there are 2 SUs

Re: [devel] [PATCH 1 of 1] amfd: validate NG admin state at the time of creation [#1560]

2015-10-29 Thread Gary Lee
ack (review only) > On 29 Oct 2015, at 4:24 PM, praveen.malv...@oracle.com wrote: > > osaf/services/saf/amf/amfd/nodegroup.cc | 10 -- > osaf/services/saf/amf/amfd/util.cc | 2 +- > 2 files changed, 9 insertions(+), 3 deletions(-) > > > AMF allows creation of NG with invalid

Re: [devel] [PATCH 0 of 1] Review Request for imm: report resource abort for SA_AIS_ERR_NO_MEMORY and SA_AIS_ERR_NO_RESOURCES in saImmOmCcbApply [#1555]

2015-10-29 Thread Neelakanta Reddy
Hi zoran, Reviewed the patch. Ack. /Neel. On Friday 23 October 2015 01:53 PM, Zoran Milinkovic wrote: > Summary: imm: report resource abort for SA_AIS_ERR_NO_MEMORY and > SA_AIS_ERR_NO_RESOURCES in saImmOmCcbApply [#1555] > Review request for Trac Ticket(s): 1555 > Peer Reviewer(s): Neelakanta