Hi Neel,
Please see my comments inline.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Wednesday, November 18, 2015 4:17PM
To: Zoran Milinkovic, Hung Nguyen
Hi Hans
Thanks, I think db_template.h only exists under amfd.
Thanks
Gary
On 18/11/15 20:13, Hans Nordebäck wrote:
> ack, code review only, one comment below. /Thanks HansN
>
> On 11/18/2015 04:36 AM, Gary Lee wrote:
>> osaf/services/saf/amf/amfnd/compdb.cc | 15 +++
>>
Summary: amfd: ignore change to saAmfCompType if it is set to the same value
[#1602]
Review request for Trac Ticket(s): 1602
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): ALL
Development branch: default
Impacted area
osaf/services/saf/amf/amfd/comp.cc | 7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/comp.cc
b/osaf/services/saf/amf/amfd/comp.cc
--- a/osaf/services/saf/amf/amfd/comp.cc
+++ b/osaf/services/saf/amf/amfd/comp.cc
@@ -1227,6 +1227,13 @@ static
Ack.
Thanks,
Praveen
On 18-Nov-15 5:05 PM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/comp.cc | 7 +++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfd/comp.cc
> b/osaf/services/saf/amf/amfd/comp.cc
> ---
Hi Zoran/Hung,
I missed thinking for multi-valued and multi NO-DANGLING, attributes.
will re-publish the patch again.
/Neel.
On Wednesday 18 November 2015 03:56 PM, Zoran Milinkovic wrote:
>
> Hi Neelakanta,
>
> Agree with Hung’s comments.
>
> In an object, there can be more attributes with
Hi Rafael,
I think this is a useful sample to have. I have some comments on the
patch inline below.
/ Johan
On 11/18/2015 10:17 AM, Rafael Odzakow wrote:
> +#!/usr/bin/env python
> +""" Adds and removes IMM configuration for nodes """
> +
> +import re
> +import hashlib
> +import time
> +import
ack, code review only, one comment below. /Thanks HansN
On 11/18/2015 04:36 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfnd/compdb.cc | 15 +++
> osaf/services/saf/amf/amfnd/include/avnd_util.h | 7 +++
> 2 files changed, 18 insertions(+), 4 deletions(-)
>
>
>
Hi Neelakanta,
Agree with Hung's comments.
In an object, there can be more attributes with no-dangling flags, or
multi-value attribute with no-dangling flag. Multi-value attribute can also
have multiple object DNs.
Then this solution will not work correct.
BR,
Zoran
From: Hung Nguyen
osaf/services/saf/immsv/immnd/ImmModel.cc | 20
1 files changed, 20 insertions(+), 0 deletions(-)
If the NO_DANGLING reference is modified(removed) in the same CCB,
then deletion of the NO_DANGLING object can be allowed because, we
are in apply and the CCBcommit will
python/samples/scale_opensaf | 377 +++
1 files changed, 377 insertions(+), 0 deletions(-)
This script will add and remove IMM configuration for a node. Check the
help from argparser (-h) for more info. This version is limited and can be
Summary: pyosaf: add sample script to scale opensaf configuration [#1569]
Review request for Trac Ticket(s): 1569
Peer Reviewer(s): johan.o.martens...@ericsson.com anders.wid...@ericsson.com
Pull request to: Anders
Affected branch(es): 5.0
Development branch: <>
Summary:imm:Allow deletion of dangling ref object, when the object is modified
by clearing NO_DANGLING attribute in same CCB [#1599]
Review request for Trac Ticket(s): 1599
Peer Reviewer(s): zoran, Hung
Affected branch(es):4.6.x, 4.7.x, default
Development branch:4.7.x
osaf/services/saf/immsv/immnd/ImmModel.cc | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
If the NO_DANGLING reference is modified(removed) in the same CCB,
then deletion of the NO_DANGLING object can be allowed because, we
are in apply and the CCBcommit will modify
Summary: imm:Allow deletion of dangling ref object, when the object is modified
by clearing NO_DANGLING attribute in same CCB [#1599] V1
Review request for Trac Ticket(s): 1599
Peer Reviewer(s): Zoran, Hung
Affected branch(es): 4.6.x, 4.7.x, default
Development branch: 4.6.x
ack, code review only./Thanks HansN
On 11/18/2015 12:35 PM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/comp.cc | 7 +++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfd/comp.cc
> b/osaf/services/saf/amf/amfd/comp.cc
> ---
Tested, Ack,
Mathi.
- vu.m.ngu...@dektech.com.au wrote:
> tests/logsv/tet_LogOiOps.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>
> There is an uninitialized character in an static array of
> characters.
> When outputting the string, the character at that position
Tested Ack,
Mathi.
- vu.m.ngu...@dektech.com.au wrote:
> osaf/services/saf/logsv/lgs/lgs_evt.c | 7
> osaf/services/saf/logsv/lgs/lgs_imm.c | 11 +-
> osaf/services/saf/logsv/lgs/lgs_util.c | 57
> ++
> osaf/services/saf/logsv/lgs/lgs_util.h |
Hi Neelakanta,
Reviewed and tested the patch.
Ack with a minor comment on the performance. No need to send the code to
another review.
In the line line
if(ommi->second->mObjFlags & IMM_NO_DANGLING_FLAG){ //
IMM_NO_DANGLING_FLAG will be set in CcbModify
... another check can be
Hi Nhat,
This has already been addressed by ticket 1510.
Alex
-
osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
Problem:
In case handling openning checkpoint fails after adding the ckpt node into the
Hi Neel,
Please see my comments inline.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Wednesday, November 18, 2015 8:28PM
To: Hung Nguyen, Zoran Milinkovic
Hi Praveen,
Ack (Test only).
Thanks,
Quyen
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: Wednesday, November 18, 2015 12:42 PM
To: hans.nordeb...@ericsson.com; nagendr...@oracle.com;
quyen@dektech.com.au
Cc:
22 matches
Mail list logo
