ack, code review only/Thanks HansN
On 11/26/2015 08:41 AM, Quyen Dao wrote:
> configure.ac | 2 +
> osaf/libs/agents/saf/amfa/Makefile.am | 2 +-
> osaf/libs/agents/saf/amfa/tests/Makefile.am | 35
> +++
> osaf/services/
Summary: Setup directory and Makefile.am for amfa and amfnd google unit test
[#1610]
Review request for Trac Ticket(s): #1610
Peer Reviewer(s): Hans, Nagu, Praveen, Gary
Pull request to: Hans
Affected branch(es): default
Development branch: default
Impacted area
configure.ac | 2 +
osaf/libs/agents/saf/amfa/Makefile.am | 2 +-
osaf/libs/agents/saf/amfa/tests/Makefile.am | 35 +++
osaf/services/saf/amf/amfnd/Makefile.am | 2 +-
osaf/services/saf/amf/amfnd/tests/Makefile.am | 3
ack, code review only/Thanks HansN
On 11/25/2015 07:32 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/ckpt_dec.cc| 51 ++-
> osaf/services/saf/amf/amfd/ckpt_edu.cc| 54
> -
> osaf/services/saf/amf/amfd/ckpt_enc.cc
Hi AndersBj,
1)For the OI, only the attribute values that have actually being changed
must be included in the modify callback.
Even though the change is backward compatible, The following can be the
reasons for not sending unchanged values :
a. It follows SAF spec
b. waste of resources.
c. OI ar
Tested. Ack
Mathi.
> -Original Message-
> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
> Sent: Tuesday, November 17, 2015 11:55 AM
> To: Mathivanan Naickan Palanivelu; lennart.l...@ericsson.com;
> giang.t...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [P
Summary: core: Add unit test for sysf_ipc.c V3
Review request for Trac Ticket(s): #1520
Peer Reviewer(s): AndersW, Mathi, Ramesh
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
--
configure.ac |1 +
osaf/libs/core/leap/Makefile.am|2 +-
osaf/libs/core/leap/tests/Makefile.am | 51 +
osaf/libs/core/leap/tests/test_sysf_ipc.cc | 273 +
4 files changed, 326 insertions(+), 1 deletions(-)
Hi!
Ack from me, with some comments. I haven't had time to review the code,
so my comments are just from trying to build and test it. Since you
already have an ack from Mahesh, I think you can go ahead and push it
after you have fixed the first of my comments:
1 (major): If I configure OpenSAF
Hi Nagu,
I tested by adding some more logging and checked syslog for message
"Cold sync complete!",
this message is not seen in the syslog, but, with trace enabled the log
message is written to the trace log.
Syslog messages seems to be dropped, and it is not related to #1603.
So it is an ack f
Ack for this series and unit test patch from version1.
Thanks,
Praveen
On 25-Nov-15 4:04 PM, Hans Nordeback wrote:
> osaf/services/saf/amf/amfd/chkop.cc|2 +-
> osaf/services/saf/amf/amfd/ckpt_dec.cc | 107 +-
> osaf/services/saf/amf/amfd/ckpt_enc.cc | 353
> ---
Hi Hung,
The following is required by this ticket:
1. The saImmOiCcbObjectModifyCallback for implementer must pass only
the values of the attributes actually
modified by this modify operation will be provided. That is no deviation
from current implementation for OI.
The present patch changes
Hi Hans N,
Please find comments inlined with [Nagu].
Thanks
-Nagu
> -Original Message-
> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
> Sent: 24 November 2015 20:27
> To: Nagendra Kumar; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net; Hans Nordebäck
> Subject: RE: [
On 25-Nov-15 12:42 PM, Quyen Dao wrote:
> Hi Praveen,
>
> When the cluster starts, the saAmfCtDefInstantiationLevel is .
>
> root@SC-1:~# immlist -a saAmfCtDefInstantiationLevel
> safVersion=4.0.0,safCompType=OpenSafCompTypeAMFWDOG
> saAmfCtDefInstantiationLevel=
>
> If I change saAmfCt
Hi Praveen,
I'll put back the removed functions and send out a new review
request/Thanks HansN
On 11/25/2015 07:57 AM, praveen malviya wrote:
> one comment inline with [Praveen].
>
>
> On 20-Nov-15 1:12 PM, Hans Nordeback wrote:
>> osaf/services/saf/amf/amfd/chkop.cc |4 -
>> osaf
osaf/services/saf/amf/amfd/ckpt_dec.cc| 455 +++--
osaf/services/saf/amf/amfd/ckpt_edu.cc| 53 ---
osaf/services/saf/amf/amfd/include/ckpt.h |4 +
osaf/services/saf/amf/amfd/include/ckpt_edu.h |3 -
4 files changed, 203 insertions(+), 312 deletion
osaf/services/saf/amf/amfd/chkop.cc|2 +-
osaf/services/saf/amf/amfd/ckpt_dec.cc | 107 +-
osaf/services/saf/amf/amfd/ckpt_enc.cc | 353
3 files changed, 148 insertions(+), 314 deletions(-)
Simplify encode of AVD_COMP
diff --git a/osaf/services
Summary: Remove use of EDU and do direct encode of AVD_COMP V2
Review request for Trac Ticket(s): #1544
Peer Reviewer(s): Nagu, Praveen, Gary
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
-
18 matches
Mail list logo
