Hi Hung,
I agree that the enhancement will simplify the tasks for OI.
The worry , expressed was about the migration of OI (at least
middle-ware) to newer version and impacts.
The patch published previously, was not according to the discussion.
I would like to add some points before you start wor
Hi Lennart,
I have just found two things in imm_impl_set_sequence(). Please see my below
comments [Vu].
> + if ( true == *(bool*)
> lgs_cfg_get(LGS_IMM_LOG_OPENSAFLOGCONFIG_CLASS_EXIST)) {
> + (void)immutil_saImmOiClassImplementerSet(immOiHandle,
> "OpenSafLogConfig");
[Vu] Not s
Hi Mahesh,
The patch was updated with your comment.
Could you please help to run CPSV regression test? Thanks.
Best regards,
Nhat Pham
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Monday, December 7, 2015 3:48 PM
To: Nhat Pham ; anders.wid...@ericsson.com
Cc
I just had this hunk failure. Will try to resolve it and push.
Mathi.
- mathi.naic...@oracle.com wrote:
> Reviewed, Ack
> Mathi.
>
>
> > -Original Message-
> > From: Alex Jones [mailto:ajo...@genband.com]
> > Sent: Tuesday, November 24, 2015 8:59 PM
> > To: Mathivanan Naickan Palani
Reviewed, Ack
Mathi.
> -Original Message-
> From: Alex Jones [mailto:ajo...@genband.com]
> Sent: Tuesday, November 24, 2015 8:59 PM
> To: Mathivanan Naickan Palanivelu
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] plm: handle ATCA M7 state (communication lost)
> bett
Tested Ack,
Mathi.
> -Original Message-
> From: Lennart Lund [mailto:lennart.l...@ericsson.com]
> Sent: Thursday, December 03, 2015 5:25 PM
> To: Mathivanan Naickan Palanivelu; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] lgs: Correcting OI
I think it was not only because of the LSB non-compliance, but also because
having a syscall within logtrace is costly, bad!
The followup discussions ended with suggestions of using pthread_self() or
variatns of pthread_getthreadid(whichever is appropriate)
And also to avoid obtaining the threa
Ack, with minor comments:
1) Maybe rename the test_sysf_ipc.cc file to sysf_ipc_test.cc, to be
better aligned with common practice of adding _test at the end of the
file name?
2) The commit message should not have statements like "Updated to use
c++11 ..." or "Updated with review comments" mix
Ack. Not tested.
Regards,
Ramesh.
On 12/7/2015 2:59 PM, reddy.neelaka...@oracle.com wrote:
> osaf/libs/core/common/ncs_main_pub.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>
> when the ncs_leap_startup is called at initialization, it checks for node_id
> file. If node_id
osaf/libs/core/common/ncs_main_pub.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
when the ncs_leap_startup is called at initialization, it checks for node_id
file. If node_id file is not present, then ncs_util_get_sys_params will return
error. The error from ncs_util_get_sys_pa
Summary: base: Honour the return code, when node_id file is not present [#1623]
Review request for Trac Ticket(s): 1623
Peer Reviewer(s): Ramesh
Affected branch(es): default, 4.6.x, 4.7.x
Development branch: default
Impacted area Impact y/n
-
Hi Nhat ,
I did code review following are my comment :
Optional : Not required to have function for this
`cpd_proc_broadcast_RDSET_STOP(()
you can do write the event construction .
If you feel it will be useful in another context in future, just make
all lower case character.
If you are not
Hi Mahesh,
Have you had chance to look into the patch? Thanks.
Best regards,
Nhat Pham
-Original Message-
From: Nhat Pham [mailto:nhat.p...@dektech.com.au]
Sent: Wednesday, December 2, 2015 4:48 PM
To: 'A V Mahesh' ; anders.wid...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subj
13 matches
Mail list logo
