Summary: amfnd: Remove mbcsv code from amfnd [#1637]
Review request for Trac Ticket(s): #1637
Peer Reviewer(s): Hans, Praveen, Nagu, Gary
Pull request to: Hans Nordeback
Affected branch(es): default
Development branch: <>
Impacted area Impact y/n
Summary: amfnd: Delete comp_curr_info if comp fails into TERMINATION_FAILED
[#1500]
Review request for Trac Ticket(s): 1500
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): 4.6, 4.7, default
Development branch: default
Impacted area
osaf/services/saf/amf/amfnd/clc.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Escalation is configured in the way that just one component restart can lead
to su failover. If the clc cleanup script returns error, the component fails
into TERMINATION_FAILED state. The AMF repair com
ack, code review only/Thanks HansN
On 12/10/2015 11:38 AM, Anders Widell wrote:
> osaf/libs/core/common/include/osaf_time.h | 13 +++-
> osaf/libs/core/common/osaf_time.c | 51
> --
> 2 files changed, 33 insertions(+), 31 deletions(-)
>
>
> Simplify o
ack, code review only/Thanks HansN
On 12/10/2015 11:38 AM, Anders Widell wrote:
> osaf/libs/core/common/include/osaf_secutil.h | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>
> diff --git a/osaf/libs/core/common/include/osaf_secutil.h
> b/osaf/libs/core/common/include/osaf_se
ack, code review only/Thanks HansN
On 12/04/2015 06:44 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/ckpt_dec.cc| 68 +++-
> osaf/services/saf/amf/amfd/ckpt_edu.cc| 59 --
> osaf/services/saf/amf/amfd/ckpt_enc.cc| 77
ack, code review. One minor comment below. /Thanks HansN
On 11/26/2015 01:11 PM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/comptype.cc | 72
> ++---
> 1 files changed, 57 insertions(+), 15 deletions(-)
>
>
> Following commands causes amfd crash
ack, code review only./Thanks HansN
On 11/25/2015 07:20 AM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/comp.cc | 64
> ++---
> 1 files changed, 58 insertions(+), 6 deletions(-)
>
>
> Following three commands causes assert in amfd:
> immcfg -
ack, code review only. Minor comments below/Thanks HansN
On 11/04/2015 07:11 AM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/comp.cc | 22 ++
> osaf/services/saf/amf/amfnd/include/avnd_comp.h | 2 ++
> osaf/services/saf/amf/amfnd/include/a
On 14-Dec-15 1:40 PM, Lennart Lund wrote:
> Hi Praveen
>
> It seems relevant to remove this warning but is anything logged if logging
> actually fail?
If log service callback is meant here, then there is no return code
which confirms logging other than SA_AIS_ERR_TIMEOUT and SA_AIS_OK. Also
fo
I sent out a fix for osaf_secutil.h as part of ticket [#777].
regards,
Anders Widell
On 12/10/2015 08:37 AM, Vu Minh Nguyen wrote:
> Hi Lennart,
>
> osaf_secutil.h is a common header file, it is out of OpenSAF LOG scope. So I
> leave the fix to other responsible person.
> I have noticed this erro
Ack,
Mathi.
- hans.nordeb...@ericsson.com wrote:
> osaf/services/saf/clmsv/clms/clms_imm.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> diff --git a/osaf/services/saf/clmsv/clms/clms_imm.c
> b/osaf/services/saf/clmsv/clms/clms_imm.c
> --- a/osaf/services/saf/clmsv/clms
Summary: clmd: Assertion when calling immadm with invalid parameter
Review request for Trac Ticket(s): #1635
Peer Reviewer(s): Mathi
Pull request to:
Affected branch(es): default, opensaf-4.6.x, opensaf-4.7.x
Development branch: default
Impacted area Impact
osaf/services/saf/clmsv/clms/clms_imm.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/clmsv/clms/clms_imm.c
b/osaf/services/saf/clmsv/clms/clms_imm.c
--- a/osaf/services/saf/clmsv/clms/clms_imm.c
+++ b/osaf/services/saf/clmsv/clms/clms_imm.c
@@ -809,7
Summary: imm: Canonicalize attributes presented by OiCcbObjectModifyCallback
[#801]
Review request for Trac Ticket(s): 801
Peer Reviewer(s): Zoran, Neelakanta
Pull request to: Hung
Affected branch(es): default(5.0)
Development branch: default(5.0)
Impacted area
osaf/services/saf/immsv/immnd/ImmModel.cc | 142 +
osaf/services/saf/immsv/immnd/ImmModel.hh |8 +
osaf/services/saf/immsv/immnd/immnd_evt.c | 66 +++-
osaf/services/saf/immsv/immnd/immnd_init.h |2 +
4 files changed, 209 insertions(+), 9 deletions
Hi Praveen
It seems relevant to remove this warning but is anything logged if logging
actually fail?
The error checking seems a bit limited e.g. it is not checked if the error is
TRY AGIN or any other more permanent error. Also is there any mechanism for
giving up retrying?
Thanks
Lennart
> -
Mathi, Ramesh, a gentle reminder for review!/Regards HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
Sent: den 25 november 2015 18:33
To: mathi.naic...@oracle.com; ramesh.bet...@oracle.com; Anders Widell
Cc: opensaf-devel@lists.sourceforge.net
Subject: [
18 matches
Mail list logo
