Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

2016-02-10 Thread A V Mahesh
Hi, I jut starred reviewing patch , I will be giving comments as soon as I crossover any , to save some time. Comment 1 : This functionality should be under checks if Hydra configuration is enabled in IMM attrName = const_cast("scAbsenceAllowed") Please see example how LOG/AMF services imp

Re: [devel] [PATCH 1 of 5] amfd: Add README file for cloud resilience support [#1620] V2

2016-02-10 Thread praveen malviya
Hi Minh, I have marked some doubts with [Praveen]. Could you please answer them, it will helpful in understanding the changes in AMFD and AMFND. Thanks, Praveen On 20-Jan-16 9:03 AM, Minh Hon Chau wrote: > osaf/services/saf/amf/README-HEADLESS | 123 > ++ >

Re: [devel] FW: [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2 (delayed failover issue)

2016-02-10 Thread Nagendra Kumar
Hi Minh, Thanks. Yes, I will send the traces of the TC mentioned below after I am done with some other tests. The devel lists has limitation of 400 KB limit of attachment, so will see how can I send it, may be I can attach in the ticket as temporary. Thanks -Nagu > -Origina

Re: [devel] FW: [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2 (delayed failover issue)

2016-02-10 Thread minh chau
Hi Nagu, There's known limitation in IMM with configuration 2+1 or 1+1, which results in IMM reload at second controller restart. We're discussing to avoid the crash Meanwhile I'm also looking at the delayed failover issues which you reported on TC#2 #12 #13 #15 We have similar automated tests

Re: [devel] [PATCH 0 of 3] Review Request for MDS: Include node name as a part of Transport callback_info events [#1522]

2016-02-10 Thread A V Mahesh
Hi Lennar, On 2/10/2016 5:10 PM, Lennart Lund wrote: > mds_dt_trans.c: In function 'mds_mdtm_process_recvdata': > mds_dt_trans.c:928:5: error: too few arguments to function 'mds_mcm_node_up' > mds_mcm_node_up(svc_hdl, node_id, node_ip, addr_family); It seems you didn't applied the `[devel] [

Re: [devel] [PATCH 0 of 2] Review Request for clm: support simultaneous reboot of both controller nodes [#1646]

2016-02-10 Thread Gary Lee
HI Mathi Any comments regarding this series? Can we push it? Thanks Gary > On 19 Jan 2016, at 11:29 PM, Anders Widell wrote: > > Ack for the series (code review only). > > regards, > Anders Widell > > On 01/07/2016 05:38 AM, Gary Lee wrote: >> Summary: clm: support simultaneous reboot of bot

Re: [devel] [PATCH 1 of 5] NTF: Add support cloud resilience for NTF Agent [#1180]

2016-02-10 Thread minh chau
Hi Lennart, Thanks for comments, there're out of date comments from rl1. I also will update the patch to change "test ? x : y" to "if-else" after receives comments from Praveen and Vu Thanks, Minh On 11/02/16 00:17, Lennart Lund wrote: > Hi Minh > > Ack with comments. > Please see comments inli

Re: [devel] [PATCH 1 of 5] NTF: Add support cloud resilience for NTF Agent [#1180]

2016-02-10 Thread Lennart Lund
Hi Minh Ack with comments. Please see comments inline [Lennart] Thanks Lennart > -Original Message- > From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] > Sent: den 23 december 2015 05:02 > To: Lennart Lund; praveen.malv...@oracle.com; Vu Minh Nguyen > Cc: opensaf-devel@lists.sourcefo

Re: [devel] [PATCH 0 of 1] Review Request for amfa: Divide amf api functions in a thin C layer and use C++ for implementation [#1673]

2016-02-10 Thread Anders Widell
Does this add a dependency towards libstdc++ from the agent library? If it does, I think it would be problematic. It could interfere with an application which is also written in C++ but linked against a difference C++ standard library (either a different version of libstdc++, or a completely di

Re: [devel] FW: [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

2016-02-10 Thread Nagendra Kumar
TC #16. Same configuration as #12: Run SI shutdown and keep sleep of 5 sec before saAmfCSIQuiescingComplete and stop controller and then after sleep, reject saAmfCSIQuiescingComplete with SA_AIS_ERR_FAILED_OPERATION. All the assignment from SU1 on PL-3 and SU2 on PL-4 are removed and SI

Re: [devel] [PATCH 0 of 3] Review Request for MDS: Include node name as a part of Transport callback_info events [#1522]

2016-02-10 Thread Lennart Lund
Hi Mahesh I have applied your patch on the latest changeset on the devel branch. There is no problem to apply the patch. Before compiling I have done: > make distclean > ./bootstrap.sh > ./configure --enable-tipc --enable-tests When making I get the following compiler error: make[6]: Entering d

Re: [devel] [PATCH 0 of 1] Review Request for log: add support for cloud resilience feature [#1179]

2016-02-10 Thread Mathivanan Naickan Palanivelu
Hi Vu, Is it possible to break this down into smaller/logical changesets? And perhaps also the updated PR doc for changes to the Individual APIs? Thanks, Mathi. > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: Thursday, February 04, 2016 1:24 PM >

Re: [devel] [PATCH 0 of 5] Review Request for ntf: Add cloud resilience support [#1180]

2016-02-10 Thread praveen malviya
Hi Minh, I am going through the patches. Thanks, Praveen On 10-Feb-16 11:32 AM, minh chau wrote: > Hi Lennart, Praveen > > If you are not too busy, can you help to review the patches of #1180? > > Thanks, > Minh >>> -Original Message- >>> From: Minh Hon Chau [mailto:minh.c...@dektech.com