Re: [devel] [PATCH 1 of 1] lcknd: fix lock sync bug during election of new master [#1488]

Hi Anders, My comments inline... Alex On 03/07/2016 10:48 AM, Anders Widell wrote: > Hi! > > I was able to reproduce the problem and without your patch it happens > every time. With your patch it seems to work most of the time, but > sometimes I get a crash in the node director: > > #0

Re: [devel] [PATCH 1 of 1] lcknd: fix lock sync bug during election of new master [#1488]

Hi! I was able to reproduce the problem and without your patch it happens every time. With your patch it seems to work most of the time, but sometimes I get a crash in the node director: #0 _int_malloc (av=0x40c95760 , bytes=21) at malloc.c:3388 #1 0x409597b0 in __GI___libc_malloc

Re: [devel] [PATCH 1 of 1] amfd: delete su and its child objects at stdby amfd [#1683]

Hi Hans N, Thanks for the information. I am on leave today. I will correct it till this weekend. Tx Nagu - Original Message - From: hans.nordeb...@ericsson.com To: nagendr...@oracle.com, praveen.malv...@oracle.com, minh.c...@dektech.com.au, gary@dektech.com.au Cc:

Re: [devel] [PATCH 1 of 1] amfd: delete su and its child objects at stdby amfd [#1683]

Hi Nagu, There are problems building for opensaf-4.6.x with this patch, as 4.6.x don't have c++11 support enabled. /Thanks HansN -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 4 mars 2016 11:14 To: Hans Nordebäck; Praveen Malviya; Minh Chau H; Gary

Re: [devel] [PATCH 1 of 1] imm: add check for SC absence and 2PBE in cold sync for IMMD [#1625]

Hi Zoran, Reviewed and tested the patch. The approach is good,the similar defect must exit for 2PBE from Opensaf4.4. I suggest, to have MBCSV_VERSION 5 for 2PBE and MBCSV_VERSION 6 for scabsence. Either have a new defect for 2PBE or open a new defect. First 2PBE patch should go and on top of

Re: [devel] [PATCH 1 of 1] imm: add check for SC absence and 2PBE in cold sync for IMMD [#1625]

Hi Zoran, Reviewed and tested the patch. The approach is good,the similar defect must exit for 2PBE from Opensaf4.4. I suggest, to have MBCSV_VERSION 5 for 2PBE and MBCSV_VERSION 6 for scabsence. Either have a new defect for 2PBE or open a new defect. First 2PBE patch should go and on top of

Re: [devel] [PATCH 0 of 1] Review Request for log: log agent library is not backward compatible [#1686]

Hi Vu Ack with comment. Comment: It is not easy to understand what this fix is doing. I think a more descriptive comment could be a great help for a future maintainer. This comment could be in one place and describe why this is needed and how this solves the problem for both logFileName and

Re: [devel] [PATCH 1 of 1] imm: Remove coordinator role when SC absence happens [#1625]

Hi Hung, Comments inline. On Monday 07 March 2016 12:37 PM, Hung Nguyen wrote: > Hi Neel, > > Please find my answers inline. > > > BR, > Hung Nguyen - DEK Technologies > > > From: Neelakanta