Re: [devel] [PATCH 0 of 2] Review Request for imm: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-03-14 Thread Neelakanta Reddy
Hi Anders, Reviewed and tested the patch. Ack. /Neel. On Monday 29 February 2016 08:25 PM, Anders Widell wrote: > Summary: imm: Support AMF configurations containing more than two OpenSAF 2N > SUs [#79] > Review request for Trac Ticket(s): 79 > Peer Reviewer(s): Hung, Neelakanta, Zoran > Pull

Re: [devel] [PATCH 2 of 5] NTF: Add support cloud resilience for NTF Agent [#1180] V3

2016-03-14 Thread minh chau
Hi Lennart, The current code in agent now is using both protection of ncshm handle and global cb_lock mutex, and this happens in most of APIs with below patterns // take lock // doing something // if not success // unlock // goto done // unlock // continue doing something // done: //

Re: [devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-03-14 Thread minh chau
Hi Nagu, Praveen Since #1-#4 have been acked, can you please push them? #5 and #11_2 allows comp/su failover during headless, so we may have to visit them later. However, the patches: #9 #10 #11_1 #12 #13 are bug fixes that does not relate to *delayed failover* and needed for #1-#4. Can you

Re: [devel] [PATCH 0 of 1] Review Request for log: Extend information about origin of log record [#1480]

2016-03-14 Thread Lennart Lund
Hi Vu Ack Can push when the location of the .xml files is solved and is included in a patch to push and all other reviewers has acked. Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 14 mars 2016 11:03 > To: Lennart Lund;

Re: [devel] [PATCH 2 of 5] NTF: Add support cloud resilience for NTF Agent [#1180] V3

2016-03-14 Thread Lennart Lund
Hi Minh, I see that you are using mutexes inside the checkNtfServerState(). I don't think this is a good solution since the same mutex is used directly in the function calling checkNtfServerState(). The mutex usage in the checkNtfServerState() is hidden and there is a risk that this function

Re: [devel] [PATCH 0 of 1] Review Request for log: Extend information about origin of log record [#1480]

2016-03-14 Thread Anders Widell
See my comments inline. regards, Anders Widell On 03/08/2016 03:49 AM, Vu Minh Nguyen wrote: > Hi Lennart, > > Please see my responses inline, with [Vu]. > > Regards, Vu. > >> -Original Message- >> From: Lennart Lund [mailto:lennart.l...@ericsson.com] >> Sent: Thursday, March 03, 2016