Re: [devel] [PATCH 1 of 1] imm: update README with IMM enhancements for OpenSAF 5.0 [#1690]

2016-04-07 Thread Hung Nguyen
Hi Zoran, Reviewed the patch. Ack from me with one minor comment below. BR, Hung Nguyen - DEK Technologies From: Zoran Milinkovic zoran.milinko...@ericsson.com Sent: Thursday, April 07, 2016 7:20PM To: Neelakanta

Re: [devel] NTF PR doc update for #1639.

2016-04-07 Thread minh chau
Hi, Ack with comments: - The statement of 5) seems to be included in 2), maybe can combine 2) and 5) - Since ERR_UNAVAILABLE could be returned in A.02.01, PR doc should recommend what's client's behavior when receiving this error code, eg. try API again since node has not joined cluster, or ...

Re: [devel] [PATCH 4 of 6] ntfa: support for returning SA_AIS_ERR_UNAVAILABLE on non-member node[#1639] V2

2016-04-07 Thread minh chau
Hi Praveen, I see the latest ntfa_api.c code does not reserve SA_AIS_ERR_UNAVAILABLE when recovery client/reader/subscriber failed due to non-SA_AIS_OK rc in returned msg. Can you check whether this V2 was pushed? Thanks, Minh On 29/03/16 20:02, praveen.malv...@oracle.com wrote: > osaf/libs/a

Re: [devel] [PATCH 1 of 1] amfnd: return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop while headless [#1718]

2016-04-07 Thread minh chau
Ack from me Thanks, Minh On 07/04/16 13:53, Gary Lee wrote: > osaf/services/saf/amf/amfnd/pg.cc | 18 ++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > > return TRY_AGAIN for saAmfProtectionGroupTrack and > saAmfProtectionGroupTrackStop > while headless, since protec

Re: [devel] [PATCH 1 of 1] clm: Decrease the default election delay time to 200 ms [#1724]

2016-04-07 Thread Mathivanan Naickan Palanivelu
Anders, What's your thoughts on moving this to nid.conf. CLM may be the implementer, but the implication is system wide which is why this should go into nid.conf that contains the common configuration. Mathi. - mathi.naic...@oracle.com wrote: > Ack, > This variable should go into the 00-REA

Re: [devel] AMF PR doc for #1533.

2016-04-07 Thread minh chau
Ack with minor comment: In first page, do we need to update " Release 4.7 Programmer's Reference October 2015"? Thanks, Minh On 07/04/16 16:12, praveen malviya wrote: > Hi All, > > Please find attached AMF PR doc updated for #1533. > Only one minor change is done in section 2.2.10.1 Scope of Adm

[devel] [PATCH 1 of 1] AMFND: Do not disable healthy SU [#1721]

2016-04-07 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/su.cc | 5 - 1 files changed, 0 insertions(+), 5 deletions(-) Currently avnd_su_curr_info_del() is called in three places: (1). su restart recovery (2). su restart by admin op (3). su is terminated by su_pres_msg In case (1), (2), the code that reset SU's ope

[devel] [PATCH 0 of 1] Review Request for AMFND: Do not disable healthy SU [#1721]

2016-04-07 Thread Minh Hon Chau
Summary: AMFND: Do not disable healthy SU [#1721] Review request for Trac Ticket(s): 1721 Peer Reviewer(s): AMF maintainers Pull request to: AMF maintainers Affected branch(es): 5.0, default Development branch: default Impacted area Impact y/n ---

[devel] [PATCH 0 of 1] Review Request for imm: update README with IMM enhancements for OpenSAF 5.0 [#1690]

2016-04-07 Thread Zoran Milinkovic
Summary: imm: update README with IMM enhancements for OpenSAF 5.0 [#1690] Review request for Trac Ticket(s): 1690 Peer Reviewer(s): Neelakanta, Hung Pull request to: Zoran Affected branch(es): opensaf-5.0.x Development branch: opensaf-5.0.x Impacted area Impa

[devel] [PATCH 1 of 1] imm: update README with IMM enhancements for OpenSAF 5.0 [#1690]

2016-04-07 Thread Zoran Milinkovic
osaf/services/saf/immsv/README | 93 ++ 1 files changed, 93 insertions(+), 0 deletions(-) Update README with IMM enhancements diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README --- a/osaf/services/saf/immsv/README +++ b/osaf/ser

Re: [devel] [PATCH 1 of 1] pyosaf: Add NTF high-level bindings and sample applications [#1586]

2016-04-07 Thread Johan MÃ¥rtensson O
Hi Srikanth, Thanks for coming back to these patches. There are some limitations in these that need improvement but I think it's good to push them as a base. / Johan -Original Message- From: Srikanth Revanuru [mailto:srikanth.revan...@oracle.com] Sent: den 7 april 2016 13:56 To: Johan

Re: [devel] [PATCH 1 of 1] pyosaf: Add NTF high-level bindings and sample applications [#1586]

2016-04-07 Thread Srikanth Revanuru
Johan, Ack. Tested the sample applications. Couple of comments. "ntf" entry to Makefile.common and configure.ac is to be done. The file saNtf.py is using SaAnyT, which is not imported. I shall make those changes and push today. Thanks, Srikanth On 11/06/2015 08:28 PM, Johan MÃ¥rtensson w

Re: [devel] [PATCH 1 of 1] clm: Decrease the default election delay time to 200 ms [#1724]

2016-04-07 Thread Mathivanan Naickan Palanivelu
Or rather OSAF_ACTIVE_ELECTION_START_TIMEOUT Mathi. > -Original Message- > From: Mathivanan Naickan Palanivelu > Sent: Thursday, April 07, 2016 4:18 PM > To: Anders Widell > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [devel] [PATCH 1 of 1] clm: Decrease the default election del

Re: [devel] [PATCH 1 of 1] clm: Decrease the default election delay time to 200 ms [#1724]

2016-04-07 Thread Mathivanan Naickan Palanivelu
Ack, This variable should go into the 00-README.conf (and CLM PR too?) And we should consider moving this variable to nid.conf and perhaps call it OSAF_ACTIVE_ELECTION_DELAY! Mathi. > -Original Message- > From: Anders Widell [mailto:anders.wid...@ericsson.com] > Sent: Thursday, A

[devel] [PATCH 0 of 1] Review Request for clm: Decrease the default election delay time to 200 ms [#1724]

2016-04-07 Thread Anders Widell
Summary: clm: Decrease the default election delay time to 200 ms [#1724] Review request for Trac Ticket(s): 1724 Peer Reviewer(s): Mathi Pull request to: Affected branch(es): opensaf-5.0.x, default(5.1) Development branch: default Impacted area Impact y/n --

[devel] [PATCH 1 of 1] clm: Decrease the default election delay time to 200 ms [#1724]

2016-04-07 Thread Anders Widell
osaf/services/saf/clmsv/config/clmna.conf| 5 +++-- osaf/services/saf/clmsv/nodeagent/election_starter.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) For backwards compatibility reasons, decrease the default election delay time to 200 ms. Previously, the default electio

[devel] [PATCH 1 of 1] amfd: Reboot standby when failover fails due to out of sync [#1732]

2016-04-07 Thread Anders Widell
osaf/services/saf/amf/amfd/role.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) AMFD now orders a reboot of the standby SC in all cases when a failover STANDBY -> ACTIVE fails. Previously, the case when the failover failed because the standby AMFD was not in sync was handled diffe

[devel] [PATCH 0 of 1] Review Request for amfd: Reboot standby when failover fails due to out of sync [#1732]

2016-04-07 Thread Anders Widell
Summary: amfd: Reboot standby when failover fails due to out of sync [#1732] Review request for Trac Ticket(s): 1732 Peer Reviewer(s): Gary, Hans, Nagendra, Praveen Pull request to: Affected branch(es): opensaf-5.0.x, default(5.1) Development branch: default Impac

[devel] [PATCH 1 of 1] immtools: Use safe read to retrieve class name for immcfg [#1726]

2016-04-07 Thread Hung Nguyen
osaf/tools/safimm/immcfg/imm_cfg.c | 149 ++-- osaf/tools/safimm/immcfg/imm_import.cc | 14 +-- 2 files changed, 53 insertions(+), 110 deletions(-) This patch revert ticket #1283 and use safe read to retrieve class name for chained modify operations. diff --g

[devel] [PATCH 0 of 1] Review Request for immtools: Use safe read to retrieve class name for immcfg [#1726]

2016-04-07 Thread Hung Nguyen
Summary: immtools: Use safe read to retrieve class name for immcfg [#1726] Review request for Trac Ticket(s): 1726 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.0, 5.1 Development branch: 5.1 Impacted area Impact y/n -

[devel] [PATCH 0 of 1] Review Request for immtools: Improve object info list handling in immcfg [#1726]

2016-04-07 Thread Hung Nguyen
Summary: immtools: Improve object info list handling in immcfg [#1726] Review request for Trac Ticket(s): 1726 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 4.7 Development branch: 5.1 Impacted area Impact y/n --

[devel] [PATCH 1 of 1] immtools: Improve object info list handling in immcfg [#1726]

2016-04-07 Thread Hung Nguyen
osaf/tools/safimm/immcfg/imm_cfg.c | 138 ++-- 1 files changed, 85 insertions(+), 53 deletions(-) Improve object info list handling in immcfg. Don't search for existing object in objectInfoList when adding new object to the list. Use qsort() and bsearch() to sor