Ack (review only)
Thanks
Gary
> On 9 Apr 2016, at 2:04 AM, Anders Widell wrote:
>
> osaf/services/saf/amf/amfnd/compdb.cc | 6 --
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>
> Add missing braces to fix the following compilation error discovered when
> using
> GCC 6:
>
> compd
Yes, as we discussed we should aim to introduce a single common/global
configuration file.
Ofcourse today nid is that common place (because nid starts the core services).
Currently, they are mixed up in nid.conf and in services' configuration file.
Cheers,
Mathi.
> -Original Message-
> F
Hi Vu,
I had forgotten about this section that Lennart is referring to in the overview
doc (even though I introduced that section there J long time back).
For now, let's add your updates to that section, sorry it was my mistake that I
missed out giving the pointers to that section.
Havi
osaf/services/saf/logsv/lgs/lgs_stream.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Initialize the errno_save output parameters in all code paths in the function
fileclose_h(), to fix the following compilation error discovered when using GCC
6:
In file included from ../../../../.
Summary: log: Fix compilation errors [#1743]
Review request for Trac Ticket(s): 1743
Peer Reviewer(s): Lennart
Pull request to:
Affected branch(es): opensaf-5.0.x, default(5.1)
Development branch: default
Impacted area Impact y/n
tests/logsv/tet_Log_recov.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
Remove dead code to fix the following compilation error discovered when using
GCC 6:
tet_Log_recov.c:76:18: error: 'wr_delay' defined but not used
[-Werror=unused-const-variable=]
static const int wr_delay =
tests/immsv/management/test_saImmOmCcbObjectCreate_2.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
Remove dead code to fix the following compilation error discovered when using
GCC 6:
test_saImmOmCcbObjectCreate_2.c:20:30: error: 'nonExistingClassName' defined
but not used [-Werr
Summary: imm: Fix compilation errors [#1743]
Review request for Trac Ticket(s): 1743
Peer Reviewer(s): Hung, Neelakanta, Zoran
Pull request to:
Affected branch(es): opensaf-5.0.x, default(5.1)
Development branch: default
Impacted area Impact y/n
osaf/tools/safimm/immdump/imm_dumper.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Correct code indentation to fix the following compilation error discovered when
using GCC 6:
imm_dumper.cc: In function 'int main(int, char**)':
imm_dumper.cc:149:5: error: this 'if' clause does
Summary: amfnd: Add missing braces [#1743]
Review request for Trac Ticket(s): 1743
Peer Reviewer(s): Gary, Hans, Nagendra, Praveen
Pull request to:
Affected branch(es): opensaf-5.0.x, default(5.1)
Development branch:
Impacted area Impact y/n
---
osaf/services/saf/amf/amfnd/compdb.cc | 6 --
1 files changed, 4 insertions(+), 2 deletions(-)
Add missing braces to fix the following compilation error discovered when using
GCC 6:
compdb.cc: In function 'int comp_init(AVND_COMP*, const SaImmAttrValuesT_2**)':
compdb.cc:1579:2: error: thi
osaf/services/saf/amf/amfd/sg.cc | 23 +++
1 files changed, 23 insertions(+), 0 deletions(-)
amfd disallows changing saAmfSGMaxStandbySIsperSU while the SG is UNLOCKED
A check is performed in the code to disallow it.
Code needs to be added to handle the modification.
diff
Summary: amfd: allow increase of saAmfSGMaxStandbySIsperSU for N+M SG while
UNLOCKED
Review request for Trac Ticket(s): 1741
Peer Reviewer(s): praveen, nagu
Pull request to: nagu
Affected branch(es): default, 5.0, 4.7, 4.6
Development branch: <>
Impacted area
Hi!
To re-iterate on the comment regarding addition of new validations: what
I didn't realise when first commenting on this is that introducing such
additional restrictions would not be backwards compatible. We could
introduce additional restrictions like this, but then these new
restrictions
We don't actually have any global configuration file; nid.conf is only
common for the NID started services. I think we can wait until OpenSAF
5.1 and maybe introduce a global configuration file in that release.
regards,
Anders Widell
On 04/07/2016 06:15 PM, Mathivanan Naickan Palanivelu wrote:
osaf/services/saf/amf/amfnd/comp.cc | 2 +-
osaf/services/saf/amf/amfnd/susm.cc | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
When saAmfCSIDependencies is used to order CSIs, STANDBY assignment is done in
reverse order than ACTIVE assignment.
The code interprets the AMF B.04.01 s
Summary: amfnd: change handling of saAmfCSIDependencies to be same for STANDBY
as ACTIVE
Review request for Trac Ticket(s): 1734
Peer Reviewer(s): praveen, nagu
Pull request to: praveen
Affected branch(es): default, 5.0, 4.7, 4.6
Development branch:
Impacted area
Hi Vu
Wrong document!
I don't think the information about the new global configuration possibilities
in OpenSAF should be described in the extension document. It is better to
update the overview document. It can be placed as a sub section in the
"Tunable OpenSAF configuration parameters" secti
Hi all,
Have you had time to look at this? Thanks.
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Wednesday, April 06, 2016 12:44 PM
>To: 'Lennart Lund'
>Cc: 'mathi.naic...@oracle.com'; 'opensaf-devel@lists.sourceforge.net'
>Subject: RE
Hi Minh,
No comment from me. Ack.
Regards, Vu.
>-Original Message-
>From: minh chau [mailto:minh.c...@dektech.com.au]
>Sent: Thursday, April 07, 2016 7:28 AM
>To: praveen malviya; Lennart Lund; Vu Minh Nguyen
>Cc: opensaf-devel@lists.sourceforge.net
>Subject: Re: [devel] Review request f
20 matches
Mail list logo
