Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669]

Hi Nhat Pham, Can you please clarify below: If you mean `When a node restarts` the number of application on that node is also restarted (saCkptCheckpointNumOpeners) So I am assuming the test-case as below: A checkpoint is opened on multiple nodes and multiple application opened on multiple

Re: [devel] [PATCH 1 of 1] log: miss mutex protection for common resource in log agent [#1705]

Hi Mathi, Do you have any comment on the updated patch - lgsv_missMutexProtection_1705_r3.patch? Regards, Vu. >-Original Message- >From: Lennart Lund [mailto:lennart.l...@ericsson.com] >Sent: Thursday, April 21, 2016 2:37 PM >To: Vu Minh Nguyen; mathi.naic...@oracle.com >Cc:

Re: [devel] [PATCH 1 of 1] smfd: single step rollback does not call bundle scripts [#1771]

Hi Rafael, Ack This includes some nice cleanup in the SmfNodeSwLoadThread class :) One more thing that can be done is to simplify iterations over lists by using C++11 constructions when modifying them or when new ones are created. Also class variable initiation could be done the C++11 way

Re: [devel] [PATCH 1 of 1] amfnd: do not invoke health check command when npi comp is TERMINATING [#1759]

Ack, code review only/Thanks HansN -Original Message- From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] Sent: den 14 april 2016 11:38 To: Hans Nordebäck; nagendr...@oracle.com; Gary Lee; minh.c...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1

Re: [devel] [PATCH 1 of 1] log: fix the initialized log handle is deleted when initializing with unsupported version [#1739]

Hi Vu, I think that situation can indeed occur. Ack, Mathi. > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: Thursday, April 14, 2016 3:12 PM > To: Mathivanan Naickan Palanivelu; lennart.l...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net >

Re: [devel] [PATCH 1 of 1] clm: Use the empty() method to check if a set is empty [#1773]

Ack, Mathi. > -Original Message- > From: Anders Widell [mailto:anders.wid...@ericsson.com] > Sent: Thursday, April 21, 2016 2:17 PM > To: Mathivanan Naickan Palanivelu > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] clm: Use the empty() method to check if a set is >

[devel] [PATCH 1 of 1] clm: Use the empty() method to check if a set is empty [#1773]

osaf/services/saf/clmsv/nodeagent/election_starter.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) The empty() method should be used to check if a set is empty, instead of comparing the result of the size() method with zero. Depending on the STL implementation, the

[devel] [PATCH 0 of 1] Review Request for clm: Use the empty() method to check if a set is empty [#1773]

Summary: clm: Use the empty() method to check if a set is empty [#1773] Review request for Trac Ticket(s): 1773 Peer Reviewer(s): Mathi Pull request to: Affected branch(es): opensaf-5.0.x, default(5.1) Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] ntfa: return ERR_UNAVAILABLE on non-member node after headless state [#1744]

Hi, The addon patch at least can help existing NTF subscriber quickly finalizes as soon as node becomes non-member, this should not be late informed until the node rejoin cluster as current #1744. The next step how to detect NTF service available again depends on whether client is pure NTF

[devel] [PATCH 1 of 1] leap: Evaluate characteristics of sysf_timer [#1520]

osaf/libs/core/leap/tests/Makefile.am |3 +- osaf/libs/core/leap/tests/sysf_ipc_test.cc | 275 +--- 2 files changed, 90 insertions(+), 188 deletions(-) As a start, two unit test cases are written. The first unit test case, credit HansN, evaluates "jitter" using

Re: [devel] [PATCH 1 of 1] log: miss mutex protection for common resource in log agent [#1705]

Hi Vu, Ack with a minor comment - The _e suffix for typedef is not used in OpenSAF should be _t e.g. lgs_state_e -> lgs_state_t Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 20 april 2016 12:16 > To: Lennart Lund;