Re: [devel] [PATCH 1 of 1] amfd: Avoid SI swap if cold sync has not been requested [#1841]

Hi, I agree, this is how it should work. /Thanks HansN On 05/24/2016 07:58 AM, Nagendra Kumar wrote: > Hi Hans N, > Can we change uniformly the value of stby_sync_state in the > code with the following thoughts: > 1.If Standby controller is not available or just started syncing

Re: [devel] [PATCH 1 of 1] amfd: Avoid SI swap if cold sync has not been requested [#1841]

Hi Hans N, Can we change uniformly the value of stby_sync_state in the code with the following thoughts: 1. If Standby controller is not available or just started syncing, then the value of stby_sync_state will be OUT_OF_SYNC. 2. If Standby has synced up completely, then

Re: [devel] [PATCH 1 of 1] cpnd: To erase element from section_db if inserting the element into local_section_db fails [#1843] V2

Hi Mahesh, I could not reproduce the fault. I just found the fault based on backtrace and syslog. Best regards, Nhat Pham -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Tuesday, May 24, 2016 10:13 AM To: Nhat Pham ; anders.wid...@ericsson.com Cc: opensaf-devel

Re: [devel] [PATCH 1 of 1] cpnd: To erase element from section_db if inserting the element into local_section_db fails [#1843] V2

Hi Nhat Pham, Thanks for the updated patch. By the way, do you have any steps to reproduce ( in which scenario this issue occurred ) I know that this is a rollback case and little bit complex to reproduce , if you have any trick to reproduce please provide . -AVM On 5/24/2016 8:01 AM, Nhat

[devel] [PATCH 0 of 1] Review Request for cpnd: To erase element from section_db if inserting the element into local_section_db fails [#1843] V2

Summary: cpnd: To erase element from section_db if inserting the element into local_section_db fails [#1843] V2 Review request for Trac Ticket(s): 1843 Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: mahesh.va...@oracle.com Affected branch(es): default, 5.0,

[devel] [PATCH 1 of 1] cpnd: To erase element from section_db if inserting the element into local_section_db fails [#1843] V2

osaf/services/saf/cpsv/cpnd/cpnd_db.c | 31 ++- osaf/services/saf/cpsv/cpnd/cpnd_res.c | 11 ++- osaf/services/saf/cpsv/cpnd/cpnd_sec.cc | 7 ++- 3 files changed, 34 insertions(+), 15 deletions(-) Problem: There are 2 steps when a section i

Re: [devel] [PATCH 1 of 1] log: fix memory leaked after performing admin-op [#1844]

Ack, Mathi. > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: Monday, May 23, 2016 1:17 PM > To: Mathivanan Naickan Palanivelu; Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] log: fix memory leaked after performing ad

Re: [devel] [PATCH 1 of 1] log: fix memory leaked after performing admin-op [#1844]

Ack Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 23 maj 2016 09:47 > To: mathi.naic...@oracle.com; Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] log: fix memory leaked after performing admin-

[devel] [PATCH 0 of 1] Review Request for log: fix memory leaked after performing admin-op [#1844]

Summary: log: fix memory leaked after performing admin-op [#1844] Review request for Trac Ticket(s): #1844 Peer Reviewer(s): Mathi, Lennart Pull request to: Lennart Affected branch(es): all Development branch: default Impacted area Impact y/n ---

[devel] [PATCH 1 of 1] log: fix memory leaked after performing admin-op [#1844]

osaf/services/saf/logsv/lgs/lgs_imm.cc | 7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) logsv calls immutil_get_className() to get className, and that function returns an pointer to an allocated memory (strdup). So, the `className` must be freed after done using. diff --git a/osa

Re: [devel] [PATCH 1 of 1] amfnd: fix COMP-FO recovery when cleanup time is more than sufailoverprob[#1839]

Ack from me with a *missing place* to be updated Thanks, Minh On 23/05/16 16:52, praveen malviya wrote: > Hi All, > > I would like to push this patch today. > Please provide feedback. > > Thanks, > Praveen > > On 20-May-16 2:07 PM, praveen malviya wrote: >> >> >> On 20-May-16 12:38 PM, minh chau w