Ack.
In this V2, only default branch is mentioned in review report.
In V1, all branches were mentioned in review report.
Any reason for this change?
Thanks,
Praveen
On 02-May-16 11:37 PM, Alex Jones wrote:
> osaf/services/saf/amf/amfnd/comp.cc | 4 ++--
> osaf/services/saf/amf/amfnd/susm.cc |
Hi Mahesh,
Could you please help to push the patch? Thanks.
Best regards,
Nhat Pham
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, May 25, 2016 1:02 PM
To: Nhat Pham ; anders.wid...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [
ACK
-Please apply patch in both opensaf-5.0.x & opensaf-4.7.x
-Sanity testing done on both opensaf-5.0.x & opensaf-5.0.x
-Bug specific testing is rollback case on error and complex to reproduce.
-AVM
On 5/24/2016 8:58 AM, Nhat Pham wrote:
> Hi Mahesh,
>
> I could not reproduce the fault. I
Summary: pyosaf: Add __str__ method into non extended SaNameT class [#1737]
Review request for Trac Ticket(s): #1737
Peer Reviewer(s): Hans, Srikanth
Pull request to: Hans
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
-
python/pyosaf/saAis.py | 5 +
python/pyosaf/saImm.py | 2 +-
python/pyosaf/saNtf.py | 3 ++-
3 files changed, 8 insertions(+), 2 deletions(-)
with this change, user can call str(sa_name_t_obj) to convert
SaNameT to str without caring it's extended or non extended.
unmarshalSaImmValue and
ack. (documentation needs update, dep. to shellcheck)
/Thanks HansN
On 05/24/2016 05:07 PM, Anders Widell wrote:
> Makefile.common | 12
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
>
> Add a "shellcheck" build target that can be used in any subdirectory in the
> OpenSAF
Summary: build: Add shellcheck build target [#1838]
Review request for Trac Ticket(s): 1838
Peer Reviewer(s): Mathi, Hans
Pull request to:
Affected branch(es): opensaf-4.7.x, opensaf-5.0.x, default(5.1)
Development branch: default
Impacted area Impact y/n
--
Makefile.common | 12
1 files changed, 12 insertions(+), 0 deletions(-)
Add a "shellcheck" build target that can be used in any subdirectory in the
OpenSAF source tree. Use the following command to run it:
make shellcheck
diff --git a/Makefile.common b/Makefile.common
--- a/Makef
ack, (the OpenSAF quick start wiki page should be updated with the new
required cppcheck package).
/Thanks HansN
On 05/24/2016 10:36 AM, Anders Widell wrote:
> Makefile.am |6 +
> tests/cppcheck_append.cc | 190
> +++
> 2 files ch
Summary: build: Add cppcheck build target [#1774]
Review request for Trac Ticket(s): 1774
Peer Reviewer(s): Mathi, Hans
Pull request to:
Affected branch(es): opensaf-4.7.x, opensaf-5.0.x, default(5.1)
Development branch: default
Impacted area Impact y/n
Makefile.am |6 +
tests/cppcheck_append.cc | 190 +++
2 files changed, 196 insertions(+), 0 deletions(-)
Add a "cppcheck" build target at the top level of the OpenSAF source tree. Use
the following commands to run it:
make cppcheck
c
11 matches
Mail list logo
