Thanks, will change before pushing.
I will push this patch on Friday if there are no more comments?
> On 20 Jul 2016, at 7:34 PM, Anders Widell wrote:
>
> Ack with minor comments:
>
> 1) In the short line commit message: change "libs/core:" to "base:"
> 2) The scope of the variable "int i" in
Summary: base: Use INFO log priority level when failing to use real-time
priority [#1923]
Review request for Trac Ticket(s): 1923
Peer Reviewer(s): Ramesh
Pull request to:
Affected branch(es): opensaf-5.0.x, default(5.1)
Development branch: default
Impacted area
osaf/libs/core/leap/os_defs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Use INFO level syslog priority when we are unable to set real-time scheduling
priority. Otherwise syslog can be filled up with warning messages e.g. if an
opensaf command-line tool is used many times.
diff -
Regarding ticket [#1781], I think that one requires some more thought.
First of all, do we want to assign the STANDBY role to the OpenSAF
directors running on a CLM locked node? If we do want a CLM locked node
to become standby, then CLM ought to provide service to middleware
clients running o
Hi Minh,
For the ticket #1812 I had given one comment.
It was:
"In the fix of ticekt #1781, it has been suggested for spare controllers
to init with CLM before become AMF role aware. Here also same problem
will come. If spare is running on CLM locked node then it will never
come out of avd
Ack with minor comments:
1) In the short line commit message: change "libs/core:" to "base:"
2) The scope of the variable "int i" in osaf_encode_sanamet() can be
reduced (i.e. move it into the two for-loops: for (int i = ...).
thanks,
Anders Widell
On 07/19/2016 03:34 AM, Gary Lee wrote:
> os
osaf/services/saf/amf/amfd/include/sg.h | 1 +
osaf/services/saf/amf/amfd/nodegroup.cc | 4 +-
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 62 ++-
3 files changed, 62 insertions(+), 5 deletions(-)
Currently 2N, N-Way Active and NoRed models are supported for loc
Summary: amfd: support NplusM model for supported admin ops on NG [#1454]
Review request for Trac Ticket(s): #1454
Peer Reviewer(s): AMF devs
Pull request to: <>
Affected branch(es): default
Development branch: <>
Impacted area Impact y/n
