Ack (Code review only).
Thanks
-Nagu
> -Original Message-
> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
> Sent: 27 July 2016 13:49
> To: hans.nordeb...@ericsson.com; Nagendra Kumar; Praveen Malviya;
> gary@dektech.com.au; minh.c...@dektech.com.au
> Cc: opensaf-devel@lists.so
Hi Anders Widell,
Thank you very much for your comment.
I will get back to you after reviewing each comment.
-AVM
On 7/27/2016 6:54 PM, Anders Widell wrote:
> Hi!
>
> Some comments:
>
> 1) Have you considered using std::map instead of adding a new instance
> of NCS_PATRICIA_TREE?
> 2) At leas
Hi Vu,
Thank you very much for your comment.
I will get back to you after reviewing each comment.
-AVM
On 7/29/2016 9:20 AM, Vu Minh Nguyen wrote:
> Hi Mahesh,
>
> I have few comments, started with [Vu]:
>
> General: some places use tabs, some other places use spaces.
>
> Regards, Vu
>
>> -O
Dear Mahesh,
Thank you very much for your comment.
I start working on it from now.
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Friday, July 29, 2016 1:27 PM
To: Vo Minh Hoang
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 6 o
Hi Hoang,
Minor comment
-AVM
On 7/21/2016 3:04 PM, Hoang Vo wrote:
> osaf/libs/common/cpsv/cpsv_evt.c | 504
> ++-
> osaf/libs/common/cpsv/include/cpsv_evt.h | 24 +
> osaf/services/saf/cpsv/cpd/cpd_mds.c | 84 -
> osaf/services/saf/cpsv/cpn
Hi Hoang,
Minor comment
-AVM
On 7/21/2016 3:04 PM, Hoang Vo wrote:
> osaf/libs/agents/saf/cpa/cpa_api.c | 12 +---
> osaf/libs/agents/saf/cpa/cpa_mds.c | 2 +-
> osaf/libs/common/cpsv/cpsv_evt.c| 1 +
> osaf/services/saf/cpsv/cpd/cpd_evt.c| 10 +++---
Hi ,
I have proved some code related minor comment in 4 of 8 , 6 of 8 & 8 of
8 , please address them also in new patch(s).
Reading testing :
On 7/29/2016 7:49 AM, Vo Minh Hoang wrote:
> We do not have specific test case and environment for in-service update.
> So my test work is based on osaf
Hi Hoang,
Minor comment
-AVM
On 7/21/2016 3:04 PM, Hoang Vo wrote:
> osaf/libs/common/cpsv/include/cpsv_shm.h | 20 +-
> osaf/services/saf/cpsv/cpnd/cpnd_proc.c |1 -
> osaf/services/saf/cpsv/cpnd/cpnd_res.c | 821
> +++---
> 3 files changed, 634 insertion
Hi Gary,
Forgot to say that there are lots of white spaces especially in
utils.cc, please remove all of them and check at other places also.
Thanks
-Nagu
> -Original Message-
> From: Nagendra Kumar
> Sent: 28 July 2016 16:42
> To: Gary Lee; minh.c...@dektech.com.au; Prave
Hi Mahesh,
See my comments inline, started with [Vu].
Regards, Vu
> -Original Message-
> From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
> Sent: Tuesday, July 26, 2016 3:43 PM
> To: vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge
Hi Mahesh,
I have few comments, started with [Vu]:
General: some places use tabs, some other places use spaces.
Regards, Vu
> -Original Message-
> From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
> Sent: Tuesday, July 26, 2016 3:43 PM
> To: vu.m.ngu...@dektech.com.au; lenn
Dear Mahesh,
We do not have specific test case and environment for in-service update.
So my test work is based on osaftest cases.
I tested with old d - new nd and new d - old nd cases.
There are failed test cases but after investigating, they are intensional
when old one cannot recognize new mess
Hi Gary,
Ack with the following comment:
There is chance of getting Amfnd into loop, so please change :
// this loop construct is to handle BAD_HANDLE from
immutil_saImmOmSearchNext_2()
for (;;) {
To
As implemented in avd_imm_reinit_bg_thread in amfd-> imm.cc
wh
Summary:immtools: setting of explcit admin-owner is allowed in explicit commit
mode [#1383]
Review request for Trac Ticket(s): 1383
Peer Reviewer(s): Zoran, Hung
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
-
osaf/tools/safimm/immcfg/imm_cfg.c | 46 +
1 files changed, 36 insertions(+), 10 deletions(-)
diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c
b/osaf/tools/safimm/immcfg/imm_cfg.c
--- a/osaf/tools/safimm/immcfg/imm_cfg.c
+++ b/osaf/tools/safimm/immcfg/imm_cfg
Summary: amfd: handle SaNameT properly in avd_saImmOiRtObjectUpdate() [#1642]
Review request for Trac Ticket(s): 1642
Peer Reviewer(s): AMF devs
Pull request to: <>
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
osaf/services/saf/amf/amfd/imm.cc | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
SaNameT and SaStringT types need to be deep copied
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b/osaf/services/saf/amf/amfd/imm.cc
--- a/osaf/services/saf/amf/amfd/imm.cc
+++ b/osaf/serv
Hi Hoang,
I just started reviewing please share following :
I hope this Long DN should support In-service upgrade , if so,
please share the test case that you run , it will help me in reviewing
and in test uncovered use/test cases.
-AVM
On 7/21/2016 3:04 PM, Hoang Vo wrote:
> osaf/libs/
18 matches
Mail list logo
