Ok,
I just pushed
changeset: 7989:4d6caf6903cd
tag: tip
user:A V Mahesh
date:Tue Aug 30 11:05:31 2016 +0530
summary: clm: test code build fix [#1906]
-AVM
On 8/30/2016 11:28 AM, praveen malviya wrote:
> Hi Mahesh,
>
> I think this patch can be pushed as a workaround
Hi Mahesh,
I think this patch can be pushed as a workaround patch. Any improvement
on it can be taken up by CLM maintainers post FC tag.
Thanks,
Praveen
On 30-Aug-16 11:17 AM, A V Mahesh wrote:
> Hi Zoran Milinkovic,
>
> If below changes ok , we can push directly.
>
> =
ack, code review only/Thanks HansN
On 08/30/2016 07:36 AM, praveen.malv...@oracle.com wrote:
> opensaf.spec.in | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/opensaf.spec.in b/opensaf.spec.in
> --- a/opensaf.spec.in
> +++ b/opensaf.spec.in
> @@ -1457,6 +1457,7 @@
ack, code review only/Thanks HansN
On 08/30/2016 07:26 AM, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/util.cc | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfd/util.cc
> b/osaf/services/saf/amf/amfd/util.cc
> --- a/o
ack, code review only/Thanks HansN
On 08/29/2016 08:13 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/ckpt_enc.cc | 2 +-
> osaf/services/saf/amf/amfd/ndproc.cc | 8
> osaf/services/saf/amf/amfd/role.cc | 3 +--
> 3 files changed, 6 insertions(+), 7 deletions(-)
>
>
> fix
Hi Zoran Milinkovic,
If below changes ok , we can push directly.
===
diff --git a/tests/clmsv/tet_ClmLongRdn.c b/tests/clmsv/tet_ClmLongRdn.c
--- a/tests/clmsv/tet_ClmLongRdn.c
+++ b/tests/clmsv/tet_ClmLongRdn.c
@@ -188,19 +
Summary: amf: add saAmf_B_04_02.h in opensaf.spec.in [#1982]
Review request for Trac Ticket(s): #1982
Peer Reviewer(s): Anyone
Pull request to: <>
Affected branch(es): default
Development branch: <>
Impacted area Impact y/n
---
opensaf.spec.in | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/opensaf.spec.in b/opensaf.spec.in
--- a/opensaf.spec.in
+++ b/opensaf.spec.in
@@ -1457,6 +1457,7 @@ fi
%{_includedir}/saAis.h
%{_includedir}/saAis_B_5_14.h
%{_includedir}/saAmf.h
+%{_includedir}/saAmf_B_04_0
ack, code review only/Thanks HansN
On 08/29/2016 08:25 AM, Long HB Nguyen wrote:
> osaf/services/saf/amf/amfnd/cbq.cc | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfnd/cbq.cc
> b/osaf/services/saf/amf/amfnd/cbq.cc
> --- a/osaf/services
ACK ,
Build on
# gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/6.1.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: ../gcc-6.1.0/configure --prefix=/usr --enable-shared
--enable-threads=posix --enable-__cxa_atexi
Summary: amfd: fix compilation issue with gcc 6.1.1 [#1980]
Review request for Trac Ticket(s): #1980
Peer Reviewer(s): anybody
Pull request to: <>
Affected branch(es):default
Development branch: <>
Impacted area Impact y/n
osaf/services/saf/amf/amfd/util.cc | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/util.cc
b/osaf/services/saf/amf/amfd/util.cc
--- a/osaf/services/saf/amf/amfd/util.cc
+++ b/osaf/services/saf/amf/amfd/util.cc
@@ -1723,9 +1723,10 @@ static void
Hi All,
I just build http://hg.code.sf.net/p/opensaf/staging with following
changeset as sanity test
it build failed with .
changeset: 7982:106230d848a6
tag: tip
parent: 7979:aec46cc64cc8
user:Anders Widell
date:Mon Aug 29 19:29:55 2016 +0200
summary: uml: U
Hi Hung,
I already acknowledged the patch.
Thanks,
Neel.
On 2016/08/12 04:51 PM, Neelakanta Reddy wrote:
> Hi Hung,
>
> Reviewed and tested the patch.
> Ack.
>
> /Neel.
>
> On 2016/08/05 01:59 PM, Hung Nguyen wrote:
>> Summary: imm: Use high resolution time measurements [#1704]
>> Review request
Ack,
Thanks, Minh
On 29/08/16 16:25, Long HB Nguyen wrote:
> osaf/services/saf/amf/amfnd/cbq.cc | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfnd/cbq.cc
> b/osaf/services/saf/amf/amfnd/cbq.cc
> --- a/osaf/services/saf/amf/amfnd/cbq.cc
>
Ack
Thanks,Minh
On 29/08/16 16:13, Gary Lee wrote:
> osaf/services/saf/amf/amfd/ckpt_enc.cc | 2 +-
> osaf/services/saf/amf/amfd/ndproc.cc | 8
> osaf/services/saf/amf/amfd/role.cc | 3 +--
> 3 files changed, 6 insertions(+), 7 deletions(-)
>
>
> fix cppcheck errors introduc
Ack,
Mathi.
> -Original Message-
> From: Anders Widell [mailto:anders.wid...@ericsson.com]
> Sent: Monday, August 22, 2016 6:14 PM
> To: Mathivanan Naickan Palanivelu
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] build: Add missing include path to the top of the
> so
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 28 augusti 2016 04:30
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Avoid
Ack,
Mathi.
> -Original Message-
> From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
> Sent: Friday, August 26, 2016 7:39 PM
> To: Mathivanan Naickan Palanivelu
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] clm: add clm tests for testing long RDN support i
ok,
Ack from me.
Thanks,
Neel.
On 2016/08/29 06:09 PM, Rafael Odzakow wrote:
> For nodesForSingleStep only PLs are allowed for now. There is a plan
> to include SCs but that is for the future.
>
> Also having procedures with SCs in the campaign is not possible until
> SI swap is implemented.
>
For nodesForSingleStep only PLs are allowed for now. There is a plan to
include SCs but that is for the future.
Also having procedures with SCs in the campaign is not possible until SI
swap is implemented.
On 08/29/2016 02:30 PM, Neelakanta Reddy wrote:
> Hi Rafel,
>
> Reviewed and tested the
Hi Rafel,
Reviewed and tested the patch.
minor comments inline.
Questions:
1. For the new attribute "nodesForSingleStep" only PLs are allowed?
2. I tested giving controllers
immcfg -a numberOfSingleSteps=2 -a nodesForSingleStep=SC-1 -a
nodesForSingleStep=SC-2 openSafSmfExecControl=MergeC
Summary: uml: Update the UML environment [#1979]
Review request for Trac Ticket(s): 1979
Peer Reviewer(s): Hans
Pull request to:
Affected branch(es): opensaf-4.7.x, opensaf-5.0.x, default(5.1)
Development branch: default
Impacted area Impact y/n
Yes from me, but how's about AMF maintainers?
Thanks,
Minh
On 29/08/16 21:15, praveen malviya wrote:
> Hi Minh,
>
> I am pushing this README_NODEGROUP in amf directory.
> Any comment, will be updated post FC.
> Do you agree?
>
> Thanks,
> Praveen
>
>
> On 29-Aug-16 2:46 PM, praveen malviya wrote:
Hi Minh,
I am pushing this README_NODEGROUP in amf directory.
Any comment, will be updated post FC.
Do you agree?
Thanks,
Praveen
On 29-Aug-16 2:46 PM, praveen malviya wrote:
> Hi Minh,
>
> Following content will go in Readme:
>
> High Level Implementation Notes for LOCK and SHUTDOWN operation
Hi Long,
No further comments. Please remove them later.
Thanks,
Praveen
On 29-Aug-16 4:08 PM, Long Nguyen wrote:
> Hi Praveen,
>
> Do you have any comments for the PR?
>
> /_Note:_/ I will remove the internal changes in amfd and amfnd later.
>
> Best regards,
> Long Nguyen.
>
> On 8/23/2016 2:2
osaf/services/saf/immsv/immnd/immnd_evt.c | 112 ++---
1 files changed, 55 insertions(+), 57 deletions(-)
Add AdmReqContinuation only when fevs message is successfully forwarded.
diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c
b/osaf/services/saf/immsv/immnd/imm
Summary: imm: Add AdmReqContinuation only when fevs message is successfully
forwarded [#1977]
Review request for Trac Ticket(s): 1977
Peer Reviewer(s): Zoran, Neel
Pull request to:
Affected branch(es): 4.7, 5.0, 5.1
Development branch: 5.1
Impacted area Impa
Hi Praveen,
Do you have any comments for the PR?
/_Note:_/ I will remove the internal changes in amfd and amfnd later.
Best regards,
Long Nguyen.
On 8/23/2016 2:26 PM, Long Nguyen wrote:
> Summary: amf: update PR doc for long DN support [#1642]
> Review request for Trac Ticket(s): #1642
> Peer
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 28 augusti 2016 08:21
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review Re
Hi Hung,
Reviewed the patch.
Ack.
/Neel.
On 2016/08/28 11:50 AM, Hung Nguyen wrote:
> osaf/services/saf/immsv/config/immd.conf | 11 +++
> osaf/services/saf/immsv/immd/immd_cb.h | 1 +
> osaf/services/saf/immsv/immd/immd_main.c | 18 +++---
> 3 files changed, 27 in
Hi Minh,
Following content will go in Readme:
High Level Implementation Notes for LOCK and SHUTDOWN operation on NG:
===
In 2N model, there are broadly two cases for LOCK and SHUTDOWN operation
on NG:
A) Whole 2N SG is mapped in NG which m
Sorry. Please read it as "I would like to push it today"
Thanks,
Praveen
On 29-Aug-16 2:25 PM, praveen malviya wrote:
> Hi Gary,
>
> Any update on this.
> I think all non-major comments can be taken post FC also.
> If you do not any major comments, I would not like to push it today.
>
> Thanks,
>
Hi Gary,
Any update on this.
I think all non-major comments can be taken post FC also.
If you do not any major comments, I would not like to push it today.
Thanks,
Praveen
On 26-Aug-16 6:40 PM, praveen malviya wrote:
> Hi Gary,
>
> Please see inline with [Praveen].
>
> Thanks,
> Praveen
>
>
>
>
Summary: smf: SMF does not handle AMF long DN&RDN support
Review request for Trac Ticket(s): #1968
Peer Reviewer(s): rafael.odza...@ericsson.com, reddy.neelaka...@oracle.com
Pull request to: <>
Affected branch(es): <>
Development branch: <>
Impacted area Impa
osaf/services/saf/smfsv/smfd/SmfCampaignXmlParser.cc | 36 +--
osaf/services/saf/smfsv/smfd/SmfUtils.cc | 29 +++-
osaf/services/saf/smfsv/smfd/smfd.h | 1 -
osaf/services/saf/smfsv/smfd/smfd_cb.h | 1 +
osaf/services/saf
Hi Praveen,
Yes it's for #1454 and #1608
Thanks,
Minh
On 29/08/16 17:08, praveen malviya wrote:
> Hi Minh,
>
> Thanks for reviewing and testing.
> I guess the ack is for both #1454 and #1608.
> I will add a note.
>
>
> Thanks,
> Praveen
>
> On 29-Aug-16 12:21 PM, minh chau wrote:
>> Hi Praveen,
Hi Minh,
Thanks for reviewing and testing.
I guess the ack is for both #1454 and #1608.
I will add a note.
Thanks,
Praveen
On 29-Aug-16 12:21 PM, minh chau wrote:
> Hi Praveen,
>
> Ack (normal test only), the abnormal failover is supposed to work in
> REALIGN in NpM and Nway I think
> Maybe you
38 matches
Mail list logo
