Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi Mahesh, I have not tested this, but the following should work: - Set BSRsock TIPC_IMPORTANCE to TIPC_LOW_IMPORTANCE - set socket receive buffer to a small value: optval = "small socket recieive buffer size" , 5000 ? setsockopt(tipc_cb.BSRsock, SOL_SOCKET, SO_RCVBUF, , optlen) -

[devel] Immnd: maximum Ccbs limit 10000 has been reached very quickly

Hi All, I was running `immcfg` in a loop to create some object , once it reaches 10001objects creation Immnd is returning `ERR_NO_RESOURCES: maximum Ccbs limit 1 has been reached for the cluster` error which is unexpected , once `immcfg` reruns , it is expected that the `maximum Ccbs`

Re: [devel] [PATCH 1 of 1] log: fix cppcheck with performance severity [#1975]

Hi Canh Van Truong, Can you please share the suggestion reported by cppcheck. -AVM On 8/31/2016 2:19 PM, Canh Van Truong wrote: > osaf/services/saf/logsv/lgs/lgs_config.cc | 35 > -- > osaf/services/saf/logsv/lgs/lgs_file.cc | 4 +- > 2 files changed,

Re: [devel] [PATCH 1 of 1] log: fix errors reported by cppcheck version 1.75 [#1985]

Hi Canh Van Truong, On 8/31/2016 12:04 PM, Canh Van Truong wrote: > sprintf(command, VERIFY_CMD_, appLogPath, > - "safLgStrCfg=verDefaultLogFileFmt", tZoneMillP); > + "safLgStr=verDefaultLogFileFmt",tZoneMillP); [AVM] why string

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN, Sorry for the delay. I will test it and get back to you soon. -AVM On 8/31/2016 4:29 PM, Hans Nordebäck wrote: > Hi Mahesh, > Any updates on this? > > /Regards HansN > > -Original Message- > From: Anders Widell > Sent: den 25 augusti 2016 13:11 > To: A V Mahesh

Re: [devel] staging changeset: 7982 with gcc version 4.8.3 build failed

Hi Zoran, >> Mahesh, what kind of comment did you mean ? The below HansN comment : > [HansN] > >I know this is test code but side effects in asserts is to be avoided, but, > >shouldn't the code be like: > >rc = system(command); > >int status = WEXITSTATUS(rc); > >osaf_assert(status !=

Re: [devel] staging changeset: 7982 with gcc version 4.8.3 build failed

Hi, I took a pattern with locking/unlocking nodes from other CLM tests, but I removed assert. The reason for removing assert is that lock and unlock node functions are there only to ensure that the testing node is in a correct state. If it's not, the test will fail. So, assert is not needed,

Re: [devel] staging changeset: 7982 with gcc version 4.8.3 build failed

Hi, I looked further down in this mail and noticed the build problem, if a function is declared with e.g: int foo() __attribute__ ((__warn_unused_result__)); and called: foo(); then compiling with -Wall will result in the warning/error, but: if (foo()) {} should solve the build

Re: [devel] staging changeset: 7982 with gcc version 4.8.3 build failed

The commit fixes my build failure, but as Hans has pointed out there is still some quality issue with it. I suppose it is Hans' comment Mahesh refers to? regards, Anders Widell On 08/31/2016 12:45 PM, Zoran Milinkovic wrote: > Hi, > > I completely missed this email thread and the patch. > I

Re: [devel] staging changeset: 7982 with gcc version 4.8.3 build failed

Hi, I completely missed this email thread and the patch. I build OpenSAF with gcc 4.8.4 on Ubuntu, and haven’t had any building problem. If the patch works for Anders (gcc 5.x and/or 6.x), then I'm ok with the patch. I cannot test the build in my environment. Mahesh, what kind of comment did

Re: [devel] staging changeset: 7982 with gcc version 4.8.3 build failed

Iam looking into this. Thanks, Mathi. > -Original Message- > From: A V Mahesh > Sent: Tuesday, August 30, 2016 2:10 PM > To: Hans Nordebäck; Zoran Milinkovic > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [devel] staging changeset: 7982 with gcc version 4.8.3 build > failed >

[devel] [PATCH 1 of 1] log: fix cppcheck with performance severity [#1975]

osaf/services/saf/logsv/lgs/lgs_config.cc | 35 -- osaf/services/saf/logsv/lgs/lgs_file.cc | 4 +- 2 files changed, 16 insertions(+), 23 deletions(-) Fix performance reported by cppcheck. diff --git a/osaf/services/saf/logsv/lgs/lgs_config.cc

[devel] [PATCH 0 of 1] Review Request for log: fix cppcheck with performance severity [#1975]

Summary: log: fix cppcheck with performance severity [#1975] Review request for Trac Ticket(s): #1975 Peer Reviewer(s): Vu, Lennart, Mahesh Pull request to: Vu Affected branch(es): default Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 0 of 1] Review Request for imm: Add AdmReqContinuation only when fevs message is successfully forwarded [#1977]

Hi Hung, Reviewed the patch. Ack. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 29 augusti 2016 12:47 To: Zoran Milinkovic; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 0 of 1] Review Request

Re: [devel] [PATCH 1 of 1] amfnd: Incorrect ER messages in syslog [#1989]

Ack, code review only/Thanks HansN -Original Message- From: Long HB Nguyen [mailto:long.hb.ngu...@dektech.com.au] Sent: den 31 augusti 2016 06:29 To: Gary Lee ; Hans Nordebäck ; Minh Hon Chau ;

[devel] [PATCH 1 of 1] log: fix errors reported by cppcheck version 1.75 [#1985]

osaf/services/saf/logsv/lgs/lgs_clm.cc | 2 +- osaf/services/saf/logsv/lgs/lgs_evt.cc | 3 ++- tests/logsv/tet_LogOiOps.c | 4 ++-- tests/logsv/tet_log_longDN.c | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) Fix errors, reported by cppcheck:

[devel] [PATCH 0 of 1] Review Request for log: fix errors reported by cppcheck version 1.75 [#1985]

Summary: log: fix errors reported by cppcheck version 1.75 [#1985] Review request for Trac Ticket(s):#1985 Peer Reviewer(s): Vu, Lennart, Mahesh Pull request to: Vu Affected branch(es): 5.0.x, 5.1.x, default Development branch: default Impacted area Impact