Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

On 12-Sep-16 5:51 PM, minh chau wrote: > Hi Praveen, > > You think this V1 patch (being floated for review) is the way AMFD > should do for 5.2 (after GA), and for now 5.1 (this release) I should > make a function to read osafAmfSGFsmState? > I would like to confirm if I understand correctly. > I

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987] V2

Hi Minh, One minor comment, patch restores node->admin_ng pointers and for clearing these pointers it relies on process_su_si_response_for_ng(). But process_su_si_response_for_ng() will clear them for all nodes in first assignment response after headless. Because of there will problem in case

[devel] [PATCH 1 of 1] msg: memset ilist_info and track_info to avoid garbage [#2000]

osaf/services/saf/mqsv/mqd/mqd_mbcsv.c | 4 1 files changed, 4 insertions(+), 0 deletions(-) Garbage value causing the problem so memset() will fix the issue diff --git a/osaf/services/saf/mqsv/mqd/mqd_mbcsv.c b/osaf/services/saf/mqsv/mqd/mqd_mbcsv.c --- a/osaf/services/saf/mqsv/mqd/mqd

[devel] [PATCH 0 of 1] Review Request for msg: memset ilist_info and track_info to avoid garbage [#2000]

Summary:msg: memset ilist_info and track_info to avoid garbage [#2000] Review request for Trac Ticket(s): #2000 Peer Reviewer(s): Ramesh Pull request to: <> Affected branch(es): 5.1 & default Development branch: default Impacted area Impact y/n -

Re: [devel] [PATCH 2 of 4] AMFND: Admin operation continuation if csi completes during headless [#1725 part 1] V1

Hi Minh, I have tested these scenarios again and it works well. Thanks -Nagu > -Original Message- > From: minh chau [mailto:[email protected]] > Sent: 12 September 2016 11:53 > To: Nagendra Kumar; [email protected]; Praveen Malviya; > [email protected].

Re: [devel] [PATCH 1 of 1] ntf: cluster rebooted with ntfd crashed on both controllers [#2006]

Ack, Thanks, Praveen On 12-Sep-16 8:11 AM, Vu Minh Nguyen wrote: > osaf/libs/agents/saf/ntfa/ntfa_api.c | 18 + > osaf/libs/common/ntfsv/include/ntfsv_msg.h | 1 - > osaf/libs/common/ntfsv/ntfsv_mem.c | 10 ++- > osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 2 +- > tests/

[devel] [PATCH 0 of 1] Review Request for amf: Unit tests fail to build [#2019]

Summary: amf: Unit tests fail to build [#2019] Review request for Trac Ticket(s): #2019 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): default, 5.1, 5.0 Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] amf: Unit tests fail to build [#2019]

osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc b/osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc --- a/osaf/services/saf/amf/amfd/tests/test_ck

Re: [devel] [PATCH 0 of 1] Review Request for ntf: cluster rebooted with ntfd crashed on both controllers [#2006] V2

ack for code review. Thanks, Minh On 12/09/16 12:41, Vu Minh Nguyen wrote: > Summary: ntf: cluster rebooted with ntfd crashed on both controllers [#2006] > V2 > Review request for Trac Ticket(s): #2006 > Peer Reviewer(s): NTF maintainers > Pull request to: <> > Affected branch(es): all > Developm

Re: [devel] [PATCH 1 of 1] smf: SMF does not handle AMF long DN&RDN support [#1968]

Hi Lennart, Reviewed the patch. Ack. /Neel. On 2016/08/29 01:09 PM, Lennart Lund wrote: > osaf/services/saf/smfsv/smfd/SmfCampaignXmlParser.cc | 36 > +-- > osaf/services/saf/smfsv/smfd/SmfUtils.cc | 29 +++- > osaf/services/saf/smfsv/smfd/smfd.h

Re: [devel] [PATCH 0 of 1] Review Request for smf: SMF does not handle AMF long DN&RDN support [#1968]

ACK On 08/29/2016 09:39 AM, Lennart Lund wrote: > Summary: smf: SMF does not handle AMF long DN&RDN support > Review request for Trac Ticket(s): #1968 > Peer Reviewer(s): [email protected], [email protected] > Pull request to: <> > Affected branch(es): <> > Development branch:

[devel] [PATCH 0 of 1] Review Request for AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987] V2

Summary: AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987] V2 Review request for Trac Ticket(s): 1987 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): 5.1, default Development branch: default Impacted area Im

[devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987] V2

osaf/services/saf/amf/amfd/include/node.h | 3 + osaf/services/saf/amf/amfd/include/sg.h | 5 +- osaf/services/saf/amf/amfd/ndfsm.cc | 3 +- osaf/services/saf/amf/amfd/nodegroup.cc | 83 +++ osaf/services/saf/amf/amfd/sg.cc | 52 ++

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

Hi Praveen, You think this V1 patch (being floated for review) is the way AMFD should do for 5.2 (after GA), and for now 5.1 (this release) I should make a function to read osafAmfSGFsmState? I would like to confirm if I understand correctly. Thanks, Minh On 12/09/16 21:34, praveen malviya wro

Re: [devel] [PATCH 1 of 1] base: Fix build problem due to missing include [#2026]

Ack. Thanks, Ramesh. On 9/12/2016 5:03 PM, Anders Widell wrote: > osaf/libs/core/common/include/osaf_poll.h | 3 ++- > osaf/libs/core/common/osaf_poll.c | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > > diff --git a/osaf/libs/core/common/include/osaf_poll.h > b/osa

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

Hi Minh, I did not go through the readme. But I still think we should change it that way after GA release for 5.2 and for 5.1 it should be read by writing a small function (suggested by you in this mail) that would be called in the end on existing avd initialization sequence. If you agree, plea

[devel] [PATCH 0 of 1] Review Request for base: Fix build problem due to missing include [#2026]

Summary: base: Fix build problem due to missing include [#2026] Review request for Trac Ticket(s): 2026 Peer Reviewer(s): Ramesh Pull request to: Affected branch(es): opensaf-5.1.x, default(5.2) Development branch: default Impacted area Impact y/n --

[devel] [PATCH 1 of 1] base: Fix build problem due to missing include [#2026]

osaf/libs/core/common/include/osaf_poll.h | 3 ++- osaf/libs/core/common/osaf_poll.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/osaf/libs/core/common/include/osaf_poll.h b/osaf/libs/core/common/include/osaf_poll.h --- a/osaf/libs/core/common/include/osaf_p

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

Hi Praveen, This is whole text documented in IMM README " Cached RTAs show latest cached value when OI is transiently detached (4.6) == http://sourceforge.net/p/opensaf/tickets/1156 OM clients performing a read (iteration or

Re: [devel] [PATCH 1 of 1] amf: Build failure on 32-bit system [#2018]

Ack, not tested. Thanks, Praveen On 12-Sep-16 1:31 PM, Long HB Nguyen wrote: > osaf/services/saf/amf/amfnd/comp.cc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfnd/comp.cc > b/osaf/services/saf/amf/amfnd/comp.cc > --- a/osaf/services/s

[devel] [PATCH 0 of 1] Review Request for amf: Build failure on 32-bit system [#2018]

Summary: amf: Build failure on 32-bit system [#2018] Review request for Trac Ticket(s): #2018 Peer Reviewer(s): AMF devs Pull request to: Minh Affected branch(es): 5.1, default Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] amf: Build failure on 32-bit system [#2018]

osaf/services/saf/amf/amfnd/comp.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/osaf/services/saf/amf/amfnd/comp.cc b/osaf/services/saf/amf/amfnd/comp.cc --- a/osaf/services/saf/amf/amfnd/comp.cc +++ b/osaf/services/saf/amf/amfnd/comp.cc @@ -3013,7 +3013,7 @@ void avn

[devel] [PATCH 2 of 3] fix segfault

osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.cc | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git a/osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.cc b/osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.cc --- a/osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.

[devel] [PATCH 1 of 3] smfd: Merge rolling to singlestep procedures for several nodes [#1685]

osaf/services/saf/smfsv/config/smfsv_classes.xml| 1084 +- osaf/services/saf/smfsv/smfd/Makefile.am| 8 +- osaf/services/saf/smfsv/smfd/SmfCampState.cc| 151 +-- osaf/services/saf/smfsv/smfd/SmfCampaign.cc |77 +- osaf/services/saf/smfsv/s

[devel] [PATCH 3 of 3] uniqe actions and assert if controller in nodesForSingleStep

osaf/services/saf/smfsv/smfd/SmfExecControl.cc | 121 +++ osaf/services/saf/smfsv/smfd/SmfExecControl.h | 11 +- osaf/services/saf/smfsv/smfd/SmfProcState.cc|5 +- osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 39 - osaf/services/saf/smfsv/sm

[devel] [PATCH 0 of 3] Review Request for Merge rolling to singlestep procedures for several nodes [#1685]

Summary: Merge rolling to singlestep procedures for several nodes Review request for Trac Ticket(s): #1685 Peer Reviewer(s): lennart Pull request to: <> Affected branch(es): <> Development branch: <> Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

Hi Minh, Please see response inline. Thanks, Praveen On 12-Sep-16 6:10 AM, minh chau wrote: > Hi Praveen, > > Please find my comments with [Minh] > > Thanks, > Minh > > On 09/09/16 21:57, praveen malviya wrote: >> Hi Minh, >> >> Please find inline. >> >> Thanks, >> Praveen >> >> On 09-Sep-16 4:3